$context['html_footers']

Arantor · March 10, 2010, 07:38:31 PM

Right now there is a construct, $context['html_headers'] that can be populated with items to add into the theme in the <head> block and can be done as a source level edit, so it works on almost all themes with minimal support issues.

I'd like a similar construct for the footer, to inject content just before </body> in the html_below subtemplate (IIRC, at least) so that for scripts that load JS files that don't need to be available on page load, or ideally should be triggered at the end of loading, e.g. Google Analytics, they can be done without modifying the template.

It'd simplify all the mods that add JS items to the page (analytics mods, 'weather' mods, plus some of the stuff I have in mind for AJAX which would be better served inline at the end of the page, not the start)

JBlaze · March 10, 2010, 07:41:42 PM

+1

Arantor · March 10, 2010, 07:45:58 PM

Also, while I'd normally argue that 2.0 is feature-locked etc, I'd actually be inclined to argue this one is not really a feature per se, it's a tweak that completes what's already there.

All it would have to be is:

Load.php, find:

Code Select

	// Some basic information...
	if (!isset($context['html_headers']))
		$context['html_headers'] = '';

Add after:

Code Select


	if (!isset($context['html_footers']))
		$context['html_footers'] = '';

And index.template.php (Curve, probably same for Core, not checked)

Code (find) Select

	echo !empty($settings['forum_width']) ? '
</div>' : '', '
</body></html>';
}

Code (replace) Select

	echo !empty($settings['forum_width']) ? '
</div>' : '', $context['html_footers'], '
</body></html>';
}

You don't even have to alter the list of variables called into scope in template_html_below since it already adds it (not sure why anything other than $settings is there though...)

Nick Whetstone · March 10, 2010, 07:55:53 PM

Quote from: JBlaze on March 10, 2010, 07:41:42 PM
+1

Awesome idea.

vbgamer45 · March 10, 2010, 07:57:57 PM

I like the idea!

vicram10 · March 10, 2010, 09:14:31 PM

+2

I like the idea, is something missing and it would be very necessary and useful

digger · March 14, 2010, 07:54:09 PM

+1000

Arantor · March 20, 2010, 09:48:06 PM

I just discovered something.

While researching the integration hooks, I randomly discovered that in RC3 at least, there is actually a variable that amounts to this: $context['insert_after_template']

It does basically the same job and is called as far as I can tell by the theme system prior to template_footer being used. I was looking for it in the template, but it's there in the theme system in Subs.php (obExit function), assuming ;xml isn't in the URL (which is sensible)

Go forth and add footer code! (Yes, this means you could use it to add Google Analytics Code totally without touching the theme)

Joshua Dickerson · May 06, 2010, 04:00:07 PM

btw, it was tracked and closed http://dev.simplemachines.org/mantis/view.php?id=4292

News:

$context['html_footers']