News:

Wondering if this will always be free?  See why free is better.

Main Menu

[4430] avatar size

Started by Grim Line, August 17, 2010, 05:22:01 PM

Previous topic - Next topic

Grim Line

SMF 2.0 RC3

Currently the max image dimensions are 64x64. I want to change it to 90x90 but when i do all images which are perfect at 64x64 change to 90x90 i do not want this. I want them to all stay 64x64 but allow images that are up to 90x90 to be added aswell. How do i do this? So 1x1 all the way to 90x90 can be viewed.

Matthew K.

Is this happening with default avatars that either were on the SMF install, or ones that you added to your forum via a package? Or all avatars?

Grim Line

#2
Avatars from specified URL's

All images are 64x64 on the website and all images come from the same website.

Kill Em All

#3
This might be a bug with SMF I believe. I'll mark it in the bug tracker. However, if its downloaded to the site, then it will maintain the proper size.

http://dev.simplemachines.org/mantis/view.php?id=4430


My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

Norv

I don't seem to replicate this. Can you please exactly what settings are you using for avatars and exemplify the problem? Maybe a screenshot?
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

Kill Em All

I'm using the DEV 20100821 build.

Here is screen shot.


My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

Oya

when using an external avatar smf has no knowledge of how big it is so cant put the size into the tml of th epage when you set the html to resize it it will always resize it to that size no matter if it was ibgger or smaller

if you use javascript to resize it will be right though

Norv

I think it was html resizing, yes. I can't replicate it with javascript (as expected).
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

Kill Em All

Weird, JS works for me now... :/


My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

Norv

I'll close it for now, but if there are further issues, we can always reopen it.
To-do lists are for deferral. The more things you write down the later they're done... until you have 100s of lists of things you don't do.

File a security report | Developers' Blog | Bug Tracker


Also known as Norv on D* | Norv N. on G+ | Norv on Github

Kill Em All

Well HTML is still causing issues...


My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

Oya

and unless you have it download the avatar to know its size html will always cause issues

Kill Em All

No, because if the image is smaller than the max, then it shouldn't even be touching the image. If its larger, than it should be....


My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

Oya

yes it will

when you resize by html, the img tag just has the size in it that is in the acp

since smf is not aware of the size of the image at any point, all it can do is insert the size into the img tag to be 65x65 or whatever its set to and the browser will forcibly resize it to that

unless you download it to smf somewhere so it knows the size it won't change it

Kill Em All

So your saying that there is no way SMF can review the image and find out the size? Maybe I'm not thinking this out far enough, but then where does the browser get the image size details?


My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

excaliburj

Quote from: Kill Em All on September 04, 2010, 06:11:55 PM
So your saying that there is no way SMF can review the image and find out the size?

Not when you tell it to let the HTML resize it. In that case you are specifically saying to let the user's browser take care of that (just the browser without using javascipt).


Quote from: Kill Em All on September 04, 2010, 06:11:55 PM
Maybe I'm not thinking this out far enough, but then where does the browser get the image size details?

From the image. The browser encounters an img tag and it requests the file that the URL points to. Just that file. That request doesn't go through SMF anymore (SMF generated that original img tag, of course; but it's done with the page by this time).

And if the img element contains a width and/or height specification, the browser will display the image in a box with that/those dimension(s).

Years ago, the CSS spec added max-width and max-height attributes, which would act only to make the presented image smaller, but not expand it. But IE (6 & 7; not sure about 8 ) never honored it. There are some kludgy attempts to work around it out there, but I'm not sure how well any of them really work (I'm generally suspect of anything that would really on even MORE IE quirkiness to solve IE-specific problems).
Random Sig Line

Kill Em All

Ah, I see. Alright, thanks for the explanation. :)


My Site: KEAGaming.com

Manual Installation of Mods
Prevent Spam and Forum Attacks
Please do not PM or email me for support unless offered, help should be publicly displayed to others.

Advertisement: