Why the issue with ManageSmileys.php when upgrading from 1.1.11 to 1.1.12?

[SlowPaddle]

I was going to upgrade my forum from 1.1.11 to 1.1.12 but have a FAILED error showing in the ManageSmileys.php portion of the upgrade.

Seeing as I never made any changes to that file, shouldn't the upgrade reflect that it was part of the last package and not fail?

I'd like to upgrade my site but this failure thing has me worried. I have a working forum with a good membership base I've worked at for three years and don't want to lose it. Shouldn't the update have taken the ManageSmileys.php from the 1.1.11 version into account for this last update?

Any help someone can give to get me into 1.1.12 without losing my forum would be appreciated.

SP

[Illori]

take a look at http://www.simplemachines.org/community/index.php?topic=407312.msg2838776#msg2838776 and the attached file I made.

[Norv]

SlowPaddle,
You are not going to lose your forum, no worries, please.

The upgrade does indeed take into account the 1.1.11 file, however you must have changed it a bit, because the 1.1.11 file (same as older files actually, the 1.1.10 file also) had a bug, preventing you from accessing smileys in Admin. This bug has been solved in 1.1.12 now. However, if you (or another admin) did it yourself in the past, the changes might conflict now. This is NOTHING to worry about though.

Please, do update, then eventually, if you want to be sure, take a look at the edits done by the update in that file (you can find them here: http://custom.simplemachines.org/upgrades/index.php?action=upgrade;file=smf_patch_1.0.20_1.1.12.tar.gz;smf_version=1.1.11) and compare with your current file. If you simply make sure that those edits are actually done, you're absolutely okay.

Nothing of this however, will have any impact on your database, so on your data and everything else. Please do make a database backup anyway, like before any upgrade, to be sure.


ETA: ninja-ed.

[SlowPaddle]

Thanks so very much for all of the quick replies.

Illori, thanks for that link. I book-marked it in case I have any future issues.

Norv, thanks for the reply. I have always been able to access and edit my smileys since I first installed the forum back when it was Version 9. No changes were ever made to the ManageSmileys.php file as far as I can remember. And I am the only one that can access that file.

Anyway, I did the upgrade after backing up my database like you suggested. Seems that everything is working OK so far. I can still access the smileys and edit them even though there was the FAILED warning.

Just glad it all worked out. I always like to keep my forum up to date and appreciate the help.

SP

[JimM]

Marking this one as solved.  I had the same issue with my forum because I had already fixed the smiley issue.

[Finny]

Well I am having the same problem as described.

I got the ManageSmileys.php as posted here and put it on my server. I still get the ManageSmileys.php error when I go to update from 1.1.11 to 1.1.12.

What should I do? Ignore it?

[Illori]

if you download the fix you dont need to worry about the package manager applying the fix to that file.

[Finny]

Ok. Thanks.

I'll do it then.