Share This Topic

[DrBermant]

If you have or had custom coding, then  installing this new version will not restore your custom coding,  thats the problem with custom coding and I remember told you about it,  it would have been so much better if you would have asked my about it,  this new version only fix very particular issues and does not add any new feature, so it would be just fine if you would have stayed with the old one with custom coding on it.



But no, after further testing I discover another few bugs,  thats why I'm going to remove the package until I have it tested properly and the mod is stable enough for public use.

The mod is up and working as it did before I tried the newest version. The modified files were just as they were changed. Before applying any future updates of this mod, I will certainly ask as it took way too much work restoring the site.

How will I know if future mods will need custom coding work? The simplest answer will be to ask anytime there is an update.

Again thank you for your help.

It also sometimes pays not to be the first on the block with a change. Let others be the testing grounds.

You can see the mod working here in the older version:

http://www.abodybeautiful.com/forum/index.php/topic,263.0.html

Michael Bermant, M.D.

[Arantor]

It also sometimes pays not to be the first on the block with a change. Let others be the testing grounds.

Hopefully not everyone does that otherwise nothing would ever be tested...

[All Colours Sam]

I guess I'm not allowed to make mistakes...     good thing about this is that it let me know that this mod is actually being used


And no, I do not have a beta testers team or otherwise people to test this before it gets public.

[Arantor]

I guess I'm not allowed to make mistakes...     good thing about this is that it let me know that this mod is actually being used

Everyone makes mistakes. Anyone who never made mistakes either never made anything, never learnt anything or never tried anything new.

Making mistakes is good. Helps you learn, keeps you fresh. You should see how many mistakes I made when developing.

[DrBermant]

I guess I'm not allowed to make mistakes...     good thing about this is that it let me know that this mod is actually being used


And no, I do not have a beta testers team or otherwise people to test this before it gets public.

Actually everyone makes mistakes. My issue is that as a Plastic Surgeon, I have a harder time fixing behind the scenes server issues like the crash that happened where a more experienced programmer could take the crash in stride and not have to involve others to rebuild the forum from a back up. When I do new things for my patients, I am able to compensate for new methodology since I have those back up skills to manage the issues. I needed to call for help from others to get the forum back up and working.

From my role as a surgeon trying to educate the public I must be careful on risks I take. I will need to reevaluate the advantage of the fix outside the norm vs the advantages of the look it gives. From the standpoint of a free mod and forum system, the weird needs of the few cannot outweigh the practical methods of upgrades.

Oh, and I have done beta testing for many years. One neat program I still have the disks for was the first version Microsoft Word before it was ever released to the public. But that was so many decades ago.

If there is a outside the box fix that several are using, perhaps a warning on an upgrade that it will cause issues could help. Otherwise, perhaps incorporating some of the issues into the general mod might be an option. Another option is the figure out how to get the separate facebook mod to work with a share it mod.

I have marveled over your work here in the forum, how you manage issues and help others. I certainly do not expect such a system to have beta testers but that is why I spent so much time documenting the crash and getting you to look at the issue (which you did in a fantastically quick fashion).

Again thank you for your help.

Michael Bermant, M.D.

[All Colours Sam]

I'm  not a programmer... nor a "real programmer" either.   

I have  a Degree in Sociology which has nothing to do with coding or programing.

I made mods out of fun, and release those hoping it could help other people never expecting something in return.

I never took a programmer class or otherwise any code-related course, all I know I learned it from administrating SMF forums, reading and trying to understand other people code or mods.

And yes, I have a hard time figuring out server issues as much as you do, except that I do not have anyone to call and I'm expected to fix the issue as soon as possible.

Contrary to the general believe, this new version wasn't suppose to add more bugs or cause problems to people's sites...   it was a rather silly mistake of mine for trying to cut off file edits in SMF 2.0, you know, so regular users can install and use the mod without the hassle that involves manual installations, template files edits or manual file edits in general.


Sad part is,  the mod author (or in this case maintainer ) is always remembered when things go wrong... never the other way around.

[Arantor]

Sad part is,  the mod author (or in this case maintainer ) is always remembered when things go wrong... never the other way around.

Truth, right there. And you're expected to keep adding new stuff or make it exactly how others want it, instead of just making what you wanted in the first place.

I'm amazed people write mods. I'm more amazed how people spend time looking after what others have done. And all with generally so little appreciation.

[DrBermant]

Sad part is,  the mod author (or in this case maintainer ) is always remembered when things go wrong... never the other way around.

I have marveled over your work here in the forum, how you manage issues and help others. I certainly do not expect such a system to have beta testers but that is why I spent so much time documenting the crash and getting you to look at the issue (which you did in a fantastically quick fashion).

Again thank you for your help.

As I have said before, you do a great job. Thank you for your work.

Michael Bermant, M.D.

[poetra]

Where is the mod?

I can see it on mod page,...

[HunterP]

Where is the mod?
I can see it on mod page,...

Please read the topic (or at least recent replies) before you post :

after further testing I discover another few bugs,  thats why I'm going to remove the package until I have it tested properly and the mod is stable enough for public use.

[Richard Wing]

I need to inform you that the download link is missing for this mod. It says that it was last updated yesterday. Please advise?

Thanks

[All Colours Sam]

But no, after further testing I discover another few bugs,  thats why I'm going to remove the package until I have it tested properly and the mod is stable enough for public use.

[DrBermant]

But no, after further testing I discover another few bugs,  thats why I'm going to remove the package until I have it tested properly and the mod is stable enough for public use.

This is another example of why I appreciate the work that you offer to users of your mod.

it was a rather silly mistake of mine for trying to cut off file edits in SMF 2.0, you know, so regular users can install and use the mod without the hassle that involves manual installations, template files edits or manual file edits in general.

I wish I understood what you were talking about.

But I think it makes great sense to make the mod so that there are no needs for manual edits. Were there other issues other than the conflict with the Anti-Spam Links mod I discovered and you so nicely helped me out with the file edits mentioned above? If that is the case, thank you for trying to fix the mod so those of us using that mod can just upgrade the mod without having to make a mess of our sites. If there were other other fixes that did not address that specific conflict, that is still a good goal.

again, thank you for your efforts.

Michael Bermant, M.D.

[All Colours Sam]

anyway... 2.8.2 is now available.


@DrBermant   you do not need to upgrade, specially if you have custom code in your files,  this version only patches 2 bugs, one that is very specific,   here's the changes so you can add those manually and not have to worry about the upgrade:

to fix the "check all" for the icons, on your ShareThis.php  find:

Code Select Expand


// Ugly, ugly way to show a "check all" checkbox... I know!
'<input name="checkall" type="checkbox" id="checkall" value="checkall" onclick="checkAll();"/> ',$txt['share_like_select_all'],'<script language="JavaScript">
function checkAll() {
var nodoCheck = document.getElementsByTagName("input");
var varCheck = document.getElementById("checkall").checked;
for (i=0; i<nodoCheck.length; i++){
if (nodoCheck[i].type == "checkbox" && nodoCheck[i].name != "checkall" && nodoCheck[i].name != "share_all_messages" && nodoCheck[i].name != "share_diggbutton_enable" && nodoCheck[i].name != "share_twibutton_enable"  && nodoCheck[i].name != "share_articles" && nodoCheck[i].name != "share_boardnews_block" && nodoCheck[i].name != "share_buzzbutton_enable" && nodoCheck[i].name != "share_likebutton_enable" && nodoCheck[i].name != "share_icons_enable" && nodoCheck[i].name != "share_buttons_enable" && nodoCheck[i].disabled == false) {
nodoCheck[i].checked = varCheck;}}}</script>',



and replace with:

Code Select Expand


// Ugly, ugly way to show a "check all" checkbox... I know!
'<input name="checkall" type="checkbox" id="checkall" value="checkall" onclick="checkAll();"/> ',$txt['share_like_select_all'],'<script language="JavaScript">
function checkAll() {
var nodoCheck = document.getElementsByTagName("input");
var varCheck = document.getElementById("checkall").checked;
for (i=0; i<nodoCheck.length; i++){
if (nodoCheck[i].type == "checkbox" && nodoCheck[i].name != "checkall" && nodoCheck[i].name != "share_buttons_enable" && nodoCheck[i].name != "share_articles" && nodoCheck[i].name != "share_boardnews_block" && nodoCheck[i].name != "share_all_messages" && nodoCheck[i].name != "share_diggbutton_enable" && nodoCheck[i].name != "share_twibutton_enable"  && nodoCheck[i].name != "share_buzzbutton_enable" && nodoCheck[i].name != "share_likebutton_enable" && nodoCheck[i].name != "share_icons_enable" && nodoCheck[i].disabled == false) {
nodoCheck[i].checked = varCheck;
}
}
}</script>',



for the other one,  (this only applies if you have the "Show most recent posts at the top." theme option on)

in your Sources/Display.php file  find:

Code Select Expand


if (empty($modSettings['share_all_messages']) && $counter == 0 && $options['view_newest_first'] == 0 &&  !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body'].$mirahalo);


replace with:

Code Select Expand


if (empty($modSettings['share_all_messages']) && $counter == 0 && $options['view_newest_first'] == 0 &&  !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body'].$mirahalo);

// special case for when the "recent first" option is enable
if (empty($modSettings['share_all_messages']) && $counter == 1 && $options['view_newest_first'] == 1 && !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body'].$mirahalo);


[DrBermant]

Thank you so much. I do not use the check all option, but I applied the manual first fix anyway. Site works fine. Should I test anything for you to see if it is working?


I did not apply second patch since I also do not put most recent post first and do not conceive of needing to to that.

As I was looking over the mod controls I wondered why I had disabled the Ask button. I now remember that it is not currently working. I get an error message that Server not found: Firefox can't find the server at mystuff.ask.com.

I unchecked that box. In looking at the current share this options for supported services, Ask is no longer listed. They currently have:

    aim
    bebo
    blinklist
    blogger
    businessweek
    care2
    current
    dealsplus
    delicious
    digg
    dilgo
    facebook
    fark
    faves
    fresqui
    friendfeed
    funp
    gbuzz
    google_bmarks
    kirsty
    linkedin
    meaneame
    messenger (Microsoft)
    mister_wong
    mixx
    myspace
    n4g
    newsvine
    oknotizie
    propeller
    reddit
    simpy
    slashdot
    sonico
    sphinn
    stumbleupon
    technorati
    twackle
    twine
    twitter
    windows_live
    xanga
    yahoo_bmarks
    ybuzz
    yigg

http://help.sharethis.com/customization/chicklets

Now I am NOT asking for any of these, just passing on my research and reporting a button not working that I can just as easily leave turned off. You can see my current selection on a post on the forum:

http://www.abodybeautiful.com/forum/index.php/topic,263.0.html

Sorry, I am not smart enough to know if the selection I have picked is good or otherwise. I use the twitter and facebook most often. It is neat watching what happens when tweeting a post with my twitter following of over 100K. With the search engine bot showing for adm, it is interesting to watch the bots from google etc take off after the post instantaneously.

Again, thank you for taking the time to maintain the mod and help me with the conflict fix.

Michael Bermant, M.D.

[mpglivecarlo]

Hi,

thx for the mod just installed it no custom mod or anything.

When i use the like FB button, the post updates and adds my profile picture to the post, but in my FB wall there is no update, is this normal behavior of the mod?

using SMF 2 RC5 and mod version 2.8.1

thx.

[All Colours Sam]

When you  "like"  a post,   and you do not leave a comment, then your post will not be showed in your wall,   you need to leave a comment in order to see the post in your wall.

[mpglivecarlo]

When you  "like"  a post,   and you do not leave a comment, then your post will not be showed in your wall,   you need to leave a comment in order to see the post in your wall.

Hi thx for the answer, i am leaving a comment and still does not show :S

[All Colours Sam]

does your topics are available to guest?  can you post a link to your forum?

[mpglivecarlo]

does your topics are available to guest?  can you post a link to your forum?

Must have been something in the installation because i reinstalled it and now it works thx.