Share This Topic

Started by All Colours Sam, September 06, 2009, 05:09:23 AM

Previous topic - Next topic

luuuciano

Suki, as that is your current nickname...
How much do you think I can share/pay/give you for this?
In fact, I liked a few properties of the previous versions (anyway, im not missing that a lot)... but I think that anyway you deserve it, as you already did a huge work and I know how you care what you do...
I want to to give you some bucks...
so... Im asking you about that, to have an idea.... (about the amount)
No me agradan los foros que no te dejan borrar TU PROPIO usuario, como por ejemplo smfsimple.com.
E incluso te mandan emails no solicitados, de los cuales, quizá, no puedas escapar porque NO te dejan posibilidad a deshabilitarlos (a menos que NO te tengan en su lista negra).

All Colours Sam

#1441
OK, a new version, just added the check to disable the jQuery effect and some proper code documentation, maybe later this day I will add the new strings to the Spanish files and upload the new version in the mode site (4.1).

I'm pretty sure this mod will not work properly on a php4 server, perhaps I should add a warning for that too.


@luuuciano  Thank you, there is a donate page in my site: http://missallsunday.com/donate/   whatever amount is just fine and would be highly appreciated :D


Edit, attachment removed, please use the one in the mod site instead.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

busterone

I just tried it out on my test site. It works fantastic and exactly how I had envisioned it. I am implementing it live in just a few minutes.
Great work and many thanks.  :)

krash661

#1443
Awesome,

I have a question, just so i understand,
Is the home page the board index? cause now its not showing on the home page at all.

All Colours Sam

Yes, currently the AddThis script does not show on the board Index, that is because I haven't found a clean way to show it without interfering with the other conditionals I use to show the script only in certain areas.

There is some bugs, for exmaple the script will appear in the posting action and other areas where the buttons just doesn't need to appear, I have to take a deep look at how to implement the Script.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

krash661

Quote from: Suki on January 21, 2012, 03:36:34 PM
Yes, currently the AddThis script does not show on the board Index, that is because I haven't found a clean way to show it without interfering with the other conditionals I use to show the script only in certain areas.

There is some bugs, for exmaple the script will appear in the posting action and other areas where the buttons just doesn't need to appear, I have to take a deep look at how to implement the Script.

O.k, no problem. I just wanted to make sure.other than it not showing on the home page, It's working great for me. I adjusted the settings and it's showing exactly how i needed/wanted it..

THANKS SUKI SO MUCH, THIS IS VERY AND MASSIVELY APPRECIATED..  ;)

All Colours Sam

OK, heres the new version:

4.1
-Several bugs fixed
-Added the AddThis script for messages too.
-Added the forum name and the topic name in the twitter button
-Added a check to disable the jquery effect (Show the buttons all the time)
-Added an option to show the buttons above or below the messages.


I fixed a silly bug in the share url and now the addthis script does appear in the board index
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

Vlada87

#1447
Great upgrade to 2.0.2 tnx ;)

One question.... my tweet and FB buttons is on center, how to move them to the down right corner fo the post!?

All Colours Sam

do you mean the individual buttons are centered or you you mean the entire set of buttons are in the center?
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

Buneduggy

I have installed this mod but the admin menu is not correct. When I am redirected I can see the general settings and the button settings but when clicked on they don't show me anything?

I am running 2.0.2 with Military theme. I did try the default theme and get the same results? I have uninstalled the mod and re-installed with the same results. Any help would be appreciated.

All Colours Sam

any error on install?  any error in your error log?  do you use a different language?
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

Buneduggy

No errors on install. Use standard english.

I did find this error in the error log.

8: Undefined index: post_urlFile: /var/www/html/forum/Themes/default/languages/ManageSettings.english.php (show_settings sub template - eval?)
Line: 775


Website is www.norcalwheelers.com/forum

I am off to work. Will check this later tonight. Thanks,

All Colours Sam

do you see the admin panel?  do you see the admin settings?   what happen if you click on the save button?

does the Faq.english.php file exist in /Themes/default/language/  ?

what php version are you using?
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

kattara

Wow!  Awesome!  Thanks for the quick work and update, Suki!

I have another suggestion, tho...  Can you make it so that it is maybe 2 lines below the last line of the post?  And how come the ShareThis button is now on the board index by default?  I can't seem to take it off.  It didn't use to be there by default...  And yes, I think I did check the correct settings...

http://www.katzkorner.com/forum

All Colours Sam

Yeah, its a bug in the long "if" logic that  I'm using to show the AddThis script, will check that later.

The buttons are controlled by css, take a look at Sources/Sharethis.php  at the Headers method:

#sharethis
{
   '. (!empty($modSettings['share_disable_jquery']) ? 'display:visible' : 'display:none;') . '
   position:relative;
   top:5px;
   left:5px;
   z-index:100;
   min-height:30px;
}

if you want the buttons to be more separated from the message just change the  top:5px;   to some higher number:  top:20px;
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

kattara

#1455
Quote from: Suki on January 24, 2012, 03:37:12 PM
Yeah, its a bug in the long "if" logic that  I'm using to show the AddThis script, will check that later.

The buttons are controlled by css, take a look at Sources/Sharethis.php  at the Headers method:

#sharethis
{
   '. (!empty($modSettings['share_disable_jquery']) ? 'display:visible' : 'display:none;') . '
   position:relative;
   top:5px;
   left:5px;
   z-index:100;
   min-height:30px;
}

if you want the buttons to be more separated from the message just change the  top:5px;   to some higher number:  top:20px;

Ah, ok.  Where is this exactly?

Thanks!!  Once again, you are SO AWESOME!!!

Buneduggy

Quote from: Suki on January 23, 2012, 10:40:33 AM
do you see the admin panel? Yes but the two buttons only

do you see the admin settings? No, that is the issue I have no settings to change

what happen if you click on the save button?  It does nothing


does the Faq.english.php file exist in /Themes/default/language/  ?  No

what php version are you using?  This I am unsure of??

All Colours Sam

Then upload the Faq.english.php file to that location.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

Vlada87

Quote from: Suki on January 22, 2012, 04:09:49 PM
do you mean the individual buttons are centered or you you mean the entire set of buttons are in the center?

Never mind i had some issues whit application in Chrom who stop tracking FB connections, now i saw all buttons and they are correct set in left position of messages body.

My other question is, whats going on whit counting how many shares was done by clicking on buttons!? When i share whit Google +1, countig is OK, but when i share some post over the Twitter buttons, count shows 0 (zero) every time!?

Just to mention, i sucessfly share content via twitter, and post show on twitter regulary, just dont count shares on board on button.

All Colours Sam

I cannot do anything regarding that, it is a external issue, this mod just provides a way to show those buttons but cannot handle the counts and server response.

Twitter usually shows the count a day later, at least it does for me.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

Advertisement: