Share This Topic

Started by All Colours Sam, September 06, 2009, 05:09:23 AM

Previous topic - Next topic

Vlada87

Ahaaa.... ok then, great, tnx once again for this great plugin ;)

Cheers

All Colours Sam

OK new version, fixes a couple of bugs:

4.1.1
-Fixed bug on install/remove.php, silly bug, I know I shouldn't use $boarddir... copy/paste things from old code is evil!
-Fixed bug on logic for showing the AddThis script on BoardIndex.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

Daegaladh

AddThis still appears in user profiles even though is disabled...

Buneduggy

#1463
Quote from: Suki on January 25, 2012, 09:11:33 AM
Then upload the Faq.english.php file to that location.

I unpacked the .zip and did not see this file listed? Did I miss it or missread what you meant??

Here is a screen of what I see when it's installed.

kattara

Sorry, Suki.  I'm dumb at SMF.  Where is the file to change the spacing?

All Colours Sam

Quote from: Buneduggy on January 25, 2012, 10:45:15 PM
Quote from: Suki on January 25, 2012, 09:11:33 AM
Then upload the Faq.english.php file to that location.

I unpacked the .zip and did not see this file listed? Did I miss it or missread what you meant??

Here is a screen of what I see when it's installed.


My bad, it is the ShareThis.english.php file

What is your php version?  this mod wont work on a php4 or even php5.2

Quote from: kattara on January 25, 2012, 11:17:41 PM
Sorry, Suki.  I'm dumb at SMF.  Where is the file to change the spacing?

It's on Sources/ShareThis.php file
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

Daegaladh

Quote from: Daegaladh on January 25, 2012, 05:34:49 PM
AddThis still appears in user profiles even though is disabled...

What about that bug?

All Colours Sam

Quote from: Daegaladh on January 26, 2012, 09:18:12 AM
Quote from: Daegaladh on January 25, 2012, 05:34:49 PM
AddThis still appears in user profiles even though is disabled...

What about that bug?


I'm working on it?
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

Daegaladh

Ah, ok thanks, you didn't say a word about it, so I though you didn't read my post or something, sorry.

luuuciano

I have liked on a topic... then looking my facebook profile do not see that "liked page"... is that ok?
I thought that the page liked will be showed there...
No me agradan los foros que no te dejan borrar TU PROPIO usuario, como por ejemplo smfsimple.com.
E incluso te mandan emails no solicitados, de los cuales, quizá, no puedas escapar porque NO te dejan posibilidad a deshabilitarlos (a menos que NO te tengan en su lista negra).

kattara

Quote from: Suki on January 26, 2012, 09:03:48 AM

It's on Sources/ShareThis.php file

OK, got it!  But it didn't make any change?  I changed it first to 20, then 100.  But still see no difference...   :-\

All Colours Sam

Quote from: luuuciano on January 26, 2012, 05:07:59 PM
I have liked on a topic... then looking my facebook profile do not see that "liked page"... is that ok?
I thought that the page liked will be showed there...

It relies on facebook servers, I only provide a way to insert the service in your forum but I do not control the service itself.


@kattara attach your ShareThis.php file here and post a link to your forum or a link to an specific message with this mod on it.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

kattara


All Colours Sam

OK, try this one, if you need even more space then in the same file find:  padding-top: 30px;  and change 30 with a higher number
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

kattara

Quote from: Suki on January 26, 2012, 08:15:42 PM
OK, try this one, if you need even more space then in the same file find:  padding-top: 30px;  and change 30 with a higher number

There's padding, but not padding-top?  :-\

All Colours Sam

You haven't downloaded the file I modify.

download the file I attached in my last message.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

kattara

Quote from: Suki on January 26, 2012, 08:21:14 PM
You haven't downloaded the file I modify.

download the file I attached in my last message.

Ohhh!!  Sorry.  lol

kattara

That's PERFECT, Suki!  Thanks!!

Buneduggy

#1478
Quote from: Suki on January 26, 2012, 09:03:48 AM
Quote from: Buneduggy on January 25, 2012, 10:45:15 PM
Quote from: Suki on January 25, 2012, 09:11:33 AM
Then upload the Faq.english.php file to that location.

I unpacked the .zip and did not see this file listed? Did I miss it or missread what you meant??

Here is a screen of what I see when it's installed.


My bad, it is the ShareThis.english.php file

What is your php version?  this mod wont work on a php4 or even php5.2

Ok so the ShareThis.english.php file is there. But I did find that my PHP version may be PHP 5.1.6? I have mail to my webhost to see if this is correct. Sounds like this is not current enough version??

distante

Hello Suki!

I'm trying the last version of this mod, all works fine but I'm having a lot of undefined index error's in my log regarding this line (ShareThis.php 595)

Code (8: Undefined index: current_board) Select
if (!empty($modSettings['share_addthisbutton_enable']) && (!isset($_REQUEST['action']) && isset($_REQUEST['board']) && !in_array($context['current_board'], $share_options_boards) || !empty($context['current_topic'])) || (!empty($_REQUEST['action']) && in_array($_REQUEST['action'], $addthis_show)) || (!empty($modSettings['share_addthisbutton_enable']) && !isset($_REQUEST['topic']) && !isset($_REQUEST['board']) && !isset($_REQUEST['action'])))

I am tempted to add the @ in the var to mute the error but I guest will be better if first ask and report this to you :D

Advertisement: