Guest can not reply in own thread

[NetFlag]

Hallo @ all,
my guests have permission to post new topics (moderated). The problem. They can not reply in a topic created by themself or other guest.

Error message:
You are not allowed to post replies even to your own topics in this board.

[IchBin™]

Did you check the permission to allow them to reply to topics?

[NetFlag]

Yes, any topic is set. Replying where topicstarter is a member works well. Only topics started by guests return in error.

[IchBin™]

Do you have the option to deny permissions set to on? If so, do you have any groups set to deny this permission?

What version of SMF?

What mods do you have installed?

[NetFlag]

Do you have the option to deny permissions set to on? If so, do you have any groups set to deny this permission?

No I have not.

What version of SMF?

2.0.2

What mods do you have installed?

No Mods installed. Corefeatures enough already. 

The problem appears only when permissions set as shown below:
Post replies to topics, but hide until approved: checked
Post replies to topics, without requiring approval: unchecked

Maybe someone can reproduce the error ?

[emanuele]

In order to test it effectively let's see if I understood well:

• post moderation active.
• a board with the following permissions:
  
  
  • Post new topics, without requiring approval unchecked
  • Post new topics, but hide until approved checked
  • Post replies to topics, but hide until approved Any topic checked
  • Post replies to topics, without requiring approval Any topic unchecked

Anything else?

Expected behaviour: guests can reply to any topic.
Observed behaviour: guests can open new topics, but cannot reply.
Correct?

[IchBin™]

Looks like a bug to me. I noticed that if you select both options, the post is approved and posted anyway.

[emanuele]

Looks like a bug to me.

I imagined what was wrong looking at the post moderation page.
I think it's a pretty funny behaviour due to the assumption that SMF doesn't know how to recognize "own" topics from guests and so the "own" permissions should be ignored.
But it's not.

"Workaround": go in post moderation and set for "reply own" the "with moderation" option.
Funny thing is that every time you change the permissions from the permission page for guests this will be reset to "cannot create" (of course because from the permission page is in force the rule "SMF cannot recognize 'own' topics for guests".

I noticed that if you select both options, the post is approved and posted anyway.

Well...that's a misconfiguration...

[IchBin™]

haha true, but those two options completely conflict with each other IMO.

You have the permission to allow them to post to any topic without moderation. Or you have the permission to require them to be moderated. If both are selected, I would hope that moderation is given priority.

[emanuele]

You are right, I think I raised a similar point somewhere else (no idea where... lol)

[NetFlag]

.....
"Workaround": go in post moderation and set for "reply own" the "with moderation" option.
.....

Thanks alot. Not easy  to hit on it. Now its clear! Problem solved!

[Norv]

Good to hear you got it solved, NetHunter, and thanks for bringing this case to our attention!

haha true, but those two options completely conflict with each other IMO.

You have the permission to allow them to post to any topic without moderation. Or you have the permission to require them to be moderated. If both are selected, I would hope that moderation is given priority.

Apart from the interesting situation here.
On this particular point, I'm not sure I'd expect moderation, since other behaviors are: when a user has a permission from a group, and doesn't have that permission from elsewhere, the result it that they have the permission. You have the right from somewhere => you have the right. (i.e. the right to post without moderation).
The exception is deny permissions, only: only by using 'deny' of a permission one had, the result is they don't have it. (or almost only, I can think of another tricky case).

I'm not sure I can think at other examples contradicting this behavior: if you have the right from somewhere, then you have it, unless explicitly denied.

That said... I think these two would be better off mutually exclusive at the level of the user interface.

[emanuele]

I'm not sure I can think at other examples contradicting this behavior: if you have the right from somewhere, then you have it, unless explicitly denied.

Yep, I think that in the general SMF context the behaviour is the expected.

That said... I think these two would be better off mutually exclusive at the level of the user interface.

Yep, that would be nice I think.
Additionally we should not assume guests cannot reply to "own" topics.

Marking this as valid.

[ziycon]

Moved to github.
https://github.com/SimpleMachines/SMF2.1/issues/1179