SRAVC - Separate Replies And Views Column (Fully Hook!)

[Kat9119]

Does anyone want to help me try to install this on 2.0.2 Core theme? Attached is my file, most of the edits needed fails. I attempted to do it manually, but had no luck as most of the "find and replace" edits don't exist. Thank you

[Joker™]

The replies and view columns are already shown as separated columns in core theme on message index (inside of board).

[Hj Ahmad Rasyid Hj Ismail]

Hiya all.

I am entrusted with this mod now but I haven't have time to look into it deeply yet. I also believe that my brother Joker is a better coder than I am. I will try to do my best in handling this mod.

Thank you for supporting this mod and do feel free to ask for support.

[Hj Ahmad Rasyid Hj Ismail]

As reported by dougiefresh in this post, I will remove the code applied by this mod that are similar to VBBIS - VBulletin Board Index Style mod.

I will upgrade this mod soonest possible as it is in my next thing to do list.

[Hj Ahmad Rasyid Hj Ismail]

Upgraded and updated.

#Change Logs

@Version 1.9.3
- Upgraded to a fully hook mod with no file modification.
- Remove VBulletin Board Index Style modifications that was mixed up from this mod as it should be installed using a separate mod known as VBBIS - VBulletin Board Index Style mod.
- Remove support to YAGAM mod.

[Steve]

I like the mod except for one thing. Both the totals for replies and views are centered but the titles 'Replies' and 'Views' are left justified.

How would I make those centered as well?

[Hj Ahmad Rasyid Hj Ismail]

I believe it is currently centered in the latest version 1.9.3 (see the attached image)). You can add class centertext, if it doesn't.

[Steve]

This is what I see. (I also checked it with the default theme.)


Edit: just saw your attachment. Now I'm confused.

[Hj Ahmad Rasyid Hj Ismail]

That is a custom theme. In that case you need to open SRAVC.subs.php and make changes as follows:
Find two occurrences of this code:

Code Select Expand

<th scope="col" width="7%">
Change both of them to:

Code Select Expand

<th scope="col" class="centertext" width="7%">

I will update this into the current version 1.9.3.

Edited: Done inserting the above code into current version 1.9.3.

[Steve]

The updated code fixed the reply title but not the view title.

[Hj Ahmad Rasyid Hj Ismail]

Sorry. My mistake. It was supposed to be four changes made but I only made two. Try the latest package which I already uploaded. That should cover all four.

[Steve]

Perfect! Many thanks!

[Steve]

Any idea why I'm getting this error every time I go into the topic index?

8: Undefined variable: options
Apply Filter: Only show the errors from this file
File: /home/steve/public_html/forums/Sources/SRAVC.subs.php
Line: 50

[Hj Ahmad Rasyid Hj Ismail]

That is because $options is not globalized. Thank you for your feedback Steve. Fixed this in the new version.

@Version 1.9.4
- Fix $options not globalize in subs file.

[Steve]

You are welcome and no more errors. Thanks!

[Steve]

Hey my friend, got something else for you. The background for pinned threads is different between 'Replies' and 'Views'.

In the attachment, the 3 at the top are pinned.

It's minor and not worth fixing if it's a hassle. 

[Hj Ahmad Rasyid Hj Ismail]

That can be fixed but without it being fully hook. If you wish to do it, you can simply change a line in MessageIndex.template.php from:

Code Select Expand

<br />
to:

Code Select Expand

</td>
<td class="stats ' . $color_class . '"

Note: I think $context['topics'] which defines $topic that defines $color_class need to be re-defined in this mod though $context is already globalized. Otherwise, the right $color_class will not properly be called which results the current situation i.e. only windowbg is called.

[Steve]

Um ... there is no such line in that file.

Code Select Expand

<br />

Like I said, it's absolutely not a big deal.

[Hj Ahmad Rasyid Hj Ismail]

There is, if you are looking in the default theme template file. That line was changed via buffering in SRAVC.subs.php.

But, yeah, it is not really a big deal.

Hopefully we can have easy template edit via hook in SMF 2.1 though I haven't seen that possibility yet.

[Steve]

Sorry I didn't get back to you on this. You are, of course, right ... there is break in the default MessageIndex.template.php file. There are 12 of them in fact.

Any chance you could point me to the one where I should make the change you suggested? From there I could figure out the other themes but I have no clue where to start.