mark topic solved

[peter_mein]

Hello
Is it possible this Button as modification for all user ?

[Dzonny]

https://custom.simplemachines.org/index.php?mod=4339

[peter_mein]

That is not the same.
This mod don´t set a green stick.
And i can´t see which topic is solved.

[Dzonny]

You haven't specified what exactly the mod should do. Can you try this one maybe:
https://github.com/SimpleDesk/Team-Mods-TopicSolved

That one should work like the one we have installed here though.

[Diego Andrés]

That is not the same.
This mod don´t set a green stick.
And i can´t see which topic is solved.

The mod does this, what do you mean exactly?
I added screenshots to the mod page so you can see it.

[Speed King]

That is not the same.
This mod don´t set a green stick.
And i can´t see which topic is solved.

The mod does this, what do you mean exactly?
I added screenshots to the mod page so you can see it.

Yes, but maybe there is a conflict with another mod - Avatars Display Integration.
On my test forum, Topic Solved works fine, but testing on my working forum with ADI installed results what @peter_mein says.

[Diego Andrés]

Oh yea it's an issue with the Avatar Display mod, already reported it but the author didn't fix it.
@Pipke is replacing the class instead of concatenating.
$context['topics'][$topic['id_topic']]['css_class']

[peter_mein]

Hello
Yes that is the problem with mod ADI.
I write this to the forum: https://www.simplemachines.org/community/index.php?topic=571891.160
Maybe he'll get in touch

[Pipke]

Oh yea it's an issue with the Avatar Display mod, already reported it but the author didn't fix it.
@Pipke is replacing the class instead of concatenating.
$context['topics'][$topic['id_topic']]['css_class']

So what's wrong with my code? That's how I built the mod and it works...so what's wrong with that
i just 'hook' in the array so the avatar can be placed in that spot, if your mod does the same i can't help it.

[peter_mein]

Then the mod Basic Topic Solved go to another place.
Perhabs the green hook at the place from message icon.
And the other mod from here https://github.com/SimpleDesk/Team-Mods-TopicSolved
need also another place.
I hope a solution will be found.

Peter

[Diego Andrés]

So what's wrong with my code? That's how I built the mod and it works...so what's wrong with that

Well there are some small issues actually, for starters the HTML issues, one per topic

You cannot view this attachment.


PS: I'll mark this as solved as the original question got an answer.

[gevv]

Hi,

@Pipke  Is there a solution to this problem?



I come from here  

+
Disabling first poster from settings didn't work. Topic solved icon does not appear

[Pipke]

Hi,

@Pipke  Is there a solution to this problem?



I come from here  

+
Disabling first poster from settings didn't work. Topic solved icon does not appear

yeah got a quick fix for that

in file at ..Sources/AvatarsDisplayIntegration.php around line 842
Note for other users; only do this edit if you have both mods installed.

Code (find) Select Expand

                    // Hook it into context   
                    $context['topics'][$topic['id_topic']]['css_class'] = 'adi_print '.$topic['css_class'].'">'.$first.$last.'<span></span class="';


Code ("replace by") Select Expand

                    // Hook it into context   
                    $context['topics'][$topic['id_topic']]['css_class'] .= ' adi_print '.($topic['is_solved'] ? 'solved' : '').'">'.$first.$last.'<span></span class="';


[peter_mein]

Hello
With this mod https://custom.simplemachines.org/index.php?mod=4339 it works now.
But with this mod https://custom.simplemachines.org/index.php?mod=4339 it does not work yet.
See attachment. Is there also a solution for this?

[Steve]

@peter_mein - both your links are to the same mod ... besides:

Please keep modification problem discussions in the relevant mod's support topic.

[peter_mein]

Oh sorry. Here is the correct link: https://github.com/SimpleDesk/Team-Mods-TopicSolved

[peter_mein]

I made another mistake.
The correct error message can be found in the appendix.

[Kindred]

Please ask mod specific questions in the support thread for the mod

[peter_mein]

I don´t find a support thread for this mod.
Should I just create a new topic in Modifications and Packages ?

[Pipke]

@peter_mein replace the line with this:

Code Select Expand

// Hook it into context   
                    $context['topics'][$topic['id_topic']]['css_class'] .= ' adi_print '.(isset($topic['is_solved']) && $topic['is_solved'] ? 'solved' : '').'">'.$first.$last.'<span></span class="';