Tables are not centered in 2.1.4

[Antechinus]

Eh, bollocks.

Code (Sauces/Subs.php - Find this stuff) Select Expand

array(
'tag' => 'center',
'before' => '<div class="centertext">',
'after' => '</div>',
'block_level' => true,
),


Code (Sauces/Subs.php - Replace that stuff with this stuff (you know you want to)) Select Expand

array(
'tag' => 'center',
'before' => '<div class="centertext"><div>',
'after' => '</div></div>',
'block_level' => true,
),


Code (Thames/default/css/index.css - Now find this stuff) Select Expand

.centertext, .centercol {
margin: 0 auto;
text-align: center;
}


Code (Thames/default/css/index.css - Bet you can't guess what to do with this stuff) Select Expand

.centertext, .centercol {
margin: 0 auto;
text-align: center;
}
.centertext > div {
display: inline-block;
}

Iz all fixed now. Go have beer.

[live627]

Beer? Losers. Have tea like a Real Man! lmao

[live627]

Bet you can't guess what to do with this stuff

Instructions unclear: Put Sauses into the River Thames but tables keep getting misaligned by cats.

[live627]

It works on my end by just adding a margin to the table

https://github.com/SimpleMachines/SMF/pull/7797

(I'm annoying the powers that be who loath serial posting muhahaha)

[Antechinus]

Yes, if you put an auto left and right margin on a block level element it will centre itself. However, you are still left with a "center" tag that will only centre inline elements, and still won't centre block level elements. I gave you code for a "center" tag that would centre everything. It's more versatile, and it's bulletproof, and the code changes are really simple, and it will stop people asking why your "center" tag doesn't centre whatever they feel like centering that day.

But hey, do wotcha like. No skin off my nose, sunshine.

[Sir Osis of Liver]

If it wasn't broke in 2.0, why was it fixed in 2.1?

[live627]

coz it brokeded

[Antechinus]

If it wasn't broke in 2.0, why was it fixed in 2.1?

I do believe I already explained that, but feel free to not bother reading. It makes the effort of explaining feel so worthwhile.

[Sir Osis of Liver]

You're beginning to sound like Arantor.   My attention span is rather brief, and memory is even worse, but I probably did read your explanation.  Water off a duck.

[live627]

@Antechinus I'm sorry for annoying you.

[Aleksi "Lex" Kilpinen]

You're beginning to sound like Arantor.   My attention span is rather brief, and memory is even worse, but I probably did read your explanation.  Water off a duck.

The explanation I believe is basically the eternal curse of HTML, it evolves and stuff that used to work just fine, end up being replaced with other stuff that work just as fine, until they are again replaced with something. And coders and code need to keep up, which means having to fix things that aren't broken yet.

[Antechinus]

That will probably do as a simple explanation for those who are determined to not get it.