What do you think of the theme?

[Diego Andrés]

they get stuck on very small things there's no problem, I'm sure of it   

You also keep spamming us even after you were told not to do so.
That will only make us take longer.

[Tekyürek replikacep.com]

As one of the customization team members who IS reviewing your theme. I will tell you right here and now that your theme still has issues.   Some of which we have already informed you about.

Myself and the other customization team members are working on sending you a list for what needs fixed.  We do have busy lives outside of SMF.  We understand the work that you have put in.

So have some patience, thank you.

We did everything you said, you said my mood, I did that too, what is missing?

Edit : It is not missing, I recommend you to download and review the theme.


Edit: If you say rain in the profile field, it will stop, users who want to set up an admin panel can use it.


 

[Tekyürek replikacep.com]

they get stuck on very small things there's no problem, I'm sure of it   

You also keep spamming us even after you were told not to do so.
That will only make us take longer.

Edit : you are right sir, I'm sorry
 


Our teacher, who researched my theme, revealed himself



 

[TwitchisMental]

As one of the customization team members who IS reviewing your theme. I will tell you right here and now that your theme still has issues.   Some of which we have already informed you about.

Myself and the other customization team members are working on sending you a list for what needs fixed.  We do have busy lives outside of SMF.  We understand the work that you have put in.

So have some patience, thank you.

We did everything you said, you said my mood, I did that too, what is missing?

Edit : It is not missing, I recommend you to download and review the theme.

Edit : If you say rain in the profile area, it will stop, I removed it for users who want to set up the admin panel.



  

Wait for the PM with the list of what's wrong .

[Tekyürek replikacep.com]

As one of the customization team members who IS reviewing your theme. I will tell you right here and now that your theme still has issues.   Some of which we have already informed you about.

Myself and the other customization team members are working on sending you a list for what needs fixed.  We do have busy lives outside of SMF.  We understand the work that you have put in.

So have some patience, thank you.

We did everything you said, you said my mood, I did that too, what is missing?

Edit : It is not missing, I recommend you to download and review the theme.

Edit : If you say rain in the profile area, it will stop, I removed it for users who want to set up the admin panel.



  

Wait for the PM with the list of what's wrong .

I did everything I had to do
i'm not texting, he's mad at me.

i hope there will be no new shortcomings 

[Tekyürek replikacep.com]

Code Select Expand

function template_main()
{
global $context, $txt, $scripturl, $settings, $memberContext;

echo '
<div id="boardindex_table" class="boardindex_table">';
      if (!empty($settings['slayt_onoff']))
    {
     echo '<div id="replika" class="carousel slide" data-ride="carousel">
       <ul class="carousel-indicators">
       <li data-target="#replika" data-slide-to="1" class="active"></li>
       <li data-target="#replika" data-slide-to="2"></li>
       <li data-target="#replika" data-slide-to="3"></li>
       <li data-target="#replika" data-slide-to="4"></li>
       <li data-target="#replika" data-slide-to="5"></li>
    </ul><div class="carousel-inner"><div class="carousel-item active">
    <img src="'. $settings['slayt_adres']. '" alt="slideshow image 1" style=" width:100%; max-width: 100%;vertical-align: text-top;border-style: dotted;border-width: 2px;">
      <div class="carousel-caption d-none d-md-block">
      <h5>'. $settings['slayt_article_upper']. '</h5>
      <a style="text-decoration: none;" target="_blank" href="'. $settings['slayt_link']. '"><p style="color: #f2f2f2;font-size: 35px;padding: 13px 15px;text-align: center;border-style: dashed;border-width: 1px;background-color: rgba(87, 87, 87, 0.7);font-family: Times New Roman, Arial, Helvatica;">'. $settings['slayt_article_lower']. '</p></a>
       </div>
          </div>
    <div class="carousel-item">
    <img src="'. $settings['slayt_adres1']. '" alt="slideshow image 2" style=" width:100%; max-width: 100%;vertical-align: text-top;border-style: dotted;border-width: 2px;">
    <div class="carousel-caption d-none d-md-block">
    <h5>'. $settings['slayt_article_upper1']. ' </h5>
    <a style="text-decoration: none;" target="_blank" href="'. $settings['slayt_link1']. '"><p style="color: #f2f2f2;font-size: 35px;padding: 13px 15px;text-align: center;border-style: dashed;border-width: 1px;background-color: rgba(87, 87, 87, 0.7);font-family: Times New Roman, Arial, Helvatica;">'. $settings['slayt_article_lower1']. '</p></a>
    </div>
        </div>
    <div class="carousel-item">
    <img src="'. $settings['slayt_adres2']. '" alt="slideshow image 3" style=" width:100%; max-width: 100%;vertical-align: text-top;border-style: dotted;border-width: 2px;">
    <div class="carousel-caption d-none d-md-block">
    <h5>'. $settings['slayt_article_upper2']. ' </h5>
    <a style="text-decoration: none;" target="_blank" href="'. $settings['slayt_link2']. '"><p style="color: #f2f2f2;font-size: 35px;padding: 13px 15px;text-align: center;border-style: dashed;border-width: 1px;background-color: rgba(87, 87, 87, 0.7);font-family: Times New Roman, Arial, Helvatica;">'. $settings['slayt_article_lower2']. '</p></a>
   </div>
        </div>
   <div class="carousel-item">
    <img src="'. $settings['slayt_adres3']. '" alt="slideshow image 4" style=" width:100%; max-width: 100%;vertical-align: text-top;border-style: dotted;border-width: 2px;">
    <div class="carousel-caption d-none d-md-block">
    <h5>'. $settings['slayt_article_upper3']. ' </h5>
    <a style="text-decoration: none;" target="_blank" href="'. $settings['slayt_link3']. '"><p style="color: #f2f2f2;font-size: 35px;padding: 13px 15px;text-align: center;border-style: dashed;border-width: 1px;background-color: rgba(87, 87, 87, 0.7);font-family: Times New Roman, Arial, Helvatica;">'. $settings['slayt_article_lower3']. '</p></a>
   </div>
   </div>
    <div class="carousel-item">
    <img src="'. $settings['slayt_adres4']. '" alt="slideshow image 5" style=" width:100%; max-width: 100%;vertical-align: text-top;border-style: dotted;border-width: 2px;">
   <div class="carousel-caption d-none d-md-block">
   <h5>'. $settings['slayt_article_upper4']. ' </h5>
   <a style="text-decoration: none;" target="_blank" href="'. $settings['slayt_link4']. '"><p style="color: #f2f2f2;font-size: 35px;padding: 13px 15px;text-align: center;border-style: dashed;border-width: 1px;background-color: rgba(87, 87, 87, 0.7);font-family: Times New Roman, Arial, Helvatica;">'. $settings['slayt_article_lower4']. '</p></a>
   </div>
   </div>
   </div>
    <a class="carousel-control-prev" href="#replika" data-slide="prev">
    <span class="carousel-control-prev-icon"></span>
  </a>
    <a class="carousel-control-next" href="#replika" data-slide="next">
    <span class="carousel-control-next-icon"></span>
    </a>
       </div><br>'; 
   }
You are still getting HTML validation errors. These are related to the features where you have the user input an image. The way to resolve this would be a simple if/else. if user puts an image, show the image. If the user hasn't put an image, do not show anything or show some text even.

does anyone think there is a problem here ? 

i don't understand what they want me to do


kaynak : https://getbootstrap.com/docs/4.0/components/carousel/

[Kindred]

you get html validation errors if the user has not chosen an image.

You (currently) do not check to see if the image exists before using the html IMG tag...   which means the HTML fails to validate, because src="" is not valid html.

So, what you need to do is add a conditional that checks (for example) if $settings['slayt_adres'] has a value and only call the img tag if that condition is true...  or maybe display a placeholder if false.  The exact logic that you use is up to you... but the current code has no check and therefore fails validation when the user has no entry for that field.

[Tekyürek replikacep.com]

you get html validation errors if the user has not chosen an image.

You (currently) do not check to see if the image exists before using the html IMG tag...   which means the HTML fails to validate, because src="" is not valid html.

So, what you need to do is add a conditional that checks (for example) if $settings['slayt_adres'] has a value and only call the img tag if that condition is true...  or maybe display a placeholder if false.  The exact logic that you use is up to you... but the current code has no check and therefore fails validation when the user has no entry for that field.

please write me an Please   otherwise I won't be able to get out of this

[TwitchisMental]

@Kindred has explained it pretty well.

Take a look at the default theme. Specifically look at the site slogan and how it is setup.

That should give you all the information you need . Or atleast point you in the right direction.

[Tekyürek replikacep.com]

Code Select Expand

function template_main() {
    global $context, $txt, $scripturl, $settings, $memberContext;

    echo '<div id="boardindex_table" class="boardindex_table">';

    if (!empty($settings['slayt_onoff'])) {
        echo '
        <div id="replika" class="carousel slide" data-ride="carousel">
            <ul class="carousel-indicators">';

        // Carousel indicators
        for ($i = 1; $i <= 5; $i++) {
            echo '<li data-target="#replika" data-slide-to="' . $i . '" class="' . ($i === 1 ? 'active' : '') . '"></li>';
        }

        echo '
            </ul>
            <div class="carousel-inner">';

        // Carousel items
        for ($i = 0; $i < 5; $i++) {
            $adresKey = 'slayt_adres' . $i;
            $upperKey = 'slayt_article_upper' . $i;
            $lowerKey = 'slayt_article_lower' . $i;
            $linkKey = 'slayt_link' . $i;


            echo '
                <div class="carousel-item' . ($i === 0 ? ' active' : '') . '">
                    <img src="' . $settings[$adresKey] . '" alt="' . $settings[$lowerKey] . '" style="width: 100%; max-width: 100%; vertical-align: text-top; border-style: dotted; border-width: 2px;">
                    <div class="carousel-caption d-none d-md-block">
                        <h5>' . $settings[$upperKey] . '</h5>
                        <a style="text-decoration: none;" target="_blank" href="' . $settings[$linkKey] . '">
                            <p style="color: #f2f2f2; font-size: 35px; padding: 13px 15px; text-align: center; border-style: dashed; border-width: 1px; background-color: rgba(87, 87, 87, 0.7); font-family: Times New Roman, Arial, Helvatica;">' . $settings[$lowerKey] . '</p>
                        </a>
                    </div>
                </div>';
        }

        echo '
            </div>
            <a class="carousel-control-prev" href="#replika" data-slide="prev">
                <span class="carousel-control-prev-icon"></span>
            </a>
            <a class="carousel-control-next" href="#replika" data-slide="next">
                <span class="carousel-control-next-icon"></span>
            </a>
        </div><br>';
}

would it be a problem? even if this is the case



edit : i don't understand why no one is helping   , you don't really like to help, I guess.

[Kindred]

we are not "real time support" here.   We all have our own lives, our own real-life jobs, families, and other things to do -- if we "don't like to help", we would not be doing ANY of this in the first place...

However, to take a page from Arantor's comments:   Demands like you are making do make us wonder why we even bother to try helping in the first place.

you already use a conditional to check if the setting for a carousel is turned on...   you also need to check that images exist before attempting to display them -- especially in the case of user-uploaded content.

[Tekyürek replikacep.com]

finally over

Code Select Expand

function template_main() {
    global $context, $txt, $scripturl, $settings, $memberContext;

    echo '<div id="boardindex_table" class="boardindex_table">';

if (!empty($settings['st_carousel_index'])) {
        if (empty($_REQUEST['action']) && (empty($board)) && (empty($topic)))
            $carousel = 1;
        else
            $carousel = 0;
    }
    else
        $carousel = 1;
    if (!empty($settings['st_enable_carousel']) && $carousel == 1 && (!empty($settings['st_carousel_img1']) || !empty($settings['st_carousel_img2']) || !empty($settings['st_carousel_img3'])))
    {
        echo '
        <div id="Replika" class="carousel slide" data-ride="carousel" data-interval="', !empty($settings['st_carousel_speed']) ? $settings['st_carousel_speed'] : '3500', '">
            <ol class="carousel-indicators">';

            if (!empty($settings['st_carousel_img1']))
                echo '
                <li data-target="#carousel-example-generic" data-slide-to="0" class="active"></li>';
            if (!empty($settings['st_carousel_img2']))
                echo '
                <li data-target="#carousel-example-generic" data-slide-to="1"',(empty($settings['st_carousel_img1']) ? ' class="active"' : ''), '></li>';
            if (!empty($settings['st_carousel_img3']))
                echo '
                <li data-target="#carousel-example-generic" data-slide-to="2"',((empty($settings['st_carousel_img2']) && empty($settings['st_carousel_img1'])) ? ' class="active"' : ''), '></li>';
        echo '
            </ol>
            <div class="carousel-inner">';

         
                if (!empty($settings['st_carousel_img1']))
                {
                    echo '
                    <div class="carousel-item active" style="background-image: url(', $settings['st_carousel_img1'], ')">';

                    if (!empty($settings['st_carousel_title1']) || !empty($settings['st_carousel_text1']))
                    {
                        echo '
                        <div class="carousel-caption">
                            ', !empty($settings['st_carousel_title1']) ? ('<h3>'. (!empty($settings['st_carousel_link1']) ? '<a href="'.$settings['st_carousel_link1'].'" style=" color: white;font-size: 15px;">'.$settings['st_carousel_title1'].'</a>' : $settings['st_carousel_title1']). '</h3>') : '';

                        if(!empty($settings['st_carousel_text1']))
                            echo '
                            <p style="color: #f2f2f2; font-size: 35px;font-family: Times New Roman, Arial, Helvatica;">', $settings['st_carousel_text1'],'</p>';

                    echo '
                        </div>';
                    }
                    echo '
                    </div>';
                }

                if (!empty($settings['st_carousel_img2']))
                {
                    echo '
                    <div class="carousel-item',(empty($settings['st_carousel_img1']) ? ' active' : ''), '" style="background-image: url(', $settings['st_carousel_img2'], ')">';

                    if (!empty($settings['st_carousel_title2']) || !empty($settings['st_carousel_text2']))
                    {
                        echo '
                        <div class="carousel-caption">
                            ', !empty($settings['st_carousel_title2']) ? ('<h3>'. (!empty($settings['st_carousel_link2']) ? '<a href="'.$settings['st_carousel_link2'].'" style="color: white;font-size: 15px;">'.$settings['st_carousel_title2'].'</a>' : $settings['st_carousel_title2']). '</h3>') : '';

                        if(!empty($settings['st_carousel_text2']))
                            echo '
                      <p style="color: #f2f2f2; font-size: 35px;font-family: Times New Roman, Arial, Helvatica;">', $settings['st_carousel_text2'],'</p>';

                    echo '
                        </div>';
                    }
                    echo '
                    </div>';
                }

                if (!empty($settings['st_carousel_img3']))
                {
                    echo '
                    <div class="carousel-item',((empty($settings['st_carousel_img2']) && empty($settings['st_carousel_img1'])) ? ' active' : ''), '" style="background-image: url(', $settings['st_carousel_img3'], ')">';

                    if (!empty($settings['st_carousel_title3']) || !empty($settings['st_carousel_text3'])) {
                        echo '
                        <div class="carousel-caption">
                            ', !empty($settings['st_carousel_title3']) ? ('<h3>'. (!empty($settings['st_carousel_link3']) ? '<a href="'.$settings['st_carousel_link3'].'" style="color: white;font-size: 15px;">'.$settings['st_carousel_title3'].'</a>' : $settings['st_carousel_title3']). '</h3>') : '';

                        if(!empty($settings['st_carousel_text3']))
                            echo '
                            <p style="color: #f2f2f2; font-size: 35px;font-family: Times New Roman, Arial, Helvatica;">', $settings['st_carousel_text3'],'</p>';

                    echo '
                        </div>';
                    }
                    echo '
                    </div>';
                }

        echo '
            </div>
            <a class="carousel-control-prev" href="#Replika" data-slide="prev">
         <span class="carousel-control-prev-icon"></span>
      </a>
     <a class="carousel-control-next" href="#Replika" data-slide="next">
    <span class="carousel-control-next-icon"></span>
  </a>
        </div><br>';
    }
edit : This theme made me very tired.  Hope it's worth the effort, users enjoy.

[Tekyürek replikacep.com]

if the theme is not approved again, it is not because I have a defect, it is your effort to disapprove.

you made me work a lot, I usually offer a free theme that I should sell for a fee, but it's still not approved, or if the image is not entered, it gives an html error, whoever removed this rule, they can't use it without entering the excuse image, if it doesn't activate the mode, it doesn't give an error anyway, it's just nonsense.

it became clear why the themes on the official site are simple. 

sorry, but there has not been a theme with this many features on the official site yet , it's like you don't want it to happen anyway

what is the html error let me laugh, I sent this for the last time, if the theme is not approved without error, there is no html error anymore, saying it is proof that I am right in my suspicions let's see what happens

i think it is done on purpose because there is not even a single theme with intensive features on the website, by the way, orhan abide is on the web Dec webtiryaki.com if it weren't for that, your site wouldn't even have a theme in December
this was the end, I will not send it for approval again, it will be checked and approved for the last time, because there is nothing left to disapprove
I wish you all a good day, with the wish that your business and earnings will be abundant byyy


https://webtiryaki.com/threads/yaptigim-temeda-sorunlar-var-yardim-gerekiyor.1693/page-3  : take a look here and then don't say he defamed us
edit : if it goes like this, I will pass xenforo, or at least the labor is given there and the labor is not rejected paid themes are already sold, even though there are html errors

[Diego Andrés]

So you're not fixing the theme anymore?

I think, when you've had the same problem 5 years ago with different team members reviewing your customizations, it's clear what the issue is.

[Kindred]

Getvover yourself.

Themes available on our official site **MUST** meet a certain standard.

Your theme  STILL has errors and thus, does not meet the standard.

It's not that we don't want to approve it...  our team has spent ALOT of time reviewing your theme.  ALOT of time holding your hand and giving your suggestions on HOW to fix rather than just telling you "there's a problem".

You have received more direct attention and assistance than almost any other theme designer. We have figuratively "bent over backwards" attempting to help you get the theme up to our minimum standards -- and you have WHINED and COMPLAINED  every step of the way.

So, the problem here is YOU... not our theme approval process.

We don't care what OTHER softwares do. SMF has a high standard in our coding. It's one reason why we also have the best record when it comes to security.

So, yes. Your accusations are false. Your attitude is bad. Your ego is inappropriately big and is not supported by your work, which lacks quality.

[Tekyürek replikacep.com]

Getvover yourself.

Themes available on our official site **MUST** meet a certain standard.

Your theme  STILL has errors and thus, does not meet the standard.

It's not that we don't want to approve it...  our team has spent ALOT of time reviewing your theme.  ALOT of time holding your hand and giving your suggestions on HOW to fix rather than just telling you "there's a problem".

You have received more direct attention and assistance than almost any other theme designer. We have figuratively "bent over backwards" attempting to help you get the theme up to our minimum standards -- and you have WHINED and COMPLAINED  every step of the way.

So, the problem here is YOU... not our theme approval process.

We don't care what OTHER softwares do. SMF has a high standard in our coding. It's one reason why we also have the best record when it comes to security.

So, yes. Your accusations are false. Your attitude is bad. Your ego is inappropriately big and is not supported by your work, which lacks quality.

Your theme STILL has bugs

I did whatever I was told.

There are no errors in the theme

No error

[Tekyürek replikacep.com]

So you're not fixing the theme anymore?

I think, when you've had the same problem 5 years ago with different team members reviewing your customizations, it's clear what the issue is.

I did the last things requested and sent it for approval. I don't care whether they approve it or not. I did what was said.

The last requested mood pictures were missing so I added the pictures.

top 4 mode gives an error when the number of messages is 0, I fixed that too



It said that if images are not loaded for the slide show, it will give an HTML error, so I did that in a way that would not give an error.


I don't understand what else is wanted from me?


I sent the new theme package, if it approves, it will be approved.

[TwitchisMental]

if the theme is not approved again, it is not because I have a defect, it is your effort to disapprove.

you made me work a lot, I usually offer a free theme that I should sell for a fee, but it's still not approved, or if the image is not entered, it gives an html error, whoever removed this rule, they can't use it without entering the excuse image, if it doesn't activate the mode, it doesn't give an error anyway, it's just nonsense.

it became clear why the themes on the official site are simple. 

sorry, but there has not been a theme with this many features on the official site yet , it's like you don't want it to happen anyway

what is the html error let me laugh, I sent this for the last time, if the theme is not approved without error, there is no html error anymore, saying it is proof that I am right in my suspicions let's see what happens

i think it is done on purpose because there is not even a single theme with intensive features on the website, by the way, orhan abide is on the web Dec webtiryaki.com if it weren't for that, your site wouldn't even have a theme in December
this was the end, I will not send it for approval again, it will be checked and approved for the last time, because there is nothing left to disapprove
I wish you all a good day, with the wish that your business and earnings will be abundant byyy


https://webtiryaki.com/threads/yaptigim-temeda-sorunlar-var-yardim-gerekiyor.1693/page-3  : take a look here and then don't say he defamed us
edit : if it goes like this, I will pass xenforo, or at least the labor is given there and the labor is not rejected paid themes are already sold, even though there are html errors

if the theme is not approved again, it is not because I have a defect, it is your effort to disapprove.

Actually it is because you still fail to meet our standards. You still have invalid HTML and hardcoded text amongst other issues.

you made me work a lot, I usually offer a free theme that I should sell for a fee, but it's still not approved, or if the image is not entered, it gives an html error, whoever removed this rule, they can't use it without entering the excuse image, if it doesn't activate the mode, it doesn't give an error anyway, it's just nonsense.

We haven't made you do anything other than follow the same standards we enforce upon everyone. Also it is okay to just admit that you do not know what you doing and need help .

sorry, but there has not been a theme with this many features on the official site yet , it's like you don't want it to happen anyway
 

Beyond your little Mood Feature, this is false. There are several themes with quite a-lot of different useful features made by several different theme authors.

what is the html error let me laugh, I sent this for the last time, if the theme is not approved without error, there is no html error anymore, saying it is proof that I am right in my suspicions let's see what happens

False, you still have HTML errors.

i think it is done on purpose because there is not even a single theme with intensive features on the website,

Yes we are following standards on purpose.

Also just so you know there are several themes with various different features.  I don't know where you get this idea from. For example Diego's NameX theme and Mick.'s Envy theme are feature rich.

by the way, orhan abide is on the web Dec webtiryaki.com if it weren't for that, your site wouldn't even have a theme in December

So? We still have over 40 themes for 2.1.

this was the end, I will not send it for approval again, it will be checked and approved for the last time, because there is nothing left to disapprove

No it won't as it still doesn't not meet the standards.

https://webtiryaki.com/threads/yaptigim-temeda-sorunlar-var-yardim-gerekiyor.1693/page-3  : take a look here and then don't say he defamed us
edit : if it goes like this, I will pass xenforo, or at least the labor is given there and the labor is not rejected paid themes are already sold, even though there are html errors

Oh thank you for showing us that you really do not understand what you are doing.. Instead you are trying to get someone else to do the work for you. Even they are letting you know that you do infact issues.

On the note of Xenforo themes having HTML issues.. So what, that is Xenforo.. If they do not want to have standards so be it. And I say that as a fan of Xenforo.

I guess you could say SMF is better in the standards department then.


So with all of this said, I believe it is safe to say that you do not plan on meeting standards.  Which in that case, we will go ahead and decline your theme.

[Diego Andrés]

There are no errors in the theme

Code Select Expand

<img class="avatar" src="', $ava, '" alt="Person holding a cat">

[Tekyürek replikacep.com]

There are no errors in the theme

Code Select Expand

<img class="avatar" src="', $ava, '" alt="Person holding a cat">

What is the error? HTML does not give an error.?

Edit : There is no mistake on the day of error