Google Member Map

[NDFF]

Google Member Map 1.0 Beta 3 Released!
! Fixed some text that was not put as a text string...
To save you translators trouble... Update your language files by adding the following string:

Code Select Expand


$txt['googleMapPleaseClick'] = 'Click to place a point or click on your point to remove it.';

right before:

Code Select Expand


$txt['googleMapDisclaimer'] = 'Place your pin as close as you feel comfortable doing so.';

in Modifications.<your_language>.php

In the GoogleMap_1.0beta3.zip I just downloaded, there is still hardcoded text in Profile.template.php, no $txt['googleMapPleaseClick'] in modification.xml (but in modification20.xml)

Great mod anyhow.

[brianjw]

I will try to get an updated mod out with all the changes I need to make. Thanks for notifying me.

[fasterthanyours]

Brian,

I'm not trying to be an a$$ about this but, like I said above if you have the Paypal Donations mod installed the modification.xml doesn't work on Modsettings.php.  I just tested it again on my one of my sites and the only mod that fails in ModSettings.php, because I have the Paypal Donations Mod Installed.

ModSettings.php without Google Member Maps installed and Paypal Donations installed.

Code Select Expand

'karma' => array(
'title' => $txt['smf293'],
'href' => $scripturl . '?action=featuresettings;sa=karma;sesc=' . $context['session_id'],
),
'paypal' => array(
'title' => $txt['payPalFO'],
'href' => $scripturl . '?action=featuresettings;sa=paypal;sesc=' . $context['session_id'],
'is_last' => true,
),

As you can see above the following no longer exists in the ModSettings.php:
(Which is what your commands in the modification.xml are looking for)

Code Select Expand

'karma' => array(
'title' => $txt['smf293'],
'href' => $scripturl . '?action=featuresettings;sa=karma;sesc=' . $context['session_id'],
'is_last' => true,
),

So therefore making it impossible for the modification.xml to install the code before or after the Karma array entry.

Chaning the modification.xml to replace the 'is_last' => true, with the Google Array would be more effective, since 'is_last' => true, only exists once in ModSettings.php

[brianjw]

The problem about that is most mods don't put their link the very last. They put it before karma. So if I modify it for that, it will not work for the majority of the mods.

[fasterthanyours]

Yeah I realized that after muddling through the paypal install.

Isn't there a setting of instructions or SOPs somewhere that everyone should be following?

[fasterthanyours]

Wouldn't it be eaiser to take the 'is_last' => true, out of modifications?

[brianjw]

Just use my Package Parser to install the mod. (manually)

Link in sig -->

[fasterthanyours]

lol I'll stick with my modded modification.xml  I hate manual edits.

[genieuk]

Would like this mod but wanted to know is there a new version coming out soon and better to wait for a newer version or shall i install?

is there any major known problems i should be aware of etc, obviously it still in beta but still wanted to ask before i consider installing?

thank you,
Mathew

[fasterthanyours]

Nothing I specifically saw on my sites I installed it on.

[brianjw]

genieuk,

No major bugs.

There are a couple things I am going to release soon that will:

• Force profile to use Google Member Map Language Strings
  
• Fix Undefined Index ScriptUrl error in Modifications.english.php
  
  I am going to try to get one out within the next hour if I can.

[Sudhakar Arjunan]

Using beta for many days.

No errors so far. Thanks brianjw for an excellent and a very very different mod.

[genieuk]

genieuk,

No major bugs.

There are a couple things I am going to release soon that will:

• Force profile to use Google Member Map Language Strings
  
• Fix Undefined Index ScriptUrl error in Modifications.english.php
  
  I am going to try to get one out within the next hour if I can.
  

Perfect! look forward to it.

Mathew

[brianjw]

Ok, new version released.

It's encouraged to update if you want an error-free error log (at least from this mod).

• Undefined Index error in Modifications.english.php for $scripturl has been fixed.
  
• Changed hard coded text in the profile into a language string so you can now change the language of it.
  
• Feature added in the last version didn't work. It is now working and fixed.
  This feature allows you to type in
  ../index.php?action=profile;sa=forumProfile#googlemap
  which will automatically scroll down the page to that setting. The link on the member map has also been changed to that so it will go all the way down.
  
  All of you reported these errors. So thank you for your contributions to this mod, by simply letting me know.
  
  To upgrade: Uninstall the previous version and install this one. You will not lose any pins or settings you have set.
  
  Enjoy. Download is on the mod site.

[sgandtg]

Looking forward to having this on the site.

Before installing, can someone give advice as to whether I can install this automatically or whether I'll have to do something more difficult as one of the actions (13) fails on test install.

1. Extract File ./Sources/GoogleMap.php 
2. Extract File ./Themes/default/Clusterer2.js 
3. Extract File ./Themes/default/GoogleMap.template.php 
4. Extract File ./Themes/default/images/google_earth_feed.gif 
5. Extract File ./Themes/default/images/english/googlemap.gif 
6. Execute Code add_settings.php 
7. Execute Modification ./index.php Test successful
8. Execute Modification ./Sources/Load.php Test successful
9. Execute Modification ./Sources/ManagePermissions.php Test successful
10. Execute Modification ./Sources/ModSettings.php Test successful
11. Execute Modification ./Sources/Profile.php Test successful
12. Execute Modification ./Themes/default/index.template.php Test successful
13. Execute Modification ./Themes/default/Profile.template.php Test failed
14. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful
15. Execute Modification ./Themes/default/languages/Modifications.english-utf8.php Test successful
16. Execute Modification ./Themes/default/languages/ModSettings.english.php Test successful
17. Execute Modification ./Themes/default/languages/Who.english.php Test successful

Great mod, btw.

[Sudhakar Arjunan]

Thanks for the error free version brainjw.

I have tried to uninstall my old version say 1.0.3 beta from 2.0.4 beta smf.

I got all small fixes,

Code Select Expand


*  10.  Execute Modification  ./Sources/ManageSettings.php  Test failed
1. Replace ./Sources/ManageSettings.php Test successful
2. Replace ./Sources/ManageSettings.php Test failed
3. Replace ./Sources/ManageSettings.php Test failed
* 11. Execute Modification ./Sources/Profile-Modify.php Test failed
1. Replace ./Sources/Profile-Modify.php Test successful
2. Replace ./Sources/Profile-Modify.php Test failed
3. Replace ./Sources/Profile-Modify.php Test successful
* 12. Execute Modification ./Sources/Subs.php Test successful
1. Replace ./Sources/Subs.php Test successful
2. Replace ./Sources/Subs.php Test successful
* 13. Execute Modification ./Themes/default/Profile.template.php Test successful
1. Replace ./Themes/default/Profile.template.php Test successful
2. Replace ./Themes/default/Profile.template.php Test successful
* 14. Execute Modification ./Themes/default/languages/Modifications.english.php Test failed
1. Replace ./Themes/default/languages/Modifications.english.php Test failed
* 15. Execute Modification ./Themes/default/languages/ManageSettings.english.php Test failed
1. Replace ./Themes/default/languages/ManageSettings.english.php Test failed


So if you give me some upgrade edit, i will be doing it manually to complete the upgraded version.

[brianjw]

Manual Edits:

Modifications.english.php
Add the following above the Google Member Map language strings

Code Select Expand

global $scripturl;

FIND

Code Select Expand


$txt['googleMapAddPinNote'] = '<a href="' . $scripturl . '?action=profile;sa=forumProfile#googlemap">Click here to go place your pin if you have not already.</a>';

ADD AFTER (one line after):

Code Select Expand


$txt['googleMapPleaseClick'] = 'Click to place a point or click on your point to remove it.';


FIND

Code Select Expand


$txt['googleMapAddPinNote'] = '<a href="' . $scripturl . '?action=profile;sa=forumProfile">Click here to go place your pin if you have not already.</a>';

REPLACE WITH

Code Select Expand


$txt['googleMapAddPinNote'] = '<a href="' . $scripturl . '?action=profile;sa=forumProfile#googlemap">Click here to go place your pin if you have not already.</a>';


Profile.template.php

Code Select Expand


<div id="map" style="width: 600px; height: 350px; color: #000000;" align="center"></div>

REPLACE WITH

Code Select Expand


<a name="googlemap"><div id="map" style="width: 600px; height: 350px; color: #000000;" align="center"></div></a>


FIND

Code Select Expand

<div id="message" align="center">Click to place a point or click on your point to remove it.</div>
REPLACE

Code Select Expand


<div id="message" align="center">', $txt['googleMapPleaseClick'], '</div>


That's everything. All the manual edits for the beta 4

[Sudhakar Arjunan]

Thank you brianjw,

I will be doing it now , and will leave the status. Thanks in Advance.

[genieuk]

Hi,

I have custom actions installed, see they have conflicts so manual install required, do i just need to just install manually as on your first post you say to check "comments on this mod" page and it the same page. 

[Sudhakar Arjunan]

That's everything. All the manual edits for the beta 4

I have Tried BrianJW all the edits and found all the edits were already updated in my forum.

So is that mean am using a stable version or 1.0.4.