Advertisement:

Author Topic: Smileys disabled in conversion?  (Read 38801 times)

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Smileys disabled in conversion?
« on: September 25, 2008, 11:15:37 PM »
I did the conversion, but seems that the boards imported have the smileys disabled by default for some reason.

If I create a new board, the smileys work fine.

Am I missing something somewhere?

Thanks :)

Offline Adish - (F.L.A.M.E.R)

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 10,614
  • Gender: Male
  • I am a ninja!
    • adishpatel on Facebook
    • https://www.linkedin.com/in/adishpatel on LinkedIn
Re: Smileys disabled in conversion?
« Reply #1 on: September 26, 2008, 11:00:06 AM »
did you have the option that disable smileys in this post or something ticked ?

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #2 on: September 26, 2008, 12:03:52 PM »
Go into phpMyAdmin
Click on your database. Then click smf_messages. Click the Structure tab.

In that table there should be under field column a row with the name "smileysEnabled".
If you look over to the right under the Default column and that is in the same row as the above field. Is the default set to 1?
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #3 on: September 26, 2008, 05:47:18 PM »
If you look over to the right under the Default column and that is in the same row as the above field. Is the default set to 1?

Yes it is set to 1. Just set it to 0 and seems to have solved the issue.
« Last Edit: September 26, 2008, 05:54:19 PM by AzJose »

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #4 on: September 26, 2008, 10:07:54 PM »
Well I wasn't suggesting to change the default. Just wanted to know if it was some how different than a default install of SMF.
If you check through some of the messages, do the older ones have this set to 1 or 0?

You can run the following query which will enable smileys on all messages:
Code: [Select]
UPDATE smf_messages
SET smileysEnabled = 1;
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #5 on: September 26, 2008, 10:23:33 PM »
Gotcha, that was my fault sorry.

Did the query and that fixed it. But did just notice that all the view counts for all messages were set to 0.

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #6 on: September 28, 2008, 05:28:25 PM »
Well unless there is data in the mark read tables I don't think we can get this information back without converting again. Even that may not have total 100% data but may be better than nothing.

What version of yabb where you using btw? Just so I know which converter I am looking at.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #7 on: September 29, 2008, 06:56:20 PM »
What version of yabb where you using btw? Just so I know which converter I am looking at.
Currently v2.2.2 - I have no plans to upgrade it any further at this point.

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #8 on: September 30, 2008, 02:05:24 PM »
Ahh so you where using the yabb 2.2 beta converter :)

Ok, I will look at that and see what is going wrong then. As it should of worked.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #9 on: October 02, 2008, 12:27:26 PM »
Anymore luck on this at all? Thanks :)

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #10 on: October 02, 2008, 06:56:55 PM »
I think it was caused by a incorrect casting of a variable.

Do you need to convert again though? Unless we need to convert again I didn't want to make you break things to test the fix :P (I planned on testing it with a local yabb install I have of a big board and finding smiley posts to see if I fixed it.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #11 on: October 02, 2008, 07:02:52 PM »
I am fine with testing it.

I am keeping yabb active until it looks like I am good to go with SMF, then I start the joomla 1.5 integration to allow for single joomla and forum logins.  :o Hope it can be done.

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #12 on: October 03, 2008, 02:18:15 PM »
Try the attached file. I believe this fixed it.
If not I will need to see an example post of with and without smiles (just to compare them).

Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #13 on: October 03, 2008, 07:12:53 PM »
Will try this and let ya know in a bit. Thanks :)

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #14 on: October 04, 2008, 03:19:49 AM »
Well no luck on the counts and the smilies are still disabled by default as well.

Asides from that, the last version you posted here ran without a hitch.

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #15 on: October 05, 2008, 01:17:08 PM »
Do you have a sample post with and without smiles? The files themselves from yabb?
I have a feeling my logic was off but only seeing some other posts can I confirm that.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #16 on: October 05, 2008, 08:41:57 PM »
Do you have a sample post with and without smiles? The files themselves from yabb?
I have a feeling my logic was off but only seeing some other posts can I confirm that.
Mean like after the conversion? And also the source files for the conversion?

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #17 on: October 07, 2008, 12:17:40 PM »
For before the conversion. I am wanting to see the Yabb message files.
I wanted to compare the message files with my logic I was using to attempt to find out if we where using smilies or not.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #18 on: October 09, 2008, 01:34:58 PM »
How would you like the files?

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #19 on: October 09, 2008, 03:34:24 PM »
You can email them to me or pm me their contents. Which ever works.

I have some yabb posts but after looking at them myself I didn't see a difference in logic. So hopefully these will point out what Yabb is now doing to identify a smiley.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #20 on: October 14, 2008, 04:10:22 PM »
You can email them to me or pm me their contents. Which ever works.

I have some yabb posts but after looking at them myself I didn't see a difference in logic. So hopefully these will point out what Yabb is now doing to identify a smiley.
Tried sending an email got an error back and then pm'd you the stuff. Get any of it?

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #21 on: October 17, 2008, 05:58:44 PM »
I didn't see a difference in the logic of those posts.. I think I fixed it though, I just reversed the logic check.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #22 on: October 19, 2008, 01:33:04 AM »
That seems to have fixed the smiley issues now. Thanks :)

Now some of the message counts are showing there are all 0 (zero).

Check it out Here and you will see what I mean.

Thanks for all the help Sleepy! :)

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #23 on: October 19, 2008, 09:26:34 PM »
If you go to forum maintenance in the admin panel, does clicking and running find and repair errors help fix this?
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #24 on: October 19, 2008, 11:18:14 PM »
Tried that as well. No joy. Seems like reply counts are showing now it seems, but not the viewed counts. Weird.

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #25 on: October 22, 2008, 07:35:42 PM »
Tried that as well. No joy. Seems like reply counts are showing now it seems, but not the viewed counts. Weird.
Bump. Any thoughts on this?

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #26 on: October 23, 2008, 12:37:24 AM »
How many posts do you have on your forum? As well as topics?

I could make a script quickly to accomplish this. Knowing this will help me know if We can try and get away with running it without any timeout protection.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #27 on: October 23, 2008, 11:54:00 AM »
How many posts do you have on your forum? As well as topics?

I could make a script quickly to accomplish this. Knowing this will help me know if We can try and get away with running it without any timeout protection.
14290 Posts in 1742 Topics by 159 Members from the last recent conversion I did.

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #28 on: October 23, 2008, 01:06:13 PM »
This script should fix all the replies.
It does no timeouts. I think we can get away without having timeouts. If we can't I can rewrite it to do this differently.

Goes in your SMF folder where SSI.php and Settings.php is. Run it from either your browser or command line.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #29 on: October 23, 2008, 04:21:47 PM »
No luck with that. Loads to a blank screen and no counts change.

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #30 on: October 23, 2008, 11:05:27 PM »
Well I didn't give it any output. If it finishes loading then it should of finished.

What do you get if you run this in phpMyAdmin?

Code: [Select]
SELECT COUNT(ID_MSG) - 1 AS num_replies, ID_TOPIC
FROM smf_messages
GROUP BY ID_TOPIC

I ran this on a small test site and it worked fine for me to get the topic replies.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #31 on: October 24, 2008, 02:34:53 AM »
That shows all the topic replies.

But the view counts of the topics are not coming across.

So like 1 Topic for example on the yabb2 site has like 101 replies, and like 1117 views.. On the SMF site is has 101 replies and 19 views.

This seems to be the last issue I have before I can do a full swap to SMF :)

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #32 on: October 24, 2008, 09:47:20 AM »
I may be using the wrong index.

Does,
replacing:
Code: [Select]
$views = !empty($views[2]) && $views[2] > 1 ? $views[2] - 1 : 0;
with
Code: [Select]
$views = !empty($views[3]) && $views[3] > 1 ? $views[3] - 1 : 0;
Fix this in the converter file?

looks like the file that contains the views data also contains the replied data. So I could make the converter get it from this as well during the conversion.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #33 on: October 24, 2008, 11:01:10 AM »
No luck with that change. Still get all zeros in the views.

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #34 on: October 24, 2008, 11:40:29 AM »
and you ran the converter again?

Although looking at the file, I may have to alter how it works I think :| I think yabb changed the format of that file on us.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #35 on: October 24, 2008, 12:18:41 PM »
and you ran the converter again?

Although looking at the file, I may have to alter how it works I think :| I think yabb changed the format of that file on us.
Yep, ran the whole convert process again after changing that line of code you gave me.

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #36 on: October 28, 2008, 11:17:24 AM »
Anymore thoughts on this?

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #37 on: October 28, 2008, 05:24:47 PM »
Sorry, it has been very busy for me for a while now.

The following file I changed it so the .ctb file that exists in the messages folder is now used and it does a regex check to try and find the views entry.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #38 on: October 28, 2008, 07:42:51 PM »
No prob. I will try it and let ya know.

Thanks :)

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #39 on: October 29, 2008, 01:53:16 AM »
No luck with that.

Here is the content of a ctb file for ya.

Code: [Select]
### ThreadID: 1084076403, LastModified: Thu, 19 Jun 2008 12:50:12 -0700 ###

'board',"news"
'replies',"8"
'views',"93"
'lastposter',"Joe_Plumber"
'lastpostdate',"1086312452"
'threadstatus',""
'repliers',""

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #40 on: October 31, 2008, 06:39:21 PM »
I tested this one and it was able to pull the number out. it should work.
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub

Offline AzJose

  • Semi-Newbie
  • *
  • Posts: 40
  • Gender: Male
Re: Smileys disabled in conversion?
« Reply #41 on: November 01, 2008, 02:41:52 PM »
Sleepy you rock! That last version got it all done.

Thanks for all your help with this. If ya drink beer, consider your evening covered if ya ever come to Phoenix!  8)

Thanks Again!

Offline SleePy

  • Site Team Lead
  • SMF Master
  • *
  • Posts: 30,139
  • Gender: Male
  • Thats his happy face.
    • jdarwood007 on GitHub
    • @jdarwood on Twitter
    • SleePy Code - My personal site
Re: Smileys disabled in conversion?
« Reply #42 on: November 02, 2008, 08:54:55 PM »
Not a problem, thank you really. I know have those all debugged out and committed to svn. So for the next SMF release they will be fixed on our downloads page :)
Jeremy D — Site Team / SMF Developer
Support the SMF Support team!
Profiles:
GitHub