• Welcome to Simple Machines Community Forum. Please login or sign up.
December 07, 2021, 05:32:25 PM

News:

Follow SMF on Twitter.


Stop Spammer

Started by M-DVD, December 31, 2008, 07:31:43 AM

Previous topic - Next topic

giveaway365.com

the count bug still exists.. even if an good member registers the count is reduced...

giveaway365.com

can you have just execute this query after every check:
http://www.xyz.com/index.php?action=boardrecount

this will automatically recount and make counts normal?

giveaway365.com

this is the error when a spammer registers:
8: Undefined index: types
File: /home/content/g/i/v/xxx/html/Sources/ManageMembers.php
Line: 381

line 381 is :
if (empty($range_trans[$_POST['types'][$param_name]]))

snoopy_virtual

Quote from: kicky on February 08, 2010, 07:21:17 AM
Hi, I installed this mod in my SMF 1.1.11

But everyone can not register....
The error is

Fatal error: Cannot redeclare spammercheck() (previously declared in /home/innovaco/public_html/Sources/Register.php:603) in /home/innovaco/public_html/Sources/Register.php on line 681

When someone click register.

can someone help me?
thanks in advance

The function spammercheck() doesn't belong to this mod.

Are you sure you have copied the error statement properly?

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

EL34xyz

Snoop, I installed the 2.3.7  and something strange just happened.

After the install, I went to my members page and started checking all the members for possible spammers.

I had a bunch that had some spammer names that were flagged RED
The members were not spammers, they just had a name that was on the list.

I left the forum and then came back later.
All of the Red spammer names in my forum members list were now on the members waiting for approval page???

These were old members that have been members for a long time.
they were not new registrations waiting to join the forum.

I rejected the whole list of Red names.

Why are these members showing up on the "waiting for registration" Page????.

SMF 1.1.11
I am the admin and I must approve all new members.

snoopy_virtual

Quote from: mbreber on February 08, 2010, 11:29:21 AM
Hi, I installed this mod in my SMF 1.1.11 and I´m using Cratian language.

I have changed my Themes/default/languages/Modifications.croatian-utf8.php and translated but I see there´s a lo more of text:

....

Where should I put this text. In what language .php file?
Please help!!!

All the english text goes to Themes/default/languages/Modifications.english.php

As you can see in the changelog, from 2.3 to 2.3.7 I have added 7 new lines of text. (I have also change a little the old lines to correct a few mistakes).

When you install 2.3.7 all these new lines go automatically to that Modifications.english.php file. Check that they are there.

If they are not there you have made a mistake installing it.

Compare anyway your english and croatian files to see if you have these new 7 lines missing in your croatian file and (if so) translate them and send them to me if you don't mind, so I can add them too to the full language package.

Thanks

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

snoopy_virtual

Quote from: giveaway365.com on February 08, 2010, 12:00:32 PM
can you have just execute this query after every check:
http://www.xyz.com/index.php?action=boardrecount

this will automatically recount and make counts normal?

That's an idea.

It's not a perfect solution, but it will work.

If I don't find another better solution I will use that one for the next update.

Thanks

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

snoopy_virtual

Quote from: giveaway365.com on February 08, 2010, 12:05:21 PM
this is the error when a spammer registers:
8: Undefined index: types
File: /home/content/g/i/v/xxx/html/Sources/ManageMembers.php
Line: 381

line 381 is :
if (empty($range_trans[$_POST['types'][$param_name]]))

This is a different thing. It has nothing to do with the count bug.

Anyway this is not dangerous, just a pain in the .. thingy because every time you look in your error log it's full of them and this minor errors don't let you see the important ones.

The problem is I haven't defined the index types because it's not one of my indexes. It belongs to the main SMF program and (as far as I know) I am not using it. At least not on porpoise. Somehow it has slip inside my code.

<thinking myself>
     (maybe trough the base64_encode(serialize()) thing)
</thinking myself>

Anyway, even if this is not a dangerous bug, it's very annoying so it's the next one in the agenda, and actually this is the bug I was trying to sort when all the problem about the yellow bug started, and I only left it waiting because the another one was a lot more important.

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

EL34xyz

Snoop,
I am able to duplicate a serious bug that changes and existing member is_activated  from #1 to #3 in the data base

Admin/members/View all members.
Check the box that selects all members on that page.
Hit the button at the bottom of the page to check all these members in the stop forum spam data base.

Any members that get any sort of RED flag gets changed from member status #1 to awaiting membership #3 in the data base.

Stop spammer does this on it's own.

Now, every member that had some sort of RED flag shows up on the Waiting for membership page and is no longer a member.
The members that Stop Spammer flags are not spammers, they may have all or part of their Username that shows up in the data base, that does not mean they are spammers.

I just rejected a bunch of existing members because I was not sure why they all were showing up as members awating approval.
Now they are all gone and will have to re-register.

Please try and duplicate this.
You will have to find an existing member that gets a user name RED flagged
They will then have their is-activated status changed from #1 to #3 in the SMF database

SMF 1.1.11
Stop spam 2.3.7

snoopy_virtual

Quote from: EL34xyz on February 08, 2010, 12:11:52 PM
Snoop, I installed the 2.3.7  and something strange just happened.

After the install, I went to my members page and started checking all the members for possible spammers.

I had a bunch that had some spammer names that were flagged RED
The members were not spammers, they just had a name that was on the list.

...


This is one of the effects of the yellow bug. The mod, sometimes, was checking all the members of your forum when you just wanted to check one or a few.

I will suggest you do this:


  • Go to my site, download the file yellow_bug.php and execute it in your site to get ride of any rests of the yellow bug.
  • Be sure you have version 2.3.7 installed properly (I suppose you have, so just forget that one).
  • Go to your Admin => Registration => Settings and inside the StopSpammer settings un-tick the option "Check their username:". Leave the another 2 options on though, "Check their email:" and "Check their IP:"
  • Now go to your "Waiting for approval" place and approve everybody.
  • With all the members approved do a full check of all of them looking for spammers.

The program will check now only theirs IP and theirs email and won't bother with usernames, so you will be sure everything is OK.

If the program catches somebody because their email you are sure it's a spammer.

If it catches somebody because their IP can be 3 options:


  • It's a spammer.
  • It's a legal guy but the computer has a trojan and it's part of a botnet sending spam without the owner knowledge.
  • It's a legal guy but he has a dynamic IP (the ones changing every time  you restart your router) and today he has an IP which uses to belong to a spammer.

So if your program catches as spammer somebody you are sure is a legal person, just because the IP, you should tell them so they can scan the computer looking for trojans (or just restart the router and get another IP).

If you are interested in this subject, I have written a lot about it.

For example:

http://www.snoopyvirtualstudio.com/trankos/portal/index.php?option=com_smf&Itemid=36&topic=297.msg1230#msg1230

http://www.snoopyvirtualstudio.com/tutoriales/index.php?estudio=httpbl

etc.

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

EL34xyz

Snoop, 2.3.7 installed correctly without any files being flagged.

I assumed you had fixed all that yellow bug stuff in the new 2.3.7 release

Are you saying there is another mod I have to apply to the current mod???


kicky

Quote from: snoopy_virtual on February 08, 2010, 12:06:34 PM
Quote from: kicky on February 08, 2010, 07:21:17 AM
Hi, I installed this mod in my SMF 1.1.11

But everyone can not register....
The error is

Fatal error: Cannot redeclare spammercheck() (previously declared in /home/innovaco/public_html/Sources/Register.php:603) in /home/innovaco/public_html/Sources/Register.php on line 681

When someone click register.

can someone help me?
thanks in advance

The function spammercheck() doesn't belong to this mod.

Are you sure you have copied the error statement properly?

Ups sorry......

snoopy_virtual

February 08, 2010, 01:43:07 PM #472 Last Edit: February 08, 2010, 01:49:41 PM by snoopy_virtual
Quote from: EL34xyz on February 08, 2010, 01:19:10 PM
Snoop, 2.3.7 installed correctly without any files being flagged.

I assumed you had fixed all that yellow bug stuff in the new 2.3.7 release

Are you saying there is another mod I have to apply to the current mod???

Yes, I have fixed all that yellow bug stuff in the new 2.3.7 release.

But this only means that the mod is not going to get crazy again and check members you didn't want to check.

But if last week your forum went crazy (as all my forums did) because you had a version of the mod with that mistake (any version between 2.3 and 2.3.6) then maybe you still have in your database some wrong values.

I think I said it very clear here:

http://www.snoopyvirtualstudio.com/trankos/portal/index.php?option=com_smf&Itemid=36&topic=296.msg1264#msg1264

If your forum went mad with the yellow bug, you need to clean it first before installing the new version 2.3.7

Or maybe you just went to my site and downloaded the new version without noticing the big red warning sign saying "Read this first before downloading this version"?

Some forums went mad and some didn't. Some people have updated to 2.3.7 from 2.3.6, others have updated from 2.3, others have just installed it from scratch, etc. I needed to take all these possibilities into consideration, and that's why I put the "medicine" to clean the forums in a separate file (yellow_bug.php) so everybody could use it only if needed.

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

snoopy_virtual

Quote from: kicky on February 08, 2010, 01:27:29 PM
Quote from: snoopy_virtual on February 08, 2010, 12:06:34 PM
Quote from: kicky on February 08, 2010, 07:21:17 AM
Hi, I installed this mod in my SMF 1.1.11

But everyone can not register....
The error is
...

The function spammercheck() doesn't belong to this mod.

Are you sure you have copied the error statement properly?

Ups sorry......

Don't worry.

In part this is actually my fault. Well, my fault an also the rest of the people doing anti-spammer mods for SMF.

We should get in touch and either do only a big good mod for every different existing spammer database or at least be sure that all the mods are compatible.

Actually this is the reason why I started working with M-DVD.

When I met him, I was doing my first anti-spammer mod and he had already published his first version 1.0 of this mod, so what I did was, instead of continue working in my mod on my own, I contacted him, join his ideas with mine and we worked together to do version 2.0 of this one.

Just now, the only 2 anti-spammer mods fully compatible with each other (as far as I know) are the 2 mods I have in all my forums: This mod StopSpammer and the other mod I am doing, mod httpBL.

Every one works with a different spammer database:

Mod StopSpammer works with Stop Forum Spam's database and mod httpBL with Project Honey Pot's database.

And they are compatible just because I am doing both of them, but I haven't checked the rest of the anti-spammer mods available yet.

As I said, it's my fault. The problem is the day only have 24 hours. Sometimes I wish it had 40 at least.

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

mbreber

Quote from: snoopy_virtual on February 08, 2010, 12:18:06 PM
Quote from: mbreber on February 08, 2010, 11:29:21 AM
Hi, I installed this mod in my SMF 1.1.11 and I´m using Cratian language.

I have changed my Themes/default/languages/Modifications.croatian-utf8.php and translated but I see there´s a lo more of text:

....

Where should I put this text. In what language .php file?
Please help!!!

All the english text goes to Themes/default/languages/Modifications.english.php

As you can see in the changelog, from 2.3 to 2.3.7 I have added 7 new lines of text. (I have also change a little the old lines to correct a few mistakes).

When you install 2.3.7 all these new lines go automatically to that Modifications.english.php file. Check that they are there.

If they are not there you have made a mistake installing it.

Compare anyway your english and croatian files to see if you have these new 7 lines missing in your croatian file and (if so) translate them and send them to me if you don't mind, so I can add them too to the full language package.

Thanks

In Modifications.english.php I only have this lines:

//   MOD Stop Spammer
$txt['stopspammer_error'] = 'Error with DB Anti SPAM. Connection Failed.';
$txt['stopspammer_count'] = 'Spammers have been blocked';
$txt['stopspammer_title'] = 'Search more info in `Stop Forum Spam`';

madfitz


mbreber

OK, it was a wrong version.
Let me know your email for translation in PM

snoopy_virtual

Quote from: mbreber on February 08, 2010, 02:30:07 PM
OK, it was a wrong version.
Let me know your email for translation in PM

You have 3 options:

- Just publish the new lines already translated here so if there is another Croatian guy reading this can use them straight away

- Send me them in a PM

- Send me an email  info [at] snoopyvirtualstudio [dot] com

Anyone of them would do

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

snoopy_virtual

Quote from: madfitz on February 08, 2010, 02:24:14 PM
The mod here states version is 2.3 not 2.3.7?

http://custom.simplemachines.org/mods/index.php?mod=1547

Please read a little of what we have been saying here lately before you say something like that.

Version 2.3 have been obsolete since December 2009

El verdadero sabio es aquel que lo ve todo, lo estudia todo, lo analiza todo y molesta poco.
A true wise man is he who sees everything, studies everything, analyses everything and hardly ever annoys.

EL34xyz

QuoteYes, I have fixed all that yellow bug stuff in the new 2.3.7 release.

But this only means that the mod is not going to get crazy again and check members you didn't want to check.

But if last week your forum went crazy (as all my forums did) because you had a version of the mod with that mistake (any version between 2.3 and 2.3.6) then maybe you still have in your database some wrong values.

Well, my forum did not go crazy last week.
Exactly what is the yellow bug download doing???
Is it modifying the SMF code??

Advertisement: