• Welcome to Simple Machines Community Forum. Please login or sign up.

Unifying templates

Started by live627, September 12, 2014, 07:30:13 AM

Previous topic - Next topic

live627

While I was making my custom theme (using Bootstrap), I combined several templates, for ease of coding. I'm thinking of porting my changes to the default theme.


       
  • Postbit - same style in topic display, PM, and search
  • Topic lists - same style in message index and unread areas
  • Board list - same style in board index and message index

Thoughts? Do you think that maybe this will help themers?
(maybe I should make this public to get the opinions of the community...)

Illori

you mean the mini profile? that could be useful, but then we need to make sure things like the ip address in the pm view gets moved elsewhere. [if a pr has not done that already]

Bigguy

Getting public opinion sounds like a great way to go.

live627


Arantor

Because I totally didn't start getting things lined up for doing that or anything by separating the per-post template out of the main message template and I didn't have the unread areas also call the message index for the legend :P

On the one hand it sounds like a good idea. On the other... Display and Message index are likely to be amongst the places customised along with the Board index, and unifying them can actually limit customisation down the road.
No good deed goes unpunished
All helpful urges should be circumvented

Kindred

Actually, I could argue the other way

combining templates would prevent the theme from customizing the view... For example,  i don't want the boardindex and messageindex to have the same layouts and styling...

some combining,  post and pm, js a good idea.. but not indexes,  imo
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Arantor

Even though the message index has the same styling currently for child boards? And uses an almost exact copy of the code?
No good deed goes unpunished
All helpful urges should be circumvented

Kindred

Except  child boards are just additonal message inexes...
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

live627


Arantor

No, they use a copy of the board index code above the list of messages.

Source: http://www.simplemachines.org/community/index.php?board=3.0
No good deed goes unpunished
All helpful urges should be circumvented

Gary

I think Kindred's probably just getting himself mixed up again. He's probably talking about the actual lists of topics, rather than the boardlisting of child boards within the message view.




Anyway merging areas where code is duplicated would be a good idea, lord knows it'd save me a lot of hassle.
Gary M. Gadsdon
Do NOT PM me unless I say so
War of the Simpsons
Bongo Comics Fan Forum
Youtube Let's Plays

^ YT is changing monetisation policy, help reach 1000 sub threshold.

Hj Ahmad Rasyid Hj Ismail

Quote from: live627 on September 12, 2014, 07:30:13 AM

       
  • Postbit - same style in topic display, PM, and search
  • Topic lists - same style in message index and unread areas
  • Board list - same style in board index and message index
The first one is good except current search has no postbit at all unless you want to add that. If that is so, might as well add the same in recent posts too.

Advertisement: