Advertisement:
« previous next »
Pages: [1]   Go Down

Author Topic: Unifying templates  (Read 11399 times)

Offline live627

  • Development Contributor
  • SMF Hero
  • *
  • Posts: 5,620
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Unifying templates
« on: September 12, 2014, 07:30:13 AM »
While I was making my custom theme (using Bootstrap), I combined several templates, for ease of coding. I'm thinking of porting my changes to the default theme.

  • Postbit - same style in topic display, PM, and search
  • Topic lists - same style in message index and unread areas
  • Board list - same style in board index and message index

Thoughts? Do you think that maybe this will help themers?
(maybe I should make this public to get the opinions of the community...)
Logged
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline Illori

  • Project Manager
  • SMF Legend
  • *
  • Posts: 50,974
Re: Unifying templates
« Reply #1 on: September 12, 2014, 07:36:25 AM »
you mean the mini profile? that could be useful, but then we need to make sure things like the ip address in the pm view gets moved elsewhere. [if a pr has not done that already]
Logged

Offline Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 12,937
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: Unifying templates
« Reply #2 on: September 12, 2014, 09:05:11 AM »
Getting public opinion sounds like a great way to go.
Logged

Offline live627

  • Development Contributor
  • SMF Hero
  • *
  • Posts: 5,620
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: Unifying templates
« Reply #3 on: September 12, 2014, 10:07:17 AM »
Yeah. More themers.
Logged
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,203
    • StoryBB/StoryBB on GitHub
Re: Unifying templates
« Reply #4 on: September 12, 2014, 10:20:08 AM »
Because I totally didn't start getting things lined up for doing that or anything by separating the per-post template out of the main message template and I didn't have the unread areas also call the message index for the legend :P

On the one hand it sounds like a good idea. On the other... Display and Message index are likely to be amongst the places customised along with the Board index, and unifying them can actually limit customisation down the road.
Logged
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,317
  • Gender: Male
    • Kindred-999 on GitHub
Re: Unifying templates
« Reply #5 on: September 12, 2014, 10:22:08 AM »
Actually, I could argue the other way

combining templates would prevent the theme from customizing the view... For example,  i don't want the boardindex and messageindex to have the same layouts and styling...

some combining,  post and pm, js a good idea.. but not indexes,  imo
Logged
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,203
    • StoryBB/StoryBB on GitHub
Re: Unifying templates
« Reply #6 on: September 12, 2014, 10:24:50 AM »
Even though the message index has the same styling currently for child boards? And uses an almost exact copy of the code?
Logged
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,317
  • Gender: Male
    • Kindred-999 on GitHub
Re: Unifying templates
« Reply #7 on: September 12, 2014, 10:33:11 AM »
Except  child boards are just additonal message inexes...
Logged
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline live627

  • Development Contributor
  • SMF Hero
  • *
  • Posts: 5,620
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: Unifying templates
« Reply #8 on: September 12, 2014, 10:35:28 AM »
Quote from: Kindred on September 12, 2014, 10:33:11 AM
Except  child boards are just additonal message inexes...
huh?
Logged
Try not to become a man of success, but rather try to become a man of value.
- Albert Einstein

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,203
    • StoryBB/StoryBB on GitHub
Re: Unifying templates
« Reply #9 on: September 12, 2014, 10:36:56 AM »
No, they use a copy of the board index code above the list of messages.

Source: http://www.simplemachines.org/community/index.php?board=3.0
Logged
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Gazmanafc

  • Sorceress's Knight
  • Customizer
  • SMF Super Hero
  • *
  • Posts: 18,055
  • Gender: Male
  • So this is the luck of the draw...
    • Gazmanafc on Facebook
    • garygadsdon on LinkedIn
    • @Gazmanafc on Twitter
    • The Bongo Comics Fan Forum
Re: Unifying templates
« Reply #10 on: September 13, 2014, 07:51:40 AM »
I think Kindred's probably just getting himself mixed up again. He's probably talking about the actual lists of topics, rather than the boardlisting of child boards within the message view.


Anyway merging areas where code is duplicated would be a good idea, lord knows it'd save me a lot of hassle.
Logged
Gary M. Gadsdon
Do NOT PM me unless I say so

War of the Simpsons
Bongo Comics Fan Forum
Youtube Let's Plays
^ YT is changing monetisation policy, help reach 1000 sub threshold.

Offline ahrasis

  • SMF Hero
  • ******
  • Posts: 4,916
  • Gender: Male
  • Busy mode is on.
    • ahrasis on GitHub
    • ahrasis on LinkedIn
    • ElkArte Malaysia
Re: Unifying templates
« Reply #11 on: September 13, 2014, 02:05:48 PM »
Quote from: live627 on September 12, 2014, 07:30:13 AM
  • Postbit - same style in topic display, PM, and search
  • Topic lists - same style in message index and unread areas
  • Board list - same style in board index and message index
The first one is good except current search has no postbit at all unless you want to add that. If that is so, might as well add the same in recent posts too.
Logged
Pages: [1]   Go Up
« previous next »