Advertisement:

Author Topic: [3.0] Redo the theme system for SMF (2.1+ obviously)  (Read 44330 times)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,055
    • Arantor on GitHub
Re: [3.0] Redo the theme system for SMF (2.1+ obviously)
« Reply #40 on: January 03, 2015, 03:31:47 PM »
Yes but that limits flexibility oh noes

You're preaching to the converted and the ways to solve all this stuff *nicely* are 3.0 territory. But they *are* doable.
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,648
  • Gender: Male
  • Black cat rulz!
    • Antes on GitHub
    • merta on LinkedIn
    • @antesistan on Twitter
    • Lunarfall
Re: [3.0] Redo the theme system for SMF (2.1+ obviously)
« Reply #41 on: January 03, 2015, 03:44:22 PM »
isn't theme variants designed for this? Multiple colors, or having same theme with small changes. no?
Active Project(s): [ SimpleDesk ] # [ Lunarfall ] # [ CoreStore ]

Past Project(s): [ ezPortal ]

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,055
    • Arantor on GitHub
Re: [3.0] Redo the theme system for SMF (2.1+ obviously)
« Reply #42 on: January 03, 2015, 03:51:19 PM »
Sort of but there are a lot of people that for whom CSS would be too complicated and just want something nice and friendlier in the admin panel.

Like XF has, for example.
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline Antechinus

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 24,136
  • Master of BBC Abuse
Re: [3.0] Redo the theme system for SMF (2.1+ obviously)
« Reply #43 on: January 03, 2015, 03:57:23 PM »
Case in point, actually. I've done several multi variant themes, for 1.1.x and 2.0.x, and the variant system brings in problems.

Say you want to create a dark variant and a light one. This means the best text colours are often going to be different. For example, if you have one membergroup coloured purple it may be perfectly fine on the light variant, but almost illegible on the dark one. If you have a group coloured a pale yellow it may be fine on the dark variant but not on the light one.

Then there's the background colours themselves, regardless of lightness or darkness. Some colours just don't go well together, and the more adventurous you get with variants the more you'll find yourself wishing that some dumb motherf***ers hadn't forced everything to be one way in Sources. :D You'll find yourself long for things like group colours assignable by theme and by variant. You might even think about writing a mod for it, when it should have been doable in default. ;)

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,055
    • Arantor on GitHub
Re: [3.0] Redo the theme system for SMF (2.1+ obviously)
« Reply #44 on: January 03, 2015, 03:59:46 PM »
Except it would raise more issues because 'why do we have to do this' because it's not like this has never been asked before or anything :P

The variant thing is also actually less common than you might think, at least going out into the wider world of forum software and seeing what people actually do on their sites (and not just SMF ones)
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline Antechinus

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 24,136
  • Master of BBC Abuse
Re: [3.0] Redo the theme system for SMF (2.1+ obviously)
« Reply #45 on: January 03, 2015, 04:04:59 PM »
Sort of but there are a lot of people that for whom CSS would be too complicated and just want something nice and friendlier in the admin panel.

Like XF has, for example.

Yup, that too. Although it does bring a performance hit with it.

And speaking of complex CSS, even for people who can write it there often comes a point where you will start thinking that Zen Garden showing off is all very well, but it really would make more sense to switch the markup.


Except it would raise more issues because 'why do we have to do this' because it's not like this has never been asked before or anything :P

The variant thing is also actually less common than you might think, at least going out into the wider world of forum software and seeing what people actually do on their sites (and not just SMF ones)


It's not just about variants though. It's about any site which offers more than one background colour. If you offer a selection, there's a good chance you won't want presentation forced one-size-fits-all in Sources.


Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 68,055
    • Arantor on GitHub
Re: [3.0] Redo the theme system for SMF (2.1+ obviously)
« Reply #46 on: January 03, 2015, 04:13:58 PM »
Quote
Although it does bring a performance hit with it.

Only if done properly. XF's setup is not unperformant - and is *significantly* easier to use for non technical people; after all, the vast majority of SMF admins are not technical. Something that lets them do a simple change in the admin panel is enough for most people.
To assume is to hope that those who came before had the presence of mind and capacity to implement the dreams of those who would come after.

You either die a hero or live long enough to see yourself become the villain. It seems you have chosen which, and now I must do the same.

Offline Antes

  • Evil Black Cat
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 8,648
  • Gender: Male
  • Black cat rulz!
    • Antes on GitHub
    • merta on LinkedIn
    • @antesistan on Twitter
    • Lunarfall
Re: [3.0] Redo the theme system for SMF (2.1+ obviously)
« Reply #47 on: January 03, 2015, 04:18:04 PM »
Then give membergroups specific class and colorize it via CSS with that all colors fit, since you can change them based on variant.

I don't find it extreme difficult, I think anyone with basic FTP/File edit knowledge can do this. Its not unlearnable.
Active Project(s): [ SimpleDesk ] # [ Lunarfall ] # [ CoreStore ]

Past Project(s): [ ezPortal ]