News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

Share This Topic

Started by All Colours Sam, September 06, 2009, 05:09:23 AM

Previous topic - Next topic

RvG

Ms. MAS :)
thank you for your mod. However, I would like to ask why when I send a link to twitter still it shows as zero.

All Colours Sam

Can you post a link to a topic where the tweet are suppose to appear?
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

DrBermant

Quote from: Miss All Sunday on May 23, 2011, 11:06:32 AM
Can you post a link to a topic where the tweet are suppose to appear?

I have a feeling it is a function of twitter. I tweet every one of my forum posts. When I reviewed just one forum this morning in response to this question, I found the twitter counter over 1 for almost all of the posts. Example of one recent set of posts and tweet count working on a Gynecomastia Forum:

http://www.abodybeautiful.com/forum/index.php/board,25.0.html

Yet, the other day, all of the counts were at zero well after the initial tweets. I do know that right after the tweet, I do not remember ever seeing a count change directly. I have yet to document the time lag between tweet and the count showing.

As I went through post after post checking for tweet count, here is one example of one I know I never tweeted:

http://www.abodybeautiful.com/forum/index.php/topic,230.0.html

check its post count as of making this topic was 62 compared to the 100 - 400 views for the other posts.

http://www.abodybeautiful.com/forum/index.php/topic,337.0.html

was just posted this am and the tweet count of 1 is right 3 hours later with a view count of 136.

Here is a post I did tweet and no record of that tweet 6 weeks later:

http://www.abodybeautiful.com/forum/index.php/topic,230.0.html

I am almost certain that I tweeted it, the read count is right there with the other ones with one tweet. Some posts have been tweeted more than once, but not by me showing the code is up and working by others.

I have never done as thorough a look at the tweet numbers but casual reference in the past, I thought that number count was not a consistent thing. If one of these posts I have documented comes up with a zero tweet count in the future, I will screen capture the image and post it here. That will prove my theory about this being a twitter centric issue.

Anyway, your mod works great and thank you for all of the time you put in here to help others.

Michael Bermant, M.D.
Board Certified
American Board Plastic Surgery
Plastic Surgery Encyclopedia
A Body Beautiful Plastic Surgery Forum

DrBermant

Quote from: Miss All Sunday on May 23, 2011, 11:06:32 AM
Can you post a link to a topic where the tweet are suppose to appear?

After posting I went back and looked at another forum on my site: Otoplasty Forum:
http://www.abodybeautiful.com/forum/index.php/board,1.0.html

and this brings up another variable I may have missed in my prior analysis. Date when tweeted. I tend to tweet a post shortly after writing it.

I am putting this up as a separate post to keep the links to each subforum separate to minimize confusion. This post will not include observations noted in the prior one.

Checking through the posts on this part of the site, most have a tweet count of 0 yet, they probably all were twitted just like the other forum. Post read counts confirm. Here are a few sample posts with a zero tweet count:

http://www.abodybeautiful.com/forum/index.php/topic,316.0.html
http://www.abodybeautiful.com/forum/index.php/topic,168.0.html
http://www.abodybeautiful.com/forum/index.php/topic,108.0.html

all were with zero in that field. I scanned through each post and there is no rhyme nor reason date wise if the count is recorded. I am not certain I can correlate by time of day. Yet other posts do have a tweet count of one or more.

Sorry if this is confusing, but this is just an observation and further evidence of the variable here: twitter, not the mod's code unless I am missing an update to the mod that fixed something with an older post reporting to twitter. The other forum section (gynecomastia) is with newer posts than the one for this section (otoplasty).

Michael Bermant, M.D.
Board Certified
American Board Plastic Surgery
Plastic Surgery Encyclopedia
A Body Beautiful Plastic Surgery Forum

All Colours Sam

Yes, its difficult to determinate why exactly a tweet, digg or the buzz button doesn't count properly, there are several factors such as server issues or JavaScript issues,  this is beyond my range of support,  this mod only provides a way to show those buttons in a clean and efficient way but I have no control over the full process,  I can, however, pay attention to the updates and changes from those external sites and applied those changes to the mod to keep it updated.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

DrBermant

Quote from: Miss All Sunday on May 23, 2011, 01:40:24 PM
Yes, its difficult to determinate why exactly a tweet, digg or the buzz button doesn't count properly, there are several factors such as server issues or JavaScript issues,  this is beyond my range of support,  this mod only provides a way to show those buttons in a clean and efficient way but I have no control over the full process,  I can, however, pay attention to the updates and changes from those external sites and applied those changes to the mod to keep it updated.

Thank you for your answer and time.

Michael Bermant, M.D.
Board Certified
American Board Plastic Surgery
Plastic Surgery Encyclopedia
A Body Beautiful Plastic Surgery Forum

protonxl

hey, id like to add too that even after i tweet it still shows up at 0 tweets.

from what i can tell the link of the website is using prettyurl which is .net/this-is-post-title while twitter shares .net/index.php?topic=####

for some reason it also posts whole link.. can it be shorturl?

All Colours Sam

this mod is not compatible with pretty urls mod.

the tweet button replies on javascript and twitter servers to function properly, if one of those fails, its very likely your tweet butotn will not show the number of tweets.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

hotwheels

Okay, i have installed this mod and it won't share any attachments from posts.......here are the changes i tried to make in display.php

// define some parameters
$parameters = array(
'url' => $scripturl . '?topic=' . $topic . '.msg' . $message['ID_MSG'] . '#msg' . $message['ID_MSG'], $attachment['thumbnail']['href'],

);
       
// :)
  $suki =  share_this($parameters);
  $mirahalo = share_icons($parameters);

if (!empty($modSettings['share_all_messages']) &&  !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body'].$mirahalo);

if (empty($modSettings['share_all_messages']) && $counter == 0 &&  !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body'].$mirahalo);

    // Share this topic mod end

// Do the censor thang.
censorText($message['body']);
censorText($message['subject']);

// Run BBC interpreter on the message.
$message['body'] = parse_bbc($message['body'], $message['smileysEnabled'], $message['ID_MSG'], $attachment['ID_THUMB']);

// Compose the memory eat- I mean message array.
$output = array(
'attachment' => loadAttachmentContext($message['ID_MSG']),
'alternate' => $counter % 2,
'id' => $message['ID_MSG'],
'href' => $scripturl . '?topic=' . $topic . '.msg' . $message['ID_MSG'] . '#msg' . $message['ID_MSG'], $attachment['ID_THUMB'],
'link' => '<a href="' . $scripturl . '?topic=' . $topic . '.msg' . $message['ID_MSG'] . '#msg' . $message['ID_MSG'] . '">' . $message['subject'] . '</a>',
'member' => &$memberContext[$message['ID_MEMBER']],
'icon' => $message['icon'],
'icon_url' => $settings[$context['icon_sources'][$message['icon']]] . '/post/' . $message['icon'] . '.gif',
'subject' => $message['subject'],
'time' => timeformat($message['posterTime']),
'timestamp' => forum_time(true, $message['posterTime']),
'counter' => $counter,
'modified' => array(
'time' => timeformat($message['modifiedTime']),
'timestamp' => forum_time(true, $message['modifiedTime']),
'name' => $message['modifiedName']
),
'body' => $message['body'],
'new' => empty($message['isRead']),
'first_new' => isset($context['start_from']) && $context['start_from'] == $counter,
'can_modify' => (!$context['is_locked'] || allowedTo('moderate_board')) && (allowedTo('modify_any') || (allowedTo('modify_replies') && $context['user']['started']) || (allowedTo('modify_own') && $message['ID_MEMBER'] == $ID_MEMBER && (empty($modSettings['edit_disable_time']) || $message['posterTime'] + $modSettings['edit_disable_time'] * 60 > time()))),
'can_remove' => allowedTo('delete_any') || (allowedTo('delete_replies') && $context['user']['started']) || (allowedTo('delete_own') && $message['ID_MEMBER'] == $ID_MEMBER && (empty($modSettings['edit_disable_time']) || $message['posterTime'] + $modSettings['edit_disable_time'] * 60 > time())),
'can_see_ip' => allowedTo('moderate_forum') || ($message['ID_MEMBER'] == $ID_MEMBER && !empty($ID_MEMBER)),


);

if (empty($options['view_newest_first']))
$counter++;
else
$counter--;

return $output;
}


what am i missing here?

hotwheels

Here is another set of coding i tried and still can't pull an attachment from my board:

// share this topic start

    // Lets check if there are some boards where the buttons will NOT be show
    if (!empty($modSettings['share_options_boards']))
{
$share_denied_boards = explode(",", preg_replace("/[^0-9,]/", "", $modSettings['share_options_boards']));
foreach ($share_denied_boards as $key => $value) if ($value == "") unset($share_denied_boards[$key]);
}
else $share_denied_boards[] = '';

// define some parameters
$parameters = array(
'url' => $scripturl . '?topic=' . $topic . '.msg' . $message['ID_MSG'] . '#msg' . $message['ID_MSG'], $attachment['thumbnail']['href'],

);
       
// :)
  $suki =  share_this($parameters);
  $mirahalo = share_icons($parameters);

if (!empty($modSettings['share_all_messages']) &&  !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body'].$mirahalo);

if (empty($modSettings['share_all_messages']) && $counter == 0 &&  !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body'].$mirahalo);

    // Share this topic mod end

// Do the censor thang.
censorText($message['body']);
censorText($message['subject']);

// Run BBC interpreter on the message.
$message['body'] = parse_bbc($message['body'], $message['smileysEnabled'], $message['ID_MSG'], $attachment['ID_THUMB']);

// Compose the memory eat- I mean message array.
$output = array(
'attachment' => loadAttachmentContext($message['ID_MSG'], $attachment['ID_ATTACH']),
'alternate' => $counter % 2,
'id' => $message['ID_MSG'], $attachment['ID_THUMB'],
'id' => $attachment['ID_THUMB'],
'href' => $scripturl . '?topic=' . $topic . '.msg' . $message['ID_MSG'] . '#msg' . $message['ID_MSG'], $attachment['ID_THUMB'],
'link' => '<a href="' . $scripturl . '?topic=' . $topic . '.msg' . $message['ID_MSG'] . '#msg' . $message['ID_MSG'] . '">' . $message['subject'] . '</a>',
'member' => &$memberContext[$message['ID_MEMBER']],
'icon' => $message['icon'],
'href' => $scripturl . '?action=dlattach;topic=' . $topic . '.0;attach=' . $attachment['ID_THUMB'] . ';image',
'link' => '<a href="' . $scripturl . '?action=dlattach;topic=' . $topic . '.0;attach=' . $attachment['ID_ATTACH'] . '">' . htmlspecialchars($attachment['filename']) . '</a>',
'icon_url' => $settings[$context['icon_sources'][$message['icon']]] . '/post/' . $message['icon'] . '.gif',
'subject' => $message['subject'],
'time' => timeformat($message['posterTime']),
'timestamp' => forum_time(true, $message['posterTime']),
'counter' => $counter,
'modified' => array(
'time' => timeformat($message['modifiedTime']),
'timestamp' => forum_time(true, $message['modifiedTime']),
'name' => $message['modifiedName']
),
'body' => $message['body'],
'new' => empty($message['isRead']),
'first_new' => isset($context['start_from']) && $context['start_from'] == $counter,
'can_modify' => (!$context['is_locked'] || allowedTo('moderate_board')) && (allowedTo('modify_any') || (allowedTo('modify_replies') && $context['user']['started']) || (allowedTo('modify_own') && $message['ID_MEMBER'] == $ID_MEMBER && (empty($modSettings['edit_disable_time']) || $message['posterTime'] + $modSettings['edit_disable_time'] * 60 > time()))),
'can_remove' => allowedTo('delete_any') || (allowedTo('delete_replies') && $context['user']['started']) || (allowedTo('delete_own') && $message['ID_MEMBER'] == $ID_MEMBER && (empty($modSettings['edit_disable_time']) || $message['posterTime'] + $modSettings['edit_disable_time'] * 60 > time())),
'can_see_ip' => allowedTo('moderate_forum') || ($message['ID_MEMBER'] == $ID_MEMBER && !empty($ID_MEMBER)),


);

if (empty($options['view_newest_first']))
$counter++;
else
$counter--;

return $output;
}

Apllicmz

Good Mod
When Update dont forget to Update

Attach Portuguese Linguage



All Colours Sam

@hotwheels   this mod does not share the attachments at all, it doesn't say anything regardinf attachments  in the mod 's description.

this mod can't share attachments, this mod is using the iframe version of the like button, this means there's no parameter for the image to show,  once you "liked"  a topic, facebook will scan the page and show to the user several images and its up to the user if (s)he want to display an image or not.


@Joomlamz   thank you, I will update the mod shortly.
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

hotwheels

I fully understand the description.....I have just been looking at the code and noticed if a user places a picture from a link via , it will show up as a choice to like. It would seem to me that there should be a parameter available to grab an actual attachment since it is basically the same thing as an image, but instead of an offsite link, it should be able to grab the id of the attachment onsite............

basically you have been the only one willing to even look at the code so i am just sharing my thoughts and steps. I will get it figured out eventually, i had to do the same thing with my vbulletin site...which has a share this mod, which pulls attachments....I am just comparing codes and they are quite a bit different.....

Thanks for your replies.....i do appreciate them.

doug

venex

Hello!! Hopefully I'm not too late to ask a new feature for next update!

Google came up with what they called "+1". I would like to have the opportunity to add that to my page. You can check out the Google +1 on this page: http://www.google.com/+1/button/

=D

All Colours Sam

sure, let me see how that thing works :P    is it gonna replace the google buzz button or is it a complte different one?

since quite a lot of time I has thinking in deleting the buzz button from this mod, from all the 4 (facebook, digg, twitter and buzz)  buzz seems to be the less popular one :P
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

briggz5d

i simply wanted a facebook and twitter share button for all topics. since the ADDTHIS mod doesnt work on smf 2.0 i decided to try this one.. i can currently BOAST of over 5000 error logs all related to SHARETHISa and saying something about "newest first" a simple edit should be shown to warn users that they need to manually edit .. not everyone has the luxury to detect errors and come report them and use the solutions u provide here.

Anyways.. mod uninstalled untill further notice..
Manual edits to files Ended the life of my 1.1.13 use.. i wont make the same mistake manually editing every mod on this smf 2.0

DrBermant

Quote from: Miss All Sunday on June 02, 2011, 01:36:23 PM
sure, let me see how that thing works :P    is it gonna replace the google buzz button or is it a complte different one?

since quite a lot of time I has thinking in deleting the buzz button from this mod, from all the 4 (facebook, digg, twitter and buzz)  buzz seems to be the less popular one :P

I like the Twitter the most, next is facebook like, then Digg. I do not use the buzz. I occasionally use some of the lower buttons and it would be interesting to learn which of them have proven useful to others or not working like I reported one in a prior post.

I am not sure about the value of the google plus tool but have seen some write ups saying it was important to have it on your site. However, how valid were these comments? Not able to assess with any certainty.

Thank you for your work on this mod.

Michael Bermant, M.D.
Board Certified
American Board Plastic Surgery
Plastic Surgery Encyclopedia
A Body Beautiful Plastic Surgery Forum

mastro

Hi there.
I tried to move the buttons to the moderatorbar but with no luck.
Changed my display.template.php to this <div class="smalltext reportlinks">',$mirahalo,'';
And then changed my display.php to this:

if (!empty($modSettings['share_all_messages']) &&  !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body']);

if (empty($modSettings['share_all_messages']) && $counter == 0 && $options['view_newest_first'] == 0 &&  !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body']);

// special case for when the "recent first" option is enable
if (empty($modSettings['share_all_messages']) && $counter == 1 && $options['view_newest_first'] == 1 && !in_array($board_info['id'], $share_denied_boards))
$message['body'] = ($suki.$message['body']);


I didn't see any change...What am I doing wrong??
I don't care that the buttons are inside the moderatorbar, I just want to be anywhere below the post.

All Colours Sam

soki2ng   if you do not give enough info about your issue I can't help....  complain isnt gonna solve your problem....


what language are you using?   what are the errors on your error log?

did you use a custom theme?


@DrBermant   I did check the icons when I released the 2.0 version I believe, an that time I removed several bookmark sites that were no longer on line, maybe its time to do that again.


@mastro   atach both your Sources/Display.php and your theme's Display.template.php
Oh, wouldn't it be great if I *was* crazy? ...then the world would be okay
Suki

DrBermant

Quote from: Miss All Sunday on June 05, 2011, 05:42:16 PM
@DrBermant   I did check the icons when I released the 2.0 version I believe, an that time I removed several bookmark sites that were no longer on line, maybe its time to do that again.

You do so much good work that should not be needed. I was hoping others using the mod would help. For me it was easy, try them and if it did not work just turn it off. But that is no help to others, which is what I was trying to stimulate here.

I really do not know enough about the value of Google +1 though, and was also hoping to see more discussion about that module. Sorry, but I have not tried to test the other buttons. I should do it for the work you have done. Just have to find the time.

I was just admiring how nice your Facebook like button works on the post. Here is another mind bender that I do not expect an answer, just a tease about possibilities. I do not know enough about the coding issues to even know if it is possible or just leave it alone:

Here is that post that I just liked and tweeted once:

http://www.abodybeautiful.com/forum/index.php/topic,367.msg445.html

Just checked it again and tweets up to 3.

Now, look at a node level such as:

http://www.abodybeautiful.com/forum/index.php/board,25.0.html

which is the gynecomastia section of the forum. No like buttons, no twitter or other buttons. My guess is that if messing with templates for larger issues there may be conflicts. Perhaps it is a bad idea to tweet or like such a ULR, but entry points to the forum or sub forums might warrant consideration for that option. If such a feature were to be added in the future, my suggestion would be to make it something the user could turn off or on. I would also be satisfied to learn that liking tweeting or whatever social network promoting of that type of node is not a good idea.

Anyway, thank you for answering. Your help is always appreciated.

Michael Bermant, M.D.
Board Certified
American Board Plastic Surgery
Plastic Surgery Encyclopedia
A Body Beautiful Plastic Surgery Forum

Advertisement: