News:

SMF 2.1.4 has been released! Take it for a spin! Read more.

Main Menu

ENotify

Started by SMFHacks.com Team, October 18, 2009, 04:40:06 PM

Previous topic - Next topic

Arantor

QuoteThat depends on your settings, but if you've removed it fully it shouldn't be doing it at all.

Even if you remove it fully, anyone who still has an old page in their browser will see it just carry on triggering it anyway until they move to another page.
Holder of controversial views, all of which my own.


bilbo32

True of course, but they're talking about 10,000 such errors in 5 minutes. That's a lot of people not doing much if that's the case.

Arantor

Doesn't take many users with multiple tabs open on your site to accumulate that. Right now, for example, I have about 6 tabs open on this website ;)
Holder of controversial views, all of which my own.


bahgheera

I couldn't find any trace of enotify in Load.php. I'm going to go look at the parse and check any other files that might have leftover code. Thanks for the reply.

bilbo32

Still seems quite high, default heartbeat is 10 seconds, so your 6 tabs is 6x6x5 = 180.

I'm also still miffed at why when I remove it completely as per destructions, I loose login functionality.

bahgheera

So I just went through the parse instructions and checked everything, can't find any trace of enotify in my forum. Yet guest ip's are still hitting that "action=enotify" link. ???

Is there a page somewhere here that explains the error messages? Undefined offset? I don't know what that means.


bilbo32

You could try - Change this :-
if (!$context[linktree][1] || $context[linktree][1][url] ===
To :-
if (isset($context[linktree][1]) && !$context[linktree][1] || $context[linktree][1][url] ===


That error means it's trying to reference something that isn't set, which it wouldn't be if called by enotify.

LiroyvH

Quote
Yet guest ip's are still hitting that "action=enotify" link

If memory serves right, they actually keep doing that until closing screen or refreshing the page, because of the way the mod is built.
((U + C + I)x(10 − S)) / 20xAx1 / (1 − sin(F / 10))
President/CEO of Simple Machines - Server Manager
Please do not PM for support - anything else is usually OK.

bilbo32

They will, but I've just noticed, that code you copied.... shouldn't if (!$context[linktree][1] || $context[linktree][1][url] actually be if (!$context['linktree'][1] || $context['linktree'][1][url] complete with parentheses regardless of what enotify is doing?

bahgheera

Oooooh.... so the reason the enotify link keeps getting hit is from browsers with the page still open from before I modified it running the ajax script? Who are these people?! Don't they ever close my site! Heh heh, maybe if I wait a day or two the enotify traffic will die down.

bilbo32

I still think you'll have the problem with the missing parenthesis, just less hits showing it up ;)

bahgheera

Derp, I am an idiot. I had all the parentheses, I forgot quotes around the array keys... I am so close to fixing this though! Thanks for all your help, you've set me on the right track.

bahgheera

I think it's sorted - I replaced the entire line with
        if (!isset($context['linktree'][1])) {


And now, forum works, no errors so far. It wasn't a problem with enotify, per se, it was a problem with enotify scripts still running on browsers that haven't been refreshed. Thanks for the help everyone.

mightyharimau

Hi, I'm not sure if this question has been asked, how do I extend the notification duration in Enotify?

Thanks
Selvan

luuuciano

life:3000 at enotify.js
Be careful when editing/saving it... it is a bunch of compressed JS files, long lines... do a backup

https://github.com/stanlemon/jGrowl/blob/master/README.md
No me agradan los foros que no te dejan borrar TU PROPIO usuario, como por ejemplo smfsimple.com.
E incluso te mandan emails no solicitados, de los cuales, quizá, no puedas escapar porque NO te dejan posibilidad a deshabilitarlos (a menos que NO te tengan en su lista negra).

Raffoz

Help please!!! :(

I uninstalled eNotify because the load of my server was crazy... but even after uninstalling, i have some strange logs.
I read in the log:
xxx.xxx.xxx.xxx - - [25/Jan/2014:02:22:02 -0800] "GET /index.php?action=enotify HTTP/1.1" 200 10396 "http://mydomain.com/index.php/topic,xxxx.0.html" "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.76 Safari/537.36"

How can stop it to continue to make request to my site?

Thanks! :)
MacOsX (last)
SMF 2.0.15 and 2.1.2 (different forums)
Chrome (last) or Safari (last)

Biology Forums

Quote from: Raffaele1977 on January 25, 2014, 05:31:43 AM
Help please!!! :(

I uninstalled eNotify because the load of my server was crazy... but even after uninstalling, i have some strange logs.
I read in the log:
xxx.xxx.xxx.xxx - - [25/Jan/2014:02:22:02 -0800] "GET /index.php?action=enotify HTTP/1.1" 200 10396 "http://mydomain.com/index.php/topic,xxxx.0.html" "Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/32.0.1700.76 Safari/537.36"

How can stop it to continue to make request to my site?

Thanks! :)

This happened to me actually. The way I 'fixed' it is I went into the database, searched the keyword 'enotify' and deleted everything that was associated with that word. I don't recommend you do this, but if you do it with care, you might not end up wrecking your database.

Arantor

Well it would do... the pages that contain the 'call home' request were still loaded and still making requests until such time as they refresh. (Assuming uninstallation was complete anyway)
Holder of controversial views, all of which my own.


sah62

I'm seeing a number of entries in my MySQL slow query log from actions performed by ENotify. Here's an example (with some server-specific information modified for privacy reasons):


# Time: 140129 12:41:12
# User@Host: db1[db1] @ localhost []
# Query_time: 1.944887  Lock_time: 0.000139 Rows_sent: 0  Rows_examined: 0
SET timestamp=1391017272;
INSERT IGNORE INTO smf_log_enotify_replies(`enot_item_id`, `enot_title`, `enot_time`, `enot_link`, `enot_sender`, `enot_sender_link`, `id_member`)
                VALUES
                        (66972, SUBSTRING('Re: Subject', 1, 255), 1224716956, 'http://www.myserver.org/forum/index.php?topic=11234.msg66972;topicseen#msg66972', SUBSTRING('user', 1, 255), 'http://www.myserver.org/forum/index.php?action=profile;u=101', 251);


Is there any reason these queries should be taking longer than 1 second to execute?

Advertisement: