• Welcome to Simple Machines Community Forum. Please login or sign up.
November 28, 2021, 10:09:27 PM

News:

Wondering if this will always be free?  See why free is better.


[4794] Search Personal Messages - Error margin is off.

Started by Matthew K., September 14, 2010, 06:35:06 PM

Previous topic - Next topic

Matthew K.

I was looking around on the latest dev release for Charter Members (DEV 20100913) and I found a margin issue.

Screenshot: http://prntscr.com/wj07

After reviewing other areas with similar messages, I noticed that they are above the catbg's, not below like this case.

I tested this in the latest versions of FireFox, as well as Google Chrome.


Matthew K.

I'd love to resolve this...is this supposed to be above the catbg, following the rest of the messages like this one? Or is it just supposed to be bumped down?

Antechinus

Should be in the same position as all other error messages IMO.

Matthew K.

Not that my opinion counts for anything in a final decision, but I agree. :P

Matthew K.

Here's the result: http://prntscr.com/wkj2

The correction.
./Themes/default/PersonalMessage.template.php
Code (Find) Select

<form action="', $scripturl, '?action=pm;sa=search2" method="post" accept-charset="', $context['character_set'], '" name="searchform" id="searchform">
<div class="cat_bar">
<h3 class="catbg">', $txt['pm_search_title'], '</h3>
</div>';

if (!empty($context['search_errors']))
{
echo '
<div class="errorbox">
', implode('<br />', $context['search_errors']['messages']), '
</div>';
}

Code (Should be) Select

<form action="', $scripturl, '?action=pm;sa=search2" method="post" accept-charset="', $context['character_set'], '" name="searchform" id="searchform">';

if (!empty($context['search_errors']))
{
echo '
<div class="errorbox">
', implode('<br />', $context['search_errors']['messages']), '
</div>';
}

echo '<div class="cat_bar">
<h3 class="catbg">', $txt['pm_search_title'], '</h3>
</div>';

emanuele

This one was missed.

But... the error box for the normal search page has different colors but it is in the same position.
Which is correct? Which is wrong?


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Antechinus

They should be consistent on all pages IMO. Track it to Mantis and assign to to me.

emanuele



Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Advertisement: