Advertisement:

Author Topic: Remove images from Quotes  (Read 21760 times)

Offline Chas Large

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,108
  • Gender: Male
  • Running 2.0.xx on Apache.
    • Chas.Large on Facebook
    • https://www.linkedin.com/in/charles-large-568ba213 on LinkedIn
    • @https://twitter.com/ on Twitter
    • Chas Large's Site
Re: Remove images from Quotes
« Reply #40 on: November 28, 2012, 07:26:09 AM »
Thank you very much :) This modification is really useful, it keeps everything a lot cleaner.
But is there a way to apply this to all excising posts? If not, well, nah don't mind it it's fine :P

Greetings,
Maarten
Glad you found it useful but sadly there is no way to edit the posts prior to installing the mod other than manual editing.
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Offline PopUpSteve

  • Semi-Newbie
  • *
  • Posts: 74
  • Gender: Male
    • PopUpPortal
Re: Remove images from Quotes
« Reply #41 on: December 27, 2012, 04:30:03 PM »
Interesting mod. I would love to install this but from your last statement:
Quote
no way to edit the posts prior to installing the mod
it makes me think that you are modifying the text at the time of the post. Wouldn't be better to modify the text as it is being displayed, on the fly as it were and not changing the original? That way it would work with all existing posts, no matter when they were made and allow for changes to your mod in the future.
Steve
"Even a broken clock is right twice a day, unless it's digital."

Offline Chas Large

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,108
  • Gender: Male
  • Running 2.0.xx on Apache.
    • Chas.Large on Facebook
    • https://www.linkedin.com/in/charles-large-568ba213 on LinkedIn
    • @https://twitter.com/ on Twitter
    • Chas Large's Site
Re: Remove images from Quotes
« Reply #42 on: December 27, 2012, 05:45:28 PM »
A good point and you're quite right, the mod removes the image from a quoted post on a post by post basis rather than by running a dB query to achieve the same effect.

If you care to come up with the dB query code to do it, I'm happy to modify the mod and give you credit for that work.

Personally I don't think it's necessary as it would involve running the query for every quote made to check for an image and remove it, this might push up the overhead on the server somewhat.
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Offline Steve

  • Freak
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 4,500
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Remove images from Quotes
« Reply #43 on: January 28, 2014, 08:31:26 PM »
Is this mod still being maintained? I seem to be having issues with it working since the upgrade to 2.0.7.
Online Manual

Please do not PM me for support.

Offline Chas Large

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,108
  • Gender: Male
  • Running 2.0.xx on Apache.
    • Chas.Large on Facebook
    • https://www.linkedin.com/in/charles-large-568ba213 on LinkedIn
    • @https://twitter.com/ on Twitter
    • Chas Large's Site
Re: Remove images from Quotes
« Reply #44 on: January 30, 2014, 07:36:56 AM »
Maintained? no, not unless changes in SMF 2.0.xx cause any issues, it works perfectly in 2.0.7. Could be clashing with other mods? What are the symptoms and what other mods do you have installed?
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Offline Steve

  • Freak
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 4,500
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Remove images from Quotes
« Reply #45 on: January 30, 2014, 09:53:37 AM »
Thanks for responding. I actually fixed it this morning. I parsed the code where you download the mod from and in the modifications.english.php file, somehow the line that was supposed to be right above the end code wasn't there. I found it several lines back, moved it to where it was supposed to be, and voila! Works like a charm now.

Don't know why and I'm not sure I care as long as it works. lol :D
Online Manual

Please do not PM me for support.

Offline Chas Large

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,108
  • Gender: Male
  • Running 2.0.xx on Apache.
    • Chas.Large on Facebook
    • https://www.linkedin.com/in/charles-large-568ba213 on LinkedIn
    • @https://twitter.com/ on Twitter
    • Chas Large's Site
Re: Remove images from Quotes
« Reply #46 on: January 30, 2014, 10:08:07 AM »
Glad you got it working. It's common for mods to add text code to the end of that file so my best guess is that another mod added text to the end and somehow corrupted the file.
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Offline Steve

  • Freak
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 4,500
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Remove images from Quotes
« Reply #47 on: January 30, 2014, 10:25:37 AM »
Well, that was short-lived. It's now not working again. Good grief. I have a lot of mods installed so it could be cumbersome to try and figure out which mod is conflicting. I'll dig some more but if you still want a list I'll give it to you.
Online Manual

Please do not PM me for support.

Offline Steve

  • Freak
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 4,500
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Remove images from Quotes
« Reply #48 on: January 30, 2014, 11:12:27 AM »
I did discover something. I use the dQuoteSelection mod and if there are center tags around the image, it doesn't work. Remove the center tags in the quote and it works fine. :)
Online Manual

Please do not PM me for support.

Offline Chas Large

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,108
  • Gender: Male
  • Running 2.0.xx on Apache.
    • Chas.Large on Facebook
    • https://www.linkedin.com/in/charles-large-568ba213 on LinkedIn
    • @https://twitter.com/ on Twitter
    • Chas Large's Site
Re: Remove images from Quotes
« Reply #49 on: January 30, 2014, 03:19:56 PM »
Yes, that would do it. My mod is very simple and to make it try and look for all possible combinations of BBCode around an image would make it difficult and slow. So it is what it is I'm afraid. Sometimes mods clash and there is little we can do about it given how many mods there are available. It's impossible to test a mod with all other mods.
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Offline Steve

  • Freak
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 4,500
  • Gender: Male
  • I have not yet begun to procrastinate.
Re: Remove images from Quotes
« Reply #50 on: January 30, 2014, 05:53:12 PM »
No worries my friend. It works as advertised and now that I know what's going on, I'm very happy with it. :D
Online Manual

Please do not PM me for support.

Offline TrackMustangsOnline

  • Semi-Newbie
  • *
  • Posts: 78
Re: Remove images from Quotes
« Reply #51 on: September 24, 2014, 12:06:02 AM »
Nice mod, thanks!

Offline Antechinus

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 24,841
  • Master of BBC Abuse
Re: Remove images from Quotes
« Reply #52 on: September 24, 2016, 06:43:09 PM »
Hey Chas, would you mind if I nicked some of this code to port it to Elk?

Offline Chas Large

  • SMF Friend
  • SMF Hero
  • *
  • Posts: 3,108
  • Gender: Male
  • Running 2.0.xx on Apache.
    • Chas.Large on Facebook
    • https://www.linkedin.com/in/charles-large-568ba213 on LinkedIn
    • @https://twitter.com/ on Twitter
    • Chas Large's Site
Re: Remove images from Quotes
« Reply #53 on: September 25, 2016, 01:41:39 AM »
Hey Chas, would you mind if I nicked some of this code to port it to Elk?
Sure, with the usual acknowledgements included, go ahead.

What is Elk (other than a big deer)? ;)
My Modifications :)  My Forum

Please DO NOT PM me with support requests. Post the problem in the appropriate Support Board so everyone can benefit from the advice given.

Offline Antechinus

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 24,841
  • Master of BBC Abuse
Re: Remove images from Quotes
« Reply #54 on: September 25, 2016, 02:19:42 AM »
Thanks.

It's forum software. Forked from SMF 2.1 Alpha ages ago. ;)