News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Some basic patches for 2.0.x

Started by Antechinus, February 27, 2013, 06:59:46 PM

Previous topic - Next topic

Antechinus

Although it is SMF policy that stable releases will only receive official security patches, it has been decided to offer some fixes for other problems that have become apparent since 2.0.x was originally released.

These fixes will be offered as separate mod packages, for installation via the usual package manager process (of course anyone is free to propose bug fixes at discretion in mods or through the Tips and Tricks board).

Please note that SMF will not be attempting to fix absolutely every minor bug in 2.0.x, and fixes will be offered at the team's discretion.




Two things that are particularly relevant these days are new versions of Internet Explorer, and detection of phones and tablets.

A mod has been packaged to update the browser detection array in Load.php, to enable detecting a broader range of browsers and devices.

This includes detecting versions of Internet Explorer up to the not-yet-released IE11, and correction of the existing $context['browser']['ie_standards_fix'] so that it only targets versions earlier than IE8.

There is also the option of using a $context['browser']['is_mobile'] and $context['browser']['is_tablet'] setting in custom coding, if desired. These two settings cover a useful range of devices and browsers, and there are more specific settings in the main array as well.

The package for updating browsers and device detection is named detectBrowser_update.zip, and is attached to this post.




A second package is also available, named IE9_calendar_fix.zip.

This updates some template and CSS details, which were problematic if IE9 and IE10 detection were enabled with no other changes. The fix has been tested in LTR and RTL languages, and in all currently used versions of IE, Safari, Opera, Firefox and Chrome.

This package also includes a minor CSS fix for anyone who uses the sidebar menu option on a narrow screen.

emanuele

Sneaked this in. :P

Thanks for putting this fix together. ;)


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

vbgamer45

Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Antes


4Kstore

Thanks for this... I will translate this and post in spanish board.

¡¡NEW MOD: Sparkles User Names!!!

maxg

Yes thanks!
great deal :) good looking out!

Regards,
maxx

Antechinus

Basic CSS fix for a minor bug in Chrome - 2.0.x category header text mis-aligning when expand/collapsing.

Quote from: Antechinus on June 07, 2013, 08:27:05 PM
Ok, solution. In index.css find:

/* Styles for rounded headers.
------------------------------------------------------- */
h3.catbg, h3.catbg2, h3.titlebg, h4.titlebg, h4.catbg
{
overflow: hidden;
height: 31px;
line-height: 31px;
font-size: 1.2em;
font-weight: bold;
}
h3.catbg a:link, h3.catbg a:visited, h4.catbg a:link, h4.catbg a:visited, h3.catbg, .table_list tbody.header td, .table_list tbody.header td a
{
color: #fff;
}


Add after:
h3.catbg a:link, h3.catbg a:visited
{
display: inline-block;
}


Tested in latest FF, Chrome, Opera, IE9 and IE8 emulation and IE7 emulation. Works in all of those. Should be fine in Safari too.

Haven't checked everywhere else in the theme, so if it breaks somewhere else with the added css it will be easy to alter the code to only target the board index. :)

ETA: This should also work in any custom themes that have the same buglet.

dougiefresh

Thanks for these patches!!   Wonder why these didn't make it into the SMF 2.0.5 update....

EDIT: Would love to suggest sticky-ing this topic.....

Oldiesmann

I'm guessing nobody remembered these patches when we were working on things for 2.0.5.
Michael Eshom
Christian Metal Fans

dougiefresh

Did any of these make it into v2.0.6?

EDIT: Nope.... Just looked....  Still left out  :o

Arantor

Sadly not, but I did have like a dozen things to get fixed in 2.0.6 and none of them were aesthetic things.

There are also very serious practical issues with pushing patches out that affect themes for the simple reason that almost everyone is using a custom theme - and it may or may not fix the problem - and may make it much worse.
Holder of controversial views, all of which my own.


dougiefresh

Not trying to sound ungrateful, because I really am grateful....  Didn't think about the effect that these patches might have on non-standard themes....   Thanks again!

Arantor

It's all good :) Just patching is a tricky business ;)

Unless it's a legitimate issue a template itself (like 2.0.6's Help.template.php fix), the odds are pretty firmly that we'll leave it alone to avoid breakage - that way, anyone who does want it fixed can get it fixed and we can deal with the issues case-by-case if they arise.
Holder of controversial views, all of which my own.


emanuele

Yep, though that one is not only a template thing: the "main fix" is browser (IE in particular) detection that fixes an accessibility issue (i.e. sounds (in captcha) are not played in IE >...8 I think, don't remember exactly). This fix causes a template issue in the calendar. That is an example of how tricky patching is, and how tricky support many things is. :)


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Arantor

Ah, I missed that in amidst all the other stuff that had to be fixed >_<
Holder of controversial views, all of which my own.


emanuele

* emanuele is here to remember what shall not be forgot. (Or something like that LOL)


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Arantor

It's not quite November 5th when we can not forget the Gunpowder Plot ;)
Holder of controversial views, all of which my own.


Chainy

Does anyone know if the patch by Antechinus (detectBrowser_update.zip, listed in the first post here) is safe to use with SMF 2.0.6?

I've noticed that WYSIWYG (rich text editing) doesn't currently work with Internet Explorer 11 in Windows 8 (with SMF 2.0.6). A pop-up message indicates that it's not possible. Apparently this is due to a problem with browser detection.

Thank you for any help.

Antechinus

Should be safe, although I haven't actually tried it. All it's doing is allowing more browsers to be detected. In theory you should be able to add as many to the array as you like.

digger

Quote from: Chainy on November 09, 2013, 08:47:24 PM
I've noticed that WYSIWYG (rich text editing) doesn't currently work with Internet Explorer 11 in Windows 8 (with SMF 2.0.6). A pop-up message indicates that it's not possible. Apparently this is due to a problem with browser detection.
IE11 doesn't contain MSIE in user agent string and not detected as known IE browser.

Advertisement: