undefined index questions

[DarkAngel612]

over the last couple of days I have been noticing that we are getting quite a lot of these errors in the error log.

these are just a couple:

Code Select Expand

Error :
action=admin;area=manageboards;sa=board2
8: Undefined variable: board_id
File: /attic/Sources/Subs-Boards.php
Line: 754


Code:   
logAction('edit_board', array('board' => $board_id), 'admin');

Code Select Expand

action=pm;sa=send;f=inbox;pmsg=26305;quote;u=362
Apply Filter: Only show the errors with the same message
8: Undefined index: float_right
File: /attic/Sources/Subs-Editor.php
Line: 1580

this and the float_left are in the templates/default/languages/modifications.english.php

there are a whole lot more and I was wondering...the things like float_right and float_left (float right/left mod), the board_id  are in the modifications.english.php file

do they also need to be written into the english.index.php file also?

The board_id error pops up when someone clicks the mark as read button and today when I was trying to modify a board, which by the way I had to go to the database to get the changes to stay in effect. Moving board was no problem just editing the information of the board itself (I have a banner in the board description and it totally disappeared even if the code was in there. I had to go to the database for that board, revoe the text for the banner and then enter the code exactly as before for it to take effect.

Nothing new has been added nor changed in ages except the needed upgrade to 2.0.5 from 2.0.4

[DarkAngel612]

Sorry for bumping this up again but any ideas?

I tried to create a new board just now, it created but when I went to put it as a sub to another category using the modify button I noticed that apart from the name and location...all other info was not ticed like ai had it,

I reticed the info, set it to be child of and chose the parent hit save and it stays put no moving, then I hit modify again and again it appears as though it never was done at all.

Do I have to uninstall then reinstall everything from scratch yet again, makes about the 4th time since getting 2.04 and now this time with 2.05

[kat]

Sorry for missing your original post, DA.

I've got to suspect a problem with a mod, or two, with this one.

Can you tell us which mods you have and, also, attach both Subs-Boards.php and Subs-Editor.php so that we can look them over, please?

[DarkAngel612]

Sorry for missing your original post, DA.

I've got to suspect a problem with a mod, or two, with this one.

Can you tell us which mods you have and, also, attach both Subs-Boards.php and Subs-Editor.php so that we can look them over, please?

I just figured all were busy with holiday and RL so was going to bite the bullet and reinstall all from scratch...smf and mods. I have attached the mods listing showing versions and all. They are the same ones I have had with 2.02 til now and this did not start until 2.0.5 update via the admin panel.

I usually do not do the updates via admin panel link cause one time it did not work right and repair settings file did not help...it did not change the database to the proper version and it rebelled on me. I was going to go through the database to see if that was the case before attempting the upgrade.php stuff before any uninstalling and uploading files.

Of course this will also mean having to go through all mod files to ensure they have no line after the closing tag

[kat]

Well, the float BBCode mod's a favourite for that second error. As the error's about an undefined index, I would assume that the part of the install that creates the index did a fart.

Maybe uninstall it and reinstall it? (Read my sig, first, for obvious reasons)

That first one's gonna need some looking at, coz line 574 of Subs-Boards is this:

Code Select Expand

SET board_order = board_order + {int:new_order}

No mention of board_id. Although, it does appear in 579...

As I'm about to hit the hay, it'd probably be better for me not to start investigating, until the morning, in case it gets a bit involved.

'course, if someone else can help, in the meantime, all well and good!

[Shambles]

You have a missing } on line 758 of Subs-Boards.php

[DarkAngel612]

aha, ok will add the missing character, Shambles (love your username)

then will post back with results giving K@ plenty of time for some snoozing.

thanks to both of you


I did look at the database and the only thing I saw was that this one in smf_settings still claims to be 2.0.4 NOT .5 like the others are showing, can I maually change it and get it to acknowledge the change or should I use the updae.php files?

[DarkAngel612]

@Shambles

I added the } here to make it look like the original:

if (empty($boardOptions[dont_log]))
  logAction('edit_board', array('board'=> $board_id, 'admin');
}

and got this error: Parse error:  syntax error, unexpected '}' in /home/thefanta/public_html/attic/Sources/Subs-Boards.php on line 756

did I put it in the wrong place should it go  after  global $boards line?

to K@ -- ine is 754 NOT 574 I transpose a lot myself

[DarkAngel612]

sorry for so many replies from me but I did it, I did it....doing happy dance can ya tell

using my handy dandy compare program called text wrangler, I went looking to see what mod may have done something---using both your suggestions.

I found that the facebook sharer mod decided to add a "}" in front of //Set the theme for this board and removed it from where I mentioned I put the "}" earlier.

I then removed the one and added it to the end of that code section and am able to do my thang back there with boards in any theme.

Thanks for your help so now i don't have to do the whole upload, uninstall and install bit

But the database still claims to be 2.0.4 in the smf_settings, should I manually change ( the admin info table shows all 2.0.5 there) or should I run the updater.php files

[Arantor]

You should ignore that part of the error message. There are no database changes between 2.0.4 and 2.0.5. Running the update.php isn't going to change that fact.

[Shambles]

and got this error: Parse error:  syntax error, unexpected '}' in /home/thefanta/public_html/attic/Sources/Subs-Boards.php on line 756

Ok. Looks like your Facebook mod went awry.

At or around line 605

Code (Find) Select Expand




} // Set the theme for this board.

// Enable or disable the Facebook Sharer functionality in any board.

Code (Replace) Select Expand




// Set the theme for this board.

// Enable or disable the Facebook Sharer functionality in any board.


BUT LEAVE IN the } I advised you to insert earlier.

[DarkAngel612]

and got this error: Parse error:  syntax error, unexpected '}' in /home/thefanta/public_html/attic/Sources/Subs-Boards.php on line 756

Ok. Looks like your Facebook mod went awry.

At or around line 605

Code (Find) Select Expand



   
   }   // Set the theme for this board.
   
   // Enable or disable the Facebook Sharer functionality in any board.

Code (Replace) Select Expand



   
   // Set the theme for this board.
   
   // Enable or disable the Facebook Sharer functionality in any board.


BUT LEAVE IN the } I advised you to insert earlier.

yup I removed it from there and put it at the end of that code section and the place behaves again.

You should ignore that part of the error message. There are no database changes between 2.0.4 and 2.0.5. Running the update.php isn't going to change that fact.

OK, then I won't worry about it...funy though the other forums are sporting 2.0.5 in smf_settings and they were done at the same time via admin link too. Although it does not surprise me since day one the forums do their own thing...LOL

Thanks for the help

[Shambles]

yup I removed it from there and put it at the end of that code section and the place behaves again.

How about your other error?

Code Select Expand

action=pm;sa=send;f=inbox;pmsg=26305;quote;u=362
Apply Filter: Only show the errors with the same message
8: Undefined index: float_right
File: /attic/Sources/Subs-Editor.php
Line: 1580

this and the float_left are in the templates/default/languages/modifications.english.php

Does that persist?

[DarkAngel612]

I was so happy I forgot to look at error logs...will check later this eve and let you know, right now cooking supper

[DarkAngel612]

Well they seem to be at bay for now, I cleared the logs for most were user errors (banned trying to get in or spambots trying to get access) and when I looked prior to removing log there were some undefined errors but today I checked and none, just them naughty ones trying to get into forum...lol

will check again in a few days to see if any then either hope they are gone or come back when they come back.

thanks