• Welcome to Simple Machines Community Forum. Please login or sign up.
January 20, 2022, 04:21:30 AM

News:

SMF 2.1 RC4 has been released! Try it out and help us test! :) Read more.


Editing someone else's post

Started by Arantor, September 03, 2013, 07:24:19 PM

Previous topic - Next topic

Arantor

September 03, 2013, 07:24:19 PM Last Edit: November 10, 2013, 05:41:03 PM by Arantor
There is a person around here that I have bawled at for editing my posts when they meant to press the quote button. (Accidentally, yeah, it happens. But repeatedly? It shouldn't happen.)

Anyway, when it last happened, I suggested a solution: if you're editing someone else's post, put a banner above the post editor to show that you're editing someone else's post rather than quoting, in the hopes that someone would notice it.
No good deed goes unpunished
All helpful urges should be circumvented

kat

Done it, myself.

Might even be good to have an "Are you sure you want..." popup...

Suki

I implemented that option or a similar one, but I always thought it was somehow isolated, it felt that I was adding code for a single purpose and that it couldn't be used for anything else. I end up creating a small layer system but it was still pretty limited.

I thought about putting a PR for it but my code felt pretty much like a patch or just adding some code on top of another rather than felt like been part of the whole system.

Ultimately, I know I will end up re-writing the whole template system to either increment the layer system or at least add hotspots to "hook" code to it.

As for the quote / edit button, I prob would separate them, make them different from each other, maybe use a different combination of color for different buttons, associating a specific color to a specific action does wonders with people that somehow have problems with very similar options. Sadly, colors are traditionally left for themers which of course could simply decide to ignore the color combination.

And also I would put the delete button far away from the rest.
Disclaimer: unless otherwise stated, all my posts are personal and does not represent any views or opinions held by Simple Machines.

Making tough decisions, so you don't have to.

Arantor

It really doesn't need to be a layer, it just needs to be a single echo statement, nothing more. At least in SMF's structure.

QuoteUltimately, I know I will end up re-writing the whole template system to either increment the layer system or at least add hotspots to "hook" code to it.

Do it. It needs it. The entire structure of SMF being monolithic templates is very bad. Make every content unit a template and display a list of them and then this becomes a template block too.

Using colour for splitting actions is usually bad, because pure colour recognition doesn't work for colour blindness, but sticking different icons works there.

It's also fine for the core thing to be changed up by themers. I'm advocating what I believe the core should do.
No good deed goes unpunished
All helpful urges should be circumvented

kat


Antechinus

You do realise that the 2.1 theme buttons were deliberately redesigned to get around this whole edit-instead-of-quote problem? I've been talking about it for years, which is why I decided to do something about it as soon as I was able to.

Applying similar changes to 2.0.x themes would be equally easy. TBH I'm not sure why nobody does it.

Arantor

Huh, I didn't actually look at that in 2.1 yet.

I did, however, notice that main posting buttons were reversed in order, icky icky icky forcing muscle relearning like that.
No good deed goes unpunished
All helpful urges should be circumvented

emanuele

Quote from: Arantor on September 05, 2013, 06:35:21 PM
I did, however, notice that main posting buttons were reversed in order, icky icky icky forcing muscle relearning like that.
Tab is the way! :P


Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Antechinus

Quote from: Arantor on September 05, 2013, 06:35:21 PM
Huh, I didn't actually look at that in 2.1 yet.

I did, however, notice that main posting buttons were reversed in order, icky icky icky forcing muscle relearning like that.

I didn't do that bit. That was someone else.

emanuele



Take a peek at what I'm doing! ;D




Hai bisogno di supporto in Italiano?

Aiutateci ad aiutarvi: spiegate bene il vostro problema: no, "non funziona" non è una spiegazione!!
1) Cosa fai,
2) cosa ti aspetti,
3) cosa ottieni.

Spuds

QuoteI didn't do that bit. That was someone else.
Since when were you afraid to throw anyone under the bus ... hell that was me  :P   Bwahhhhhahahahah, move da buttons, bwahhhahhahah

Arantor

I don't really care who did, just someone please fix it!
No good deed goes unpunished
All helpful urges should be circumvented

Arantor

So anyway, the main issue about posts getting edited unnecessarily has been rectified by way of making full edit (which looks the same as full post) harder to get at by accident.

I'm moving this to solved, as a result.
No good deed goes unpunished
All helpful urges should be circumvented

Advertisement: