Search Sent Personal Messages (PMs)

[GigaWatt]

However, providing the instructions on WHAT to update in the mod is perfectly allowed....

Well... of course it is . I don't see an issue in that, some members have been doing that in support threads of abandoned mods .

[GL700Wing]

Discovered when I was attempting to fix something (the pagination seems to be broken).

The pagination issue is caused by the value of the folder to search being reset to '1' (ie, inbox) when there is more than one page of results and you click on the page index link for the second or subsequent pages.

I've just worked out a fix for this using a session variable - the variable is unset when the 'Search Messages' window is displayed and it's set when the search button is clicked (at this point the folder to search has been selected).

In ./Sources/PersonalMessage.php
Find:

Code Select Expand

// !!! For the moment force the folder to the inbox.
$folder = (int) (isset($_REQUEST['search_what']) ? $_REQUEST['search_what'] : 1);
$context['folder'] = ($folder == 1 ? 'inbox' : (!isset($context['sup_folder']) || $folder == 2 ? 'sent' : 'unread'));
Replace With:

Code Select Expand

// !!! For the moment force the folder to the inbox.
if (!isset($_SESSION['pm_search_folder']))
{
$folder = (int) (isset($_REQUEST['search_what']) ? $_REQUEST['search_what'] : 1);
$context['folder'] = ($folder == 1 ? 'inbox' : (!isset($context['sup_folder']) || $folder == 2 ? 'sent' : 'unread'));
}
else
$context['folder'] = $_SESSION['pm_search_folder'];

In ./Themes/default/PersonalMessage.template.php
Find:

Code Select Expand

function template_search()
{
global $context, $settings, $options, $scripturl, $modSettings, $txt;
Add After:

Code Select Expand

// Unset the session variable for pm folder name.
unset($_SESSION['pm_search_folder']);

[GL700Wing]

The pagination issue is caused by the value of the folder to search being reset to '1' (ie, inbox) when there is more than one page of results and you click on the page index link for the second or subsequent pages.

I've just worked out a fix for this using a session variable - the variable is unset when the 'Search Messages' window is displayed and it's set when the search button is clicked (at this point the folder to search has been selected).

And I just worked out a much simper fix which also seems to work ...

In ./Sources/PersonalMessage.php
Find:

Code Select Expand

// !!! For the moment force the folder to the inbox.
$folder = (int) (isset($_REQUEST['search_what']) ? $_REQUEST['search_what'] : 1);
$context['folder'] = ($folder == 1 ? 'inbox' : (!isset($context['sup_folder']) || $folder == 2 ? 'sent' : 'unread'));
Replace With:

Code Select Expand

if (isset($_REQUEST['search_what']))
{
$folder = (int) ($_REQUEST['search_what']);
$context['folder'] = ($folder == 1 ? 'inbox' : (!isset($context['sup_folder']) || $folder == 2 ? 'sent' : 'unread'));
};

[James Gryphon]

@GL700Wing: Unfortunately I didn't have any luck with the most recent PersonalMessage.php fix, but the first and complex one seems to work fine; congrats!

I also haven't run into the count error, so I'm hoping that the problem was related to that and now the mod is in good shape.

[GL700Wing]

@GL700Wing: Unfortunately I didn't have any luck with the most recent PersonalMessage.php fix, but the first and complex one seems to work fine; congrats!

I also haven't run into the count error, so I'm hoping that the problem was related to that and now the mod is in good shape.

Glad one of them worked!