Search "This board" don't work

[ioofen]

After I installed a lot of mod, The Search "This board" don't work , do my best skill ,i edited code "name=sd_brd[]" to "name=sd_brd"  in " index.template", then it work again.

but i know this way is no good, someone know what is my mistake for that? Thank you ~

[Illori]

http://www.simplemachines.org/community/index.php?topic=538362.0 does not look like it has been tracked down yet.

[ioofen]

http://www.simplemachines.org/community/index.php?topic=538362.0 does not look like it has been tracked down yet.

ok ,thank you for your help.

[Oldiesmann]

Do you have a search index set up? If so, what type? I just tried this on my test board and it worked as expected, finding the search result in both the subjects and the posts themselves.

Also, the line you mentioned in index.template.php should be this:

Code Select Expand

<input type="hidden" name="sd_brd[', $context['current_board'], ']" value="', $context['current_board'], '">

[margarett]

IIRC it only searches the first board, no matter in which board you're in.

Dang I forgot to properly trace that at the time

[Oldiesmann]

Looking into this further I see what's going on:

In index.template.php we're sending sd_brd as an array:

Code Select Expand

// If we're on a certain board, limit it to this board ;).
elseif (!empty($context['current_board']))
echo '
<input type="hidden" name="sd_brd[', $context['current_board'], ']" value="', $context['current_board'], '">';

Search.php isn't expecting this and converts the value to an array again. We then loop through the values of $_REQUEST['brd'] and make sure each is an int. Using (int) with an array in PHP will result in a value of 1 if the array isn't empty, so it will always search board 1 regardless. The fix is to change sd_brd[', $context['current_board'], '] in index.template.php to just sd_brd as described above.

[ioofen]

Looking into this further I see what's going on:

In index.template.php we're sending sd_brd as an array:

Code Select Expand

// If we're on a certain board, limit it to this board ;).
elseif (!empty($context['current_board']))
echo '
<input type="hidden" name="sd_brd[', $context['current_board'], ']" value="', $context['current_board'], '">';

Search.php isn't expecting this and converts the value to an array again. We then loop through the values of $_REQUEST['brd'] and make sure each is an int. Using (int) with an array in PHP will result in a value of 1 if the array isn't empty, so it will always search board 1 regardless. The fix is to change sd_brd[', $context['current_board'], '] in index.template.php to just sd_brd as described above.

OK~ Thank for your Confirm.