Advertisement:

Author Topic: Separate Unread PMs  (Read 5680 times)

Offline chrishicks

  • Full Member
  • ***
  • Posts: 511
  • Gender: Male
    • RejectsRestStop
Re: Separate Unread PMs
« Reply #20 on: March 31, 2017, 09:48:12 AM »
Ok, I decided to just take a whirl at installing both this and Separate Unread PMs with installing this one first. This mod seemed to install just fine but I didn't send/retrieve/fully test but there were no errors in the logs when at least visiting my PM box. There were 2 "errors" that were ignored but they weren't flagged as a "don't install this mod!!" kind of flag. Looking at the code shown I'm guessing it is related to the attachments mod so I just ran with it.

My issue came when I installed the Separate mod next. Again there were no errors during install but I completely lost access to my Inbox. The link was still there but when clicking it I just got stuck in Sent. Outbox was just a clone of Sent as well. I also lost 1 sent message that was unread. It was just gone because Outbox was mirroring Sent. I start looking at the edits and all seemed alright but since I was getting pressed for time I decided to just uninstall it and mess with it another time. When I went to uninstall however it failed telling me there were errors. I didn't do any other installs between installing and uninstalling so I just opened up that file in my browser and found the failed edit and I didn't see an issue as to why it would fail. It was exactly the same that the uninstall was calling for. I just went ahead with removing it and then made that manual change afterwards.

I head back to my PM box and I still don't have access to my inbox. The Outbox is gone but I'm stuck in Sent no matter what I try. I go ahead and uninstall the Edit mod and everything is back to normal or at least looks that way. Now through this entire time there was never a single error in the log and everything appears to be working just as it was prior to installing the 2 mods so I'm not sure what went wrong but for me something did somewhere but when I have a good few hours to mess around with it I'll try installing them both again and see what happens. Worse case I break something and I just have to upload the original files from a backup which I almost thought I was going to be doing yesterday after that first failure during uninstall. 

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,671
  • Mod King
    • XPtsp.com Community
Re: Separate Unread PMs
« Reply #21 on: March 31, 2017, 10:03:14 AM »
Ok, I decided to just take a whirl at installing both this and Separate Unread PMs with installing this one first.
I'm going to assume you intended to post in the Search Sent PM mod thread, since you posted in the Separate Unread PMs mod thread....

This mod seemed to install just fine but I didn't send/retrieve/fully test but there were no errors in the logs when at least visiting my PM box. There were 2 "errors" that were ignored but they weren't flagged as a "don't install this mod!!" kind of flag. Looking at the code shown I'm guessing it is related to the attachments mod so I just ran with it.

My issue came when I installed the Separate mod next. Again there were no errors during install but I completely lost access to my Inbox. The link was still there but when clicking it I just got stuck in Sent. Outbox was just a clone of Sent as well. I also lost 1 sent message that was unread. It was just gone because Outbox was mirroring Sent. I start looking at the edits and all seemed alright but since I was getting pressed for time I decided to just uninstall it and mess with it another time. When I went to uninstall however it failed telling me there were errors. I didn't do any other installs between installing and uninstalling so I just opened up that file in my browser and found the failed edit and I didn't see an issue as to why it would fail. It was exactly the same that the uninstall was calling for. I just went ahead with removing it and then made that manual change afterwards.

I head back to my PM box and I still don't have access to my inbox. The Outbox is gone but I'm stuck in Sent no matter what I try. I go ahead and uninstall the Edit mod and everything is back to normal or at least looks that way. Now through this entire time there was never a single error in the log and everything appears to be working just as it was prior to installing the 2 mods so I'm not sure what went wrong but for me something did somewhere but when I have a good few hours to mess around with it I'll try installing them both again and see what happens. Worse case I break something and I just have to upload the original files from a backup which I almost thought I was going to be doing yesterday after that first failure during uninstall. 
Attach your PersonalMessage.php and I'll try to fix it.....

EDIT:  I can confirm that the Separate Unread PMs mod is not the culprit here.  The Separate Unread PMs mod and the Search Sent PMs mod are not compatible with each other at this moment.  I am working to resolve this issue....
« Last Edit: March 31, 2017, 10:32:31 AM by dougiefresh »
News: Missing GitHub repository...

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline chrishicks

  • Full Member
  • ***
  • Posts: 511
  • Gender: Male
    • RejectsRestStop
Re: Separate Unread PMs
« Reply #22 on: March 31, 2017, 04:45:55 PM »
Ok, I decided to just take a whirl at installing both this and Separate Unread PMs with installing this one first.
I'm going to assume you intended to post in the Search Sent PM mod thread, since you posted in the Separate Unread PMs mod thread....


Whoops. I was talking about the Edit Unread PMs and this mod. I got the 2 topics/mods mixed up so I can see where it was pretty confusing. Sorry about that. I never attempted to install the Search PMs yet.

Let me try this again. I installed Edit Unread PMs first and everything was fine. No errors in logs, etc. however I didn't actually test to see if things worked 100%. I never really have with any of your mods because they always just worked for me. I did have the newly added links(edit/unsend) so I figured everything was fine. I hit the logs again and still no errors after navigating around my PM box.

Then I installed this mod(Separate Unread PMs). That's where things went bad and is what I was talking about in my post above. Once Separate Unread PMs was installed I lost access to my inbox. I would click it and would just stay stuck in my sent folder. The outbox folder was exactly the same. I had 2 sent but unread messages and those were both just gone. They weren't in sent or in outbox. I started checking the code edits one by one but decided to uninstall for the time being and that's when it errored out. I manually made the change for the error(it was only one) and carried on. Went back to my inbox and I still couldn't access it. It was the same as it was with Separate Unread PMs installed. I go ahead and uninstall Edit Unread and everything is back to normal.

I didn't get any errors for either mod during install other than the aforementioned 2 that seemed related to the Post and PM Attachments mod which said ignore error when I installed Edit Unread PMs. My installation was pretty much:

1. install Edit Unread PMs
2. navigate PM box - both inbox/sent work
3. check for errors after
4. install Separate Unread PMs
5. go to inbox and can't get it
6. check for errors and see none
7. decide to uninstall Separate Unread and get an error
8. proceed and manually fix error after
9. inbox still broken
10. no errors in logs at all
11. uninstall Edit Unread PMs
12. everything works again


Offline zorer

  • Semi-Newbie
  • *
  • Posts: 14
Re: Separate Unread PMs
« Reply #23 on: June 14, 2017, 01:45:58 PM »
Hi! i installed this mod in a smf 2.0.14 and works great, anyway is possible to add this feature?

Actually we have this:
Outbox when you click then you see the msgs to send

What about this?
OutBox(2) >Number of msg ready to read

Phpbb PM uses this way

Thanks!

Online GL700Wing

  • Jr. Member
  • **
  • Posts: 366
  • Gender: Female
Re: Separate Unread PMs
« Reply #24 on: June 15, 2017, 10:46:24 PM »
I've just discovered an issue with this mod - it references a column in the personal_messages table that doesn't exist - error message is:
Database Error: Unknown column 'pmr.is_read' in 'where clause'

SELECT COUNT(*)
FROM smf_personal_messages
WHERE id_member_from = 2252
AND deleted_by_sender = 0
AND pmr.is_read > 0
AND id_pm > 73783
File: ./Sources/PersonalMessage.php
Line: 595


I've confirmed that the current mod installation does not create this column so to address the issue I've manually added a column to the personal_messages table with the following attributes:
name = is_read
type = tinyint
size = 3
unsigned = true
default = 0

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,671
  • Mod King
    • XPtsp.com Community
Re: Separate Unread PMs
« Reply #25 on: July 05, 2017, 02:15:30 PM »
Uploaded v1.4 - July 5th, 2017
o Fixed database query error in Sources\PersonalMessages.php.  Thanks, GL700Wing!!!



@GL700Wing:  This update should take care of the bug report you reported!  Thanks again!
News: Missing GitHub repository...

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,671
  • Mod King
    • XPtsp.com Community
Re: Separate Unread PMs
« Reply #26 on: July 07, 2017, 11:15:36 PM »
Uploaded v1.5 - July 7th, 2017
o Added support for SMF 2.1 Beta 3.
o Removed support for SMF 2.1 Beta 2.
News: Missing GitHub repository...

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,671
  • Mod King
    • XPtsp.com Community
Re: Separate Unread PMs
« Reply #27 on: August 04, 2017, 02:24:50 PM »
Uploaded v1.6 - August 4th, 2017
o Made changes for compatibilty with Search Sent PMs.
News: Missing GitHub repository...

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline TheEngineer

  • Semi-Newbie
  • *
  • Posts: 42
Re: Separate Unread PMs
« Reply #28 on: January 11, 2018, 08:07:13 AM »
Good morning! 

In my upgrade from a (very) outdated version of SMF to 2.0.15, I needed to remove Enhanced PM System.  This appears to provide most of the functionality we loved about the old mod.  I'm getting an error when trying to install the mod though:

Code: [Select]
Code: (Find) [Select]
WHERE ' . ($context['folder'] == 'sent' ? 'pm.id_member_from = {raw:current_member}

Code: (Replace) [Select]
WHERE ' . ($context['sup_folder'] ? 'pm.id_member_from = {raw:current_member}
AND pmr.is_read ' . ($context['folder'] == 'sent' ? '>' : '=') . '0

Could you please advise?  Thanks!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,671
  • Mod King
    • XPtsp.com Community
Re: Separate Unread PMs
« Reply #29 on: January 11, 2018, 10:16:33 AM »
Uploaded v1.7 - January 11th, 2018
o Added support for SMF 2.0.15.



@TheEngineer:  This update should resolve the install problem with SMF 2.0.15.  Thank you for reporting this bug!
News: Missing GitHub repository...

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!

Offline TheEngineer

  • Semi-Newbie
  • *
  • Posts: 42
Re: Separate Unread PMs
« Reply #30 on: January 11, 2018, 12:37:29 PM »
That fixed it.  Thanks!

Offline Rock Lee

  • SMF Hero
  • ******
  • Posts: 1,486
  • Gender: Male
  • Digitalizando un nuevo mundo :D
    • BomberCode.Oficial on Facebook
    • RockLee-BC on GitHub
    • @Bomber_Code on Twitter
    • Bomber Code ~ La nueva era del conocimiento
Re: Separate Unread PMs
« Reply #31 on: February 21, 2018, 03:44:45 PM »
I think I have to approach the branch 2.1 to be able to follow the step :P I hope it serves you.


Regards!
¡Regresando como cual Fenix! ~ Bomber Code © 2018
Ayudas - Aportes - Tutoriales - Y mucho mas!!!

Offline dougiefresh

  • SMF Hero
  • ******
  • Posts: 2,671
  • Mod King
    • XPtsp.com Community
Re: Separate Unread PMs
« Reply #32 on: February 21, 2018, 08:00:08 PM »
Uploaded v1.8 - February 21th, 2018
o Added Spanish Latin translation by Rock Lee.



@Rock Lee:  Thanks for the translation!  It's been included in this version!
News: Missing GitHub repository...

My Free Simple Machines mods on XPtsp.com, Simple Machines Customization Site, and at GitHub!
Problem uninstalling mods?  Try Arantor's Sortable Packages (and Installed Time) mod!  It's super helpful!