Advertisement:
« previous next »
Pages: [1]   Go Down

Author Topic: [2.0] [2.1] Emoji break preview  (Read 3018 times)

Offline Arskrigitsioniets

  • Semi-Newbie
  • *
  • Posts: 78
[2.0] [2.1] Emoji break preview
« on: December 17, 2018, 06:55:33 AM »
Emojis like this 😄 break preview on 2.0 and on 2.1.
« Last Edit: March 01, 2019, 04:08:29 PM by Gwenwyfar »
Logged

Offline Gwenwyfar

  • Great Wizard's familiar
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 2,286
  • Gender: Female
Re: [2.0] [2.1] Emoji break preview
« Reply #1 on: December 17, 2018, 07:04:33 AM »
Are you using Beta 3 or the latest github version?
Logged
What is real?

Online Bigguy

  • SMF Friend
  • SMF Super Hero
  • *
  • Posts: 13,001
  • Gender: Male
  • Be nice, or else....
    • smfbigguy on GitHub
    • What's Ur Beef
Re: [2.0] [2.1] Emoji break preview
« Reply #2 on: December 17, 2018, 07:10:01 AM »
This works fine on my site.
Logged

Offline Arskrigitsioniets

  • Semi-Newbie
  • *
  • Posts: 78
Re: [2.0] [2.1] Emoji break preview
« Reply #3 on: December 17, 2018, 07:59:13 AM »
Quote from: Gwenwyfar on December 17, 2018, 07:04:33 AM
Are you using Beta 3 or the latest github version?
I tried beta 3 that is installed on Russian smf support forum: https://www.simplemachines.ru.

And I myself use 2.0.15 version on my forum форум.стратегикон.рф and I see the same problem.
Logged

Offline Kindred

  • The Mean One
  • Support Specialist
  • SMF Legend
  • *
  • Posts: 58,939
  • Gender: Male
    • Kindred-999 on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #4 on: December 17, 2018, 09:37:08 AM »
hmmmm... looks like he's inserting emoji emojis - not a smiley from the server...
Logged
Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

Offline Gwenwyfar

  • Great Wizard's familiar
  • SMF Friend
  • SMF Hero
  • *
  • Posts: 2,286
  • Gender: Female
Re: [2.0] [2.1] Emoji break preview
« Reply #5 on: December 17, 2018, 10:00:00 AM »
It might have been fixed already. Try the latest version.
Logged
What is real?

Offline Arskrigitsioniets

  • Semi-Newbie
  • *
  • Posts: 78
Re: [2.0] [2.1] Emoji break preview
« Reply #6 on: December 17, 2018, 10:16:51 AM »
Quote from: Gwenwyfar on December 17, 2018, 10:00:00 AM
It might have been fixed already. Try the latest version.
I'm too lazy to install it  :D If you have free time, just try it on your version in development.

Quote
hmmmm... looks like he's inserting emoji emojis - not a smiley from the server...
Yes, the problem is exactly with emoji emojis.

Like this: 😄. You can copy it by cntrl+c and insert as a text.
Logged

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,980
    • StoryBB/StoryBB on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #7 on: December 17, 2018, 11:33:07 AM »
The comedy is that this will almost certainly be two completely different bugs depending on 2.1 configuration.
Logged
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Sesquipedalian

  • The Mad Doctor
  • Lead Developer
  • Sophist Member
  • *
  • Posts: 1,079
  • Gender: Male
  • It works! ... in theory.
    • Sesquipedalian on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #8 on: December 17, 2018, 07:23:30 PM »
This was fixed in SMF 2.1 in pull request #4059 on May 17, 2017, and I just did a preview of this post right now, which demonstrated clearly to me that it has also already been fixed in SMF 2.0. 😉 Please upgrade to the latest versions.
Logged
I promise you nothing.
Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Offline Arskrigitsioniets

  • Semi-Newbie
  • *
  • Posts: 78
Re: [2.0] [2.1] Emoji break preview
« Reply #9 on: December 18, 2018, 02:49:25 AM »
Quote
This was fixed in SMF 2.1 in pull request #4059 on May 17, 2017, and I just did a preview of this post right now, which demonstrated clearly to me that it has also already been fixed in SMF 2.0. 😉 Please upgrade to the latest versions.
If you speak that you have already fixed it on 2.0, why do I right now do a preview and see this? For some reasons, I can't attach an attachment to this post now, so this is a screenshot:


Also on my forum 2.0.15 форум.стратегикон.рф I see the same problem. And on Russian smf community forum 2.1.3 I see the same problem. https://www.simplemachines.ru/index.php
Logged

Offline Sesquipedalian

  • The Mad Doctor
  • Lead Developer
  • Sophist Member
  • *
  • Posts: 1,079
  • Gender: Male
  • It works! ... in theory.
    • Sesquipedalian on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #10 on: December 18, 2018, 03:24:05 AM »
Quote
Also on my forum 2.0.15 форум.стратегикон.рф I see the same problem.
I don't know why it isn't working for you, but I can't reproduce the problem in any of my tests. I've tested again on two other SMF 2.0.15 forums, and previewing a post containing emoji characters works in both cases.

Quote
And on Russian smf community forum 2.1.3 I see the same problem. https://www.simplemachines.ru/index.php
That forum is using a version of SMF 2.1 Beta 3 from before the bug was fixed. It needs to be updated.
Logged
I promise you nothing.
Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Offline Sesquipedalian

  • The Mad Doctor
  • Lead Developer
  • Sophist Member
  • *
  • Posts: 1,079
  • Gender: Male
  • It works! ... in theory.
    • Sesquipedalian on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #11 on: December 18, 2018, 03:39:11 AM »
Is your 2.0.15 forum using Unicode character encoding, known as UTF-8? If not, that might be causing you problems. Emoji characters only work properly with Unicode.
Logged
I promise you nothing.
Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,980
    • StoryBB/StoryBB on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #12 on: December 18, 2018, 03:49:16 AM »
Is that preview from quick reply or preview from full editor? I have long suspected the latter as mangling submissions with emoji.
Logged
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Arskrigitsioniets

  • Semi-Newbie
  • *
  • Posts: 78
Re: [2.0] [2.1] Emoji break preview
« Reply #13 on: December 18, 2018, 09:29:47 AM »
Quote from: Sesquipedalian on December 18, 2018, 03:39:11 AM
Is your 2.0.15 forum using Unicode character encoding, known as UTF-8? If not, that might be causing you problems. Emoji characters only work properly with Unicode.
Yes, I'm using UTF-8. If I see this bug on this forum as well (www.simplemachines.org), but you speak that you don't have the bug... maybe the problem is in the browser? I use Google Chrome 71.0.3578.98 in the Russian language. I've just installed clear 2.0.15 version and I see the same bug...

Quote
Is that preview from quick reply or preview from full editor? I have long suspected the latter as mangling submissions with emoji.
From full editor.
Logged

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,980
    • StoryBB/StoryBB on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #14 on: December 18, 2018, 09:33:34 AM »
Yeah, I bet the JS chokes on it.
Logged
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Sesquipedalian

  • The Mad Doctor
  • Lead Developer
  • Sophist Member
  • *
  • Posts: 1,079
  • Gender: Male
  • It works! ... in theory.
    • Sesquipedalian on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #15 on: December 18, 2018, 10:22:32 AM »
I was doing my tests from the full editor.

Edit: Never mind. My memory must be failing. Yes, this bug does appear when the preview comes from the full editor, but not from the quick editor.
« Last Edit: December 18, 2018, 10:34:51 AM by Sesquipedalian »
Logged
I promise you nothing.
Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Offline Arantor

  • Resident Overthinker
  • SMF Friend
  • SMF Legend
  • *
  • Posts: 71,980
    • StoryBB/StoryBB on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #16 on: December 18, 2018, 10:31:19 AM »
That’s why I’ve suspected but never proven that it worked properly because ever since I wrote the emoji handling hack, I’ve never been 100% convinced it was 100% reliable... but I could never consistently reproduce it breaking, even when it was just a patch I had locally.
Logged
Don’t try to tell me that some power can corrupt a person. You haven’t had enough to know what it’s like.

No good deed goes unpunished / No act of charity goes unresented.

Offline Sesquipedalian

  • The Mad Doctor
  • Lead Developer
  • Sophist Member
  • *
  • Posts: 1,079
  • Gender: Male
  • It works! ... in theory.
    • Sesquipedalian on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #17 on: December 18, 2018, 10:35:52 AM »
I'm reopening this now that we've figured out how to reproduce it.
Logged
I promise you nothing.
Sesqu... Sesqui... what?
Sesquipedalian, the best word in the English language.

Offline live627

  • Developer
  • SMF Hero
  • *
  • Posts: 5,703
  • Gender: Male
    • live627 on Facebook
    • live627 on GitHub
    • live627 on LinkedIn
    • @live627 on Twitter
    • livemods
Re: [2.0] [2.1] Emoji break preview
« Reply #18 on: December 18, 2018, 07:29:16 PM »
This will be fixed in the upcoming 2.0.16.

Originally reported in SMF 2.0.15 Message Preview failing on emojis
Logged

Offline shawnb61

  • Developer
  • SMF Hero
  • *
  • Posts: 1,907
    • sbulen on GitHub
Re: [2.0] [2.1] Emoji break preview
« Reply #19 on: October 03, 2019, 07:02:47 PM »
This was reported a few times & a fix is targeted for 2.0.16 - I am going to close the dupes & keep one open:
https://www.simplemachines.org/community/index.php?topic=569620.0
Logged
Address the process rather than the outcome.  Then, the outcome becomes more likely.   - Fripp
Pages: [1]   Go Up
« previous next »