[2.1 RC2] Default notification settings

[Massl]

I don't understand if I'm wrong or it's a bug..

I configure notifications from the admin panel


but all new users have empty settings

[Arantor]

Was the user made after you changed the defaults? It won't override existing users choices.

[Massl]

Was the user made after you changed the defaults?

Yes, I also created new test users and I think it's a bug.

[live627]

Do the users have any watched topics?

[live627]

I found the problem.

Code Select Expand

./Register.php:518: setNotifyPrefs($memberID, array('announcements' => (int) !empty($_POST['notify_announcements'])));


Each new registrant gets that alert pref set, and that makes the user settings page retrieve only that single pref, ignoring all the defaults.

[Massl]

Fixed https://github.com/SimpleMachines/SMF2.1/pull/5581
Thank you again 

[live627]