Securiy warnings (such as images)

Started by tdennis, November 22, 2019, 03:11:18 PM

Previous topic - Next topic

tdennis

I just used shawnb61 very helpful topic Converting to https, step-by-step...  (URL : https://www.simplemachines.org/community/index.php?topic=555034.0 ). This solved most of my problems getting my SSL certificate working properly (mostly caused by hard coded URL's).

What I have now is not a major problem but I would like to fix it. When looking at my domain's https padlock is fine but when I change to the forum's I get the padlock with the triangle caution "parts of this page are not secure (such as images).

I know that there are links to images resident on Photobucket and the few that on the few that I tested changing the URL from fttp to fttps caused loss of the image so that's not a solution. I have the server setting "Enable Image Proxy" set to yes but it is not taking care of these un-secure photo URL's.

I have to assume these insecure photo URL's is what is causing the security warning.
Anyone have a solution? Or do I have to leave it that way.
Thanks in advance for any suggestions,
Dennis

Illori

link to your forum where the issue is happening?

tdennis

Here is the URL https://americanlongrifles.org/forum/

But I think it is a moot point, at least for right now. I just discovered that several hundred photos that have been hot linked to are on photobucket with URL's fttp and the images do not display now that I have added SSL to my site.

Evidently when these photos were linked photobucket had no SSL certificate and now that it is a secure site I can change the URL to fttps and get the images to display and hopefully when I get them all changed I will not have the "parts of this page are not secure (such as images)" warning, at least I hope so.

Will make these changes and see what it looks like, I would not doubt that I may have other hot linked images to other insecure sites but will have to fix these and see what's left.
Dennis

Arantor

Or turn on the image proxy to help with this.

tdennis

QuoteOr turn on the image proxy to help with this.
I have had it turned on but didn't seem to help.
Dennis

Illori

that is strange as this is the exact reason why the image proxy was added to SMF.

link to a topic where the issue is happening?

tdennis

#6
I am sorry I am just seeing this request, sickness and Dr appointments!

https://americanlongrifles.org/forum/index.php?topic=25855.0

Here is the way the photos appear in the above topic http://i708.photobucket.com/albums/ww81/ALRLIBRARY/Rains%20BT/btrainsrifle5001_zps4417c2e0.jpg

Note the "http:" and if I change the "http:" to "https:" the photo will display (note I removed the "IMG" BBCode to avoid displaying a blank box!

Right now I am in the process of changing hundreds (thousands?) of these in our online library of antique rifle photos. Its a time consuming job. I had no idea adding SSL would be this labor intensive.
Dennis

Kindred

the warning is because of this:

<CENTER><a href="http://www.americanlongrifles.org/forum/" target="_xblank"><img
src="http://americanlongrifles.org/images/ALR Photos/old_header.png"></a></CENTER><BR>



also, the reason it seems that images are not being displayed, despite the proxy is that the URL is double encoded
http%3A%2F%2Fi708.photobucket.com%2Falbums%2Fww81%2FALRLIBRARY%2FRains%2520BT%2Fbtrainsrifle6_zps7a1de4f3.jpg
converts to
http://i708.photobucket.com/albums/ww81/ALRLIBRARY/Rains%20BT/btrainsrifle6_zps7a1de4f3.jpg
but it should be
http://i708.photobucket.com/albums/ww81/ALRLIBRARY/Rains BT/btrainsrifle6_zps7a1de4f3.jpg

I think that the %250 (which is the double encoded %20 (or space)) is screwing things up
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

tdennis

Thanks Kindred,
Will see if I can resolve this issue. Appreciate the info.
Dennis

tdennis

Kindred,
I hate to be a bother but what is the file name/location of this statement, I feel sure I put it there several years ago but this old 76 year old brain can not find it now!
Dennis

<CENTER><a href="http://www.americanlongrifles.org/forum/" target="_xblank"><img
src="http://americanlongrifles.org/images/ALR Photos/old_header.png"></a></CENTER><BR>


Kindred

Almost certainly in index.template.php
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

tdennis


tdennis

Quote from: Kindred on December 14, 2019, 11:00:45 PM
Almost certainly in index.template.php
I did a search in all index.template.php files (searched for "old_header" and never found the statement:

Quote<CENTER><a href="http://www.americanlongrifles.org/forum/" target="_xblank"><img
src="http://americanlongrifles.org/images/ALR Photos/old_header.png"></a></CENTER><BR>

Any other suggestions? I wish I could search all files for text but it appears I can onle search for file names.
Dennis

Illori

what mods do you have installed? some mods let you add html code in various places, this could be in one of those.

tdennis

Quote from: Illori on December 15, 2019, 04:09:20 PM
what mods do you have installed? some mods let you add html code in various places, this could be in one of those.
That's it, I am such a dumkopf! Sorry to have take up time, I forgot all about adding the Global Headers and Footers Mod. I was positive I had modified a theme to add that photo. All I had to do was change the http: to https: and it took care of the security warning!
Thanks all,
Dennis

tdennis

Quote from: Kindred on December 13, 2019, 01:50:15 PM
the warning is because of this:

<CENTER><a href="http://www.americanlongrifles.org/forum/" target="_xblank"><img
src="http://americanlongrifles.org/images/ALR Photos/old_header.png"></a></CENTER><BR>



also, the reason it seems that images are not being displayed, despite the proxy is that the URL is double encoded
http%3A%2F%2Fi708.photobucket.com%2Falbums%2Fww81%2FALRLIBRARY%2FRains%2520BT%2Fbtrainsrifle6_zps7a1de4f3.jpg
converts to
http://i708.photobucket.com/albums/ww81/ALRLIBRARY/Rains%20BT/btrainsrifle6_zps7a1de4f3.jpg
but it should be
http://i708.photobucket.com/albums/ww81/ALRLIBRARY/Rains BT/btrainsrifle6_zps7a1de4f3.jpg

I think that the %250 (which is the double encoded %20 (or space)) is screwing things up


Kindred,
I took the above two URL's and put them in a post and set them to display as images. Neither URL's would display. Then I took the same two URL's (as you posted) and edited the URL's to read https: instead of http: and BOTH display as they should. They just will not display without the https:

This problem did not exist until I added SSL certificates and yes I do have the image proxy turned on.
Dennis

Kindred

that's because, if the URL is already https, the proxy is not used...

the problem is that the proxy is choking on the space (spaces really are not valid in URLs, and I wish that websites would stop allowing them - replaced them with dash or underscore, not %20.)

the space in "Rains BT" gets converted to Rains%20BT, which then gets double converted to Rains%250BT (which then gets read out as Rains%0BT -- %0B is not a valid character as far as the original URL is concerned
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

tdennis

Quote from: Kindred on December 16, 2019, 03:50:37 PM
that's because, if the URL is already https, the proxy is not used...

the problem is that the proxy is choking on the space (spaces really are not valid in URLs, and I wish that websites would stop allowing them - replaced them with dash or underscore, not %20.)

the space in "Rains BT" gets converted to Rains%20BT, which then gets double converted to Rains%250BT (which then gets read out as Rains%0BT -- %0B is not a valid character as far as the original URL is concerned

OK I understand. Doesn't look like I can do anything but update the URL's which is ok, am pretty far into it anyway.
Thanks for the explanation on why the proxy is not working.
I appreciate your help,
Dennis

tdennis

Something has happened! Tonight I got reports of photos that I had changed the URL's to https: from http: to make them properly display no longer display! I have been gone all day and have not touched anything! I went back and spot checked a few that I had working properly and they all still have the https: that I had put in but they no longer display. Any idea what may have happened to stop them from displaying ?
Dennis

Kindred

Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Advertisement: