• Welcome to Simple Machines Community Forum. Please login or sign up.
October 17, 2021, 12:38:38 AM

News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord


2.0.16 Update Test Failure

Started by smupdf, July 27, 2021, 02:39:24 PM

Previous topic - Next topic

smupdf

Hi there.  Sorry to resurrect this post but I'm having the exact same issue.

Can't upgrade to 2.0.16 and I've checked I do have the double comment in Profile-Modify.php

         $sizes = @getimagesize($_FILES['attachment']['tmp_name']);

         // No size, then it's probably not a valid pic.
         // No size, then it's probably not a valid pic.
         if ($sizes === false)


Not sure what else I can do.  But I need to get updated as I'm getting rogue new users joining despite having registrations turned off!

shadav

I split your post into a new topic as it's best to open your own support topic

when you are trying to update what is the error that you are getting?

also people registering is a different issue and I'd bet that you have the tapatalk mod installed, this is a known issue of that mod.

smupdf

July 27, 2021, 02:48:33 PM #2 Last Edit: July 27, 2021, 03:12:44 PM by smupdf
You're quite right.  I do have Tapatalk installed.  Am I going to have to ditch that in order to upgrade?

I'm getting the 'Test Failed' error and just one file is failing.

   6.   Replace   ./Sources/Profile-Modify.php   Test failed

Pretty standard I think.


EDIT:  I just uninstalled and deleted the Tapatalk mod but am getting the same error.


EDIT 2:   fixed it!  I don't know what I'm doing.  So I took the Profile-Modify file from 2.0.16 and just shoved it in my sources folder.  Tried upgrading.  It was having none of that.  So I put my 2.0.15 back in.  Tried upgrading and it just worked.  Despite that exact file not working before.  Random.

shadav

are you sure you put the right file back?
replacing the file is fine if none of your mods edited that file, otherwise you've just broken any mods that you installed that edited that file...

no tapatalk wasn't the issue for the upgrade but it was the issue of why people were still able to register even though you turned off registration...tapatalk mod bypasses smf settings so people can register requardless of what you have your settings at,
oh you turned off registration - tapatalk mod doesn't care it still lets people register
oh you have it set to admin approval - tapatalk mod doesn't care it still lets people register without admin approval
ect....

when the error shows up there should be an icon next to the line (a pencil or square or something), if you click on it a popup should open that will tell you what the update is looking for and what it wants to change/add
so next to where it said Replace   ./Sources/Profile-Modify.php   Test failed - to the left of that should have been some icon that you can click on

Sir Osis of Liver

"The best laid schemes o' mice an' men / Gang aft a-gley." - Robert Burns

Aleksi "Lex" Kilpinen

You are right, but this is a classic Tapatalk issue.
Quote from: smupdf on July 27, 2021, 02:39:24 PM
But I need to get updated as I'm getting rogue new users joining despite having registrations turned off!
A Finnish Project Manager (Support Specialist)
 Happily running multiple SMF 2.x installations.
  Fooling around with i7-10700 @ 2,90GHz-4.80GHz / 16Gb / RTX-2070 Super / 3840x2160 / Win 10 x64


How you can help SMF

"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

Sir Osis of Liver

 ^ Yes, that, but it doesn't affect upgrade unless Tapatalk has replaced core files with their own, which doesn't appear to be what's causing the package error.  And, no, upgrade will not fix the registration problem, that's strictly a Tapatalk issue.
"The best laid schemes o' mice an' men / Gang aft a-gley." - Robert Burns

Advertisement: