News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Disable "Like"?

Started by Sir Osis of Liver, August 30, 2021, 09:33:26 PM

Previous topic - Next topic

Aleksi "Lex" Kilpinen

Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Shambles

Quote from: AntechinusCSS is easier than Finnish. :D


Aleksi "Lex" Kilpinen

Nah, he is probably right.
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Arantor

So if you put the like button itself into the quick buttons, what are you doing with the '1 person likes this' which is returned via AJAX and includes a link to a popup to see all the likers?
Holder of controversial views, all of which my own.


Sir Osis of Liver

Quote from: Antechinus on September 04, 2021, 03:30:56 PMkeep the same position, but style it like the quickbuttons.
^ Good idea.

Quote from: Arantor on September 04, 2021, 05:56:00 PMSo if you put the like button itself into the quick buttons, what are you doing with the '1 person likes this' which is returned via AJAX and includes a link to a popup to see all the likers?
Place it below the button, as it appears in your post.

Quote from: Arantor on September 04, 2021, 10:31:21 AMI'm just a little sad that this is another thing I didn't get right
Not a question of getting it right or wrong, it's an aesthetic thing, everybody doesn't like something.

QuoteOh well, can't win 'em all.
Nobody does, and in the end everyone loses it all. :(
When in Emor, do as the Snamors.
                              - D. Lister

Arantor

Quote from: Sir Osis of Liver on September 04, 2021, 06:00:12 PMPlace it below the button, as it appears in your post.

Underneath all of the quote/more buttons? Because that's what 'under the quick buttons' would mean.

Quote from: Sir Osis of Liver on September 04, 2021, 06:00:12 PMNot a question of getting it right or wrong

Not being funny but I don't think you understand. There has been a fair amount of feedback since 2.1 went live here. Virtually *everything* that everyone has complained about was down to me. Not just this one thing but _all_ of the things people actually complained about.

That's a lot to have gotten wrong.
Holder of controversial views, all of which my own.


Antechinus

Quote from: Arantor on September 04, 2021, 05:56:00 PMSo if you put the like button itself into the quick buttons, what are you doing with the '1 person likes this' which is returned via AJAX and includes a link to a popup to see all the likers?
First up, I really do have to wonder if that is useful functionality anyway. :D

However, it could be kept as an unstyled li > a that holds said text, and placed next to the Likes button. So Likes button over at the left, styled to match other quickbuttons. Blurb/link just after it, with plain background, etc. This is not difficult to do with CSS.

Or you could keep two separate ul's for added flexibility if you really wanted to, and just use the quickbuttons class to pick up styling for the Likes button. TBH I haven't given it a lot of thought yet, since at the moment I'm running with the LIkes stuff hidden. Could play around with it a bit in Stylus.

Sir Osis of Liver

When in Emor, do as the Snamors.
                              - D. Lister

Antechinus

Needs a bit more tweaking, but basically that, yes. :)

Arantor

That's not what I was asking about, no, which is why I asked for clarification. Putting it "into the quick buttons" means on the right hand side not the left, hence my 'what are you doing with the other part' confusion.

But that does at least make it look like a clickable thing, though it doesn't follow all of the UI paradigms of SMF (which has too many inconsistent visual cues and calls to action anyway)
Holder of controversial views, all of which my own.


Antechinus

Quote from: Arantor on September 04, 2021, 06:48:36 PMThat's not what I was asking about, no, which is why I asked for clarification. Putting it "into the quick buttons" means on the right hand side not the left...
Not necessarily.
.quickbuttons {
    float: none;
    clear: right;
    display: flex;
    margin: 0 0 5px;
    text-align: start;
}
.quickbuttons > .likes_button {
    order: 1;
}
.quickbuttons > .likes_blurb {
    order: 2;
    margin-right: auto;
}
.quickbuttons > .quote_button {
    order: 3;
    margin-left: auto;
}

Or whatever. In principle it is easy to do.

Douglas

Arantor, I actually LOVE the like feature. I'm glad it made it into SMF as part of the CORE features and that frickin' karma went away. Karma was always a popularity contest on literally every site I've ever managed or help manage.

The like feature actually makes sense. Still kind of a popularity contest, but the focus is more on the post, itself.

As far as visual aesthetics... someone else said it best: You're not going to please everyone.

That's why SMF is powerful and who it is: If there's something you like/dislike/want to change, it's generally pretty easy to make that change.

Don't take anything we're saying as criticism for your work. :)

As for the location: The like button should be on the right (either to the left or right of "Quote").

The like text needs to stay right where it's at, currently.
Doug Hazard
* Full Stack (Web) Developer for The Catholic Diocese of Richmond
(20+ Diocesan sites, 130+ Church sites & 24 School sites)
* HBCUAC.org Web Developer, the NAIA's only HBCU Athletic Conference
* Former Sports Photographer and Media Personality and Former CFB Historian
* Tech Admin for one 2.9M+ post and one 11.6M+ post sites. Used to own a 1M+ post site.
* WordPress Developer (Junkie / Guru / Maven / whatever)

Antechinus

If you want it on the right, it has to go after "Quote", or after "More...". Having it before "Quote" would be a PITA.

zappaDPJ

Quote from: Arantor on September 04, 2021, 05:56:00 PMSo if you put the like button itself into the quick buttons, what are you doing with the '1 person likes this' which is returned via AJAX and includes a link to a popup to see all the likers?

I would leave that where it is.

Although it might seem logical to place the button and the text together it's actually a little confusing. Where there's text (i.e. a post has been liked) the button takes on the appearance of a heading rather than a call to action so to speak.

By placing the button next to the other action buttons (e.g. 'QUOTE) it's purpose becomes more obvious. It's also more in keeping with other platforms.

To be honest, as things stands now I initially thought the 'Like' button was a notification of a single like. It could be that I'm as thick as a brick but it's been nagging at me every time I see it and that's usually a sign in my mind at least that something is not quite right.

Quote from: Arantor on September 04, 2021, 06:11:11 PMNot being funny but I don't think you understand. There has been a fair amount of feedback since 2.1 went live here. Virtually *everything* that everyone has complained about was down to me. Not just this one thing but _all_ of the things people actually complained about.

That's a lot to have gotten wrong.

Have you considered you were right at the time and that what you contributed at the very least planted the seeds of some very necessary changes?

This upgrade has been a very long time coming so it's inevitable what was done way back when may have moved on a little.

In terms of the 'Like' function the important thing is we now have it, placement is just semantics.


[EDIT]
Quote from: Sir Osis of Liver on September 04, 2021, 06:45:19 PMThis?

This which I didn't see at the time of posting is in my view is far more intuitive.

Antechinus

Actually, if you want a really neat implementation take a look at the way Elkarte did it.
Example: https://www.elkarte.net/community/index.php?topic=5993.msg42695#msg42695
Hover over the "Likes" button to get the pop-up of all the members who liked the post.

You cannot view this attachment.

(And before someone says "We can't copy Elkarte!!!!" - you copied the idea of Likes anyway. :P )

Aleksi "Lex" Kilpinen

That is pretty neat, could work just fine.
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Antechinus

It does work just fine. I know because I've used it live. :D Simple code too. You can evil steal Elk's code, coz we have this thing called "open source". You know you want it.

Advertisement: