News:

Bored?  Looking to kill some time?  Want to chat with other SMF users?  Join us in IRC chat or Discord

Main Menu

Some messages outside "forumposts" div/ form (quickmodform)

Started by Julius_2000, February 16, 2023, 06:45:30 AM

Previous topic - Next topic

Julius_2000

Hi,

yesterday I noticed that the formatting for the last 4 post on one specific page of just one topic was slightly off. The post separator seemed different than the rest. So I checked with the DevTool and realized that these last 4 posts were actually placed outside the forumposts container HTML element.

You cannot view this attachment.You cannot view this attachment.
You cannot view this attachment.

It happens in both our custom theme and the Default one so I perhaps can rule out any edits I made. Does anyone know what's going on here? There's no error log for this either which could shed some light on this.


live627

I'd need to view the raw HTML to find out for sure what went wrong.

Julius_2000

Hi! Would you need some type of file or would the link to that page suffice?

Diego Andrés


SMF Tricks - Free & Premium Responsive Themes for SMF.

Arantor

Potentially sure, if a bbc emits more closing divs than it opens.

Julius_2000

#5
Hi, this is the page

https://forum.thechembase.com/index.php/topic,443.20.html

Examining post #35 right before it starts going ugly, I see that the poster actually used a quote but the quote isn't displayed.

[quote author=Stefan link=topic=443.msg8308#msg8308 date=1471552350]
Timelapse of their gear being built up:

https://www.facebook.com/soulwax/videos/10153857999482023/
[/quote]
Some gear porn here :D ARP 2600, Oberheim 2-Voice, Macbeth...
Is there something fishy in there?

Edit: Actually, also post #34 contains a facebook link that also doesn't get displayed.

Arantor

Do you have a mod for auto-embedding video or similar from links?

Julius_2000

Yes, we use S.A.V.E. and the tweet embed mod that is available on the mod page. They're all 2.1.x compatible.

Arantor

And if for a test you disable Facebook embedding, what happens?

Julius_2000

Ha! Indeed, that was a great tip! The culprit appears to be the "facebook video (new v5)" option. Unchecking it resolved the issue. All other FB option work so far.

Thank you!

vbgamer45

Was it appearing inside the quote?

The divs should all be closed based on the code
<div id="fb-root"></div><script>(function(d, s, id) {var js, fjs = d.getElementsByTagName(s)[0];if (d.getElementById(id)) return;js = d.createElement(s); js.id = id;js.src = "//connect.facebook.net/en_US/sdk.js#xfbml=1&version=v2.3";fjs.parentNode.insertBefore(js, fjs);}(document, "script", "facebook-jssdk"));</script><div class="fb-video" data-href="https://www.facebook.com/facebook/videos/$5/" data-width="500" data-show-text="false"  data-allowfullscreen="1"><blockquote cite="https://www.facebook.com/facebook/videos/$5/" class="fb-xfbml-parse-ignore"><a href="https://www.facebook.com/facebook/videos/$5/"></a></blockquote></div>

Community Suite for SMF - Take your forum to the next level built for SMF, Gallery,Store,Classifieds,Downloads,more!

SMFHacks.com -  Paid Modifications for SMF

Mods:
EzPortal - Portal System for SMF
SMF Gallery Pro
SMF Store SMF Classifieds Ad Seller Pro

Steve

As this is not a bug with SMF itself, moving to Support.
DO NOT pm me for support!

Julius_2000

Quote from: vbgamer45 on February 16, 2023, 07:16:55 PMWas it appearing inside the quote?

The divs should all be closed based on the code
<div id="fb-root"></div><script>(function(d, s, id) {var js, fjs = d.getElementsByTagName(s)[0];if (d.getElementById(id)) return;js = d.createElement(s); js.id = id;js.src = "//connect.facebook.net/en_US/sdk.js#xfbml=1&version=v2.3";fjs.parentNode.insertBefore(js, fjs);}(document, "script", "facebook-jssdk"));</script><div class="fb-video" data-href="https://www.facebook.com/facebook/videos/$5/" data-width="500" data-show-text="false"  data-allowfullscreen="1"><blockquote cite="https://www.facebook.com/facebook/videos/$5/" class="fb-xfbml-parse-ignore"><a href="https://www.facebook.com/facebook/videos/$5/"></a></blockquote></div>

Interesting question! It seems like it. Post #35 does indeed quote a facebook video from post#34 in my link. Now that I disabled the new v5 video embed everything looks normal again, but of course the video does not get embedded.

Advertisement: