News:

Want to get involved in developing SMF? Why not lend a hand on our GitHub!

Main Menu

Class "strong" has fixed color

Started by Julius_2000, June 23, 2023, 04:36:21 AM

Previous topic - Next topic

Julius_2000

Hi,

Our custom theme uses a black background for the class "title_bar". While I was looking through the PHP info tab in admin, I realized that there were actual titles in the header for each info segment, although invisible until highlighted.
Upon inspection with Devtools and the latest Default 2.1.4 theme, I noticed that "strong, .strong" actually has a defined color value, which is black.

Is there a reason for why this generic class should have a fixed color at all out of the box? This would i.e. overwrite a custom color for title_bar unless removed or individually addressed with a selector.

Aleksi "Lex" Kilpinen

Not really sure, but if I had to guess it's to try and force browsers in line and present the forum as it was designed instead of how the user has managed to redesign it through browser settings and selection.

This is not really a general support issue though, so I'll move this over to graphics and templates.
Slava
Ukraini!
"Before you allow people access to your forum, especially in an administrative position, you must be aware that that person can seriously damage your forum. Therefore, you should only allow people that you trust, implicitly, to have such access." -Douglas

How you can help SMF

Antechinus

I assume it was the theme author's choice to leave the titles invisible. Either that or they were just too blind to realise. Anyway it should be easy to fix, if you want them visible. It would help if you posted this question in the support thread for the relevant theme.

Diego Andrés

He's talking about the default theme though, he's referring as to why strong has it's own color instead of using body.
What I understood is that in their custom theme they didn't notice strong,.strong had a custom color and it was not inherited.

SMF Tricks - Free & Premium Responsive Themes for SMF.

Julius_2000

Quote from: Diego Andrés on June 24, 2023, 08:23:43 PMHe's talking about the default theme though, he's referring as to why strong has it's own color instead of using body.
What I understood is that in their custom theme they didn't notice strong,.strong had a custom color and it was not inherited.

That's exactly why I even noticed it, because we mostly have dark backgrounds. I then accidentally highlighted the area of the table header and saw the title. Then I went ahead to check whether it was an issue with our custom theme, but the class exactly the same.

I was just curious since I thought it wouldn't make much sense to give this class a specific color when all it's supposed to do is to make font bold (at least in my mind).

I'm sorry about the confusion.

Diego Andrés

Quote from: Julius_2000 on June 25, 2023, 04:52:40 PMI was just curious since I thought it wouldn't make much sense to give this class a specific color when all it's supposed to do is to make font bold (at least in my mind).

I wouldn't know about the specific reason, sorry.
My guess is just trying to highlight the text a little bit more and offer more control over it.

SMF Tricks - Free & Premium Responsive Themes for SMF.

Antechinus

TBH I have no idea why a strong tag, or a .strong class, would be inside .title_bar anyway. All of the .title_bar instances have .titlebg directly inside them, and that has font-weight: bold; declared in index.css. Although frankly there are a lot of things about 2.1 CSS that make no sense, so this is probably just another example. Just change it if you want to.

Code (index.css) Select
h3.titlebg, h4.titlebg, .titlebg, h3.subbg, h4.subbg, .subbg {
background: none;
color: #555;
font-family: "Tahoma", sans-serif;
font-weight: bold;
overflow: hidden;
padding: 6px 12px 5px 12px;
text-shadow: none;
}

Julius_2000

No, no, it's all good. I changed it when I discovered it. I was just wondering.

Quote from: Antechinus on June 25, 2023, 07:14:27 PMTBH I have no idea why a strong tag, or a .strong class, would be inside .title_bar anyway. All of the .title_bar instances have .titlebg directly inside them, and that has font-weight: bold; declared in index.css.
I had a look at the PHP info tab again and I can't find a titlebg after/inside the title_bar there.

But alrighty, no big deal at all.

Antechinus

Ah. So someone, somehow, did something silly (ie: inconsistent) with the markup, and then (someone else, probably) tried to fix it with CSS.

Diego Andrés

I don't think so, you just misunderstood the issue, that's all.

SMF Tricks - Free & Premium Responsive Themes for SMF.

Antechinus


Advertisement: