Ad Management mod

[vbgamer45]

Admin -> Server Settings

[cavem5]

Currently have hundreds of these, and related, errors:

http://mysite.com/index.php?action=dlattach;attach=236;type=avatar [nofollow] [nofollow]
8: Undefined index: template_layers
File: /home/cavem5/public_html/Sources/LoadAds.php

http://mysite.com/index.php?action=dlattach;attach=236;type=avatar [nofollow] [nofollow]
8: Undefined index: default_theme_url
File: /home/cavem5/public_html/Sources/Load.php

[Glasso]

I'm encountering problems with RC5 and Ad Management mod 3 when MSN bot is crawling my site, no other ip-adresses are logged with errors ... :

http://www.***.**/smf/index.php?action=dlattach;attach=986;type=avatar2: Invalid argument supplied for foreach()Bestand: /home/**/domains/***/public_html/smf/Sources/LoadAds.php
Line: 29
and
Undefined index: template_layers
File: /home/**/domains/***/public_html/smf/Sources/LoadAds.php
Line: 27
and
Undefined index: default_theme_url
File: /home/**/domains/***/public_html/smf/Sources/Load.php
Line: 1942
and
Undefined index: theme_url
File: /home/**/domains/***/public_html/smf/Sources/Load.php
Regel: 1941

Very weird problem, is there anybody who could help me out ?

Thanks in advance!

Currently have hundreds of these, and related, errors:

http://mysite.com/index.php?action=dlattach;attach=236;type=avatar [nofollow]
8: Undefined index: template_layers
File: /home/cavem5/public_html/Sources/LoadAds.php

http://mysite.com/index.php?action=dlattach;attach=236;type=avatar [nofollow]
8: Undefined index: default_theme_url
File: /home/cavem5/public_html/Sources/Load.php

quebo & cavem5,

This worked for me for the same problems, you might test & try it at your own risk.

From http://simpleportal.net/index.php?topic=4232.0

index.php - replace

Code Select Expand

// Attachments don't require the entire theme to be loaded.
if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && (!empty($modSettings['allow_guestAccess']) && $user_info['is_guest']))
detectBrowser();
// Load the current theme.  (note that ?theme=1 will also work, may be used for guest theming.)
else
loadTheme();


with:

Code Select Expand

// Attachments don't require the entire theme to be loaded.
/*if (isset($_REQUEST['action']) && $_REQUEST['action'] == 'dlattach' && (!empty($modSettings['allow_guestAccess']) && $user_info['is_guest']))
detectBrowser();
// Load the current theme.  (note that ?theme=1 will also work, may be used for guest theming.)
else*/
loadTheme();


[cavem5]

Thanks, giving it a try

[quebo]

@ŋlasso: thanks, that seems to work!!

[SC RaceFan]

Can some one help me with these errors. I was told my question belongs here. These errors seem to only be on guest and I have had no users complain.  I am new at this and not very sure of my self at this point
Oh, I'm running 2.0RC5
with these packages

1. Header Addon 1.0 [ Uninstall ]
2. Dog Avatars 1.0 [ Uninstall ]
3. Cats Avatars 1.1.2 [ Uninstall ]
4. Dance 1.0 [ Uninstall ]
5. Car Avatar Pack V1.0 1.0 [ Uninstall ]
6. Ad Managment 3.0 [ Uninstall ]
7. Porcelan Animals Avatars 1.0



Errors

Guest
66.249.72.140   
    Today at 04:08:33 PM
0edf889248d422c82d3d79f4c5a06891
Type of error: General 
http://*****.com/forum/index.php?action=dlattach;attach=3;type=avatar2 [nofollow] [nofollow]: Invalid argument supplied for foreach()File: /home/*****/public_html/forum/Sources/LoadAds.php
Line: 29 
   Guest
66.249.72.140   
    Today at 04:08:33 PM
0edf889248d422c82d3d79f4c5a06891
Type of error: Undefined 
http://*****.com/forum/index.php?action=dlattach;attach=3;type=avatar8 [nofollow] [nofollow]: Undefined index: template_layersFile: /home/*****/public_html/forum/Sources/LoadAds.php
Line: 27 

[vbgamer45]

Posted an update to fix that issue.

[Blade_Runner]

Posted an update to fix that issue.

The update doesn't fix the problem.

Guest
74.79.104.37   
http://modcarclub.com/forums/index.php?action=dlattach;topic=161.0;attach=2617;image
2: Invalid argument supplied for foreach()
File: /home/xxx/public_html/modcarclub.com/forums/Sources/LoadAds.php
Line: 30

Guest
74.79.104.37   
http://modcarclub.com/forums/index.php?action=dlattach;topic=161.0;attach=2617;image
2: Invalid argument supplied for foreach()
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 1890

[vbgamer45]

Try again posted another update

[Blade_Runner]

Still have the same problem for guests. Got a few hundred errors in a few minutes.

http://modcarclub.com/forums/index.php?action=dlattach;topic=824.0;attach=4568
8: Undefined index: default_theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 2018

http://modcarclub.com/forums/index.php?action=dlattach;topic=824.0;attach=4568
8: Undefined index: theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 2017

http://modcarclub.com/forums/index.php?action=dlattach;topic=824.0;attach=4568
8: Undefined index: default_theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 2012

http://modcarclub.com/forums/index.php?action=dlattach;topic=824.0;attach=4568
8: Undefined index: default_theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 2011

http://modcarclub.com/forums/index.php?action=dlattach;topic=824.0;attach=4568
8: Undefined index: theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 2000

http://modcarclub.com/forums/index.php?action=dlattach;topic=824.0;attach=4568
8: Undefined index: theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 1999

http://modcarclub.com/forums/index.php?action=dlattach;topic=824.0;attach=4569
8: Undefined index: default_theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 2018

http://modcarclub.com/forums/index.php?action=dlattach;topic=824.0;attach=4568
8: Undefined index: theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 1990

[vbgamer45]

Those errors are not related to ad management mod.

[Arantor]

Except that other members have reported the same errors and the only thing in common is the Ad Management mod. Is there any check made to ensure that you're actually on a page that's going to display ads before adding to the template layers?

[Blade_Runner]

Those errors are not related to ad management mod.

Error is gone when I uninstall it.

[vbgamer45]

Posted an update to skip on processing for attachments should fix some possible undefined errors.

[Blade_Runner]

Latest c version doesn't fix the problem.

http://modcarclub.com/forums/index.php?action=dlattach;topic=845.0;attach=4638;image
8: Undefined index: default_theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 2018

[vbgamer45]

Out of ideas for now will look at later next week.

[petb]

Latest c version doesn't fix the problem.

http://modcarclub.com/forums/index.php?action=dlattach;topic=845.0;attach=4638;image
8: Undefined index: default_theme_url
File: /home/xxx/public_html/modcarclub.com/forums/Sources/Load.php
Line: 2018

Got the same Problem with the same Results.
Only Guests produces the Errors.
And only if the Mod ist installed.

And if the Mod is installed on another System the Errors happend too.

[Mayhem30]

The MySQL query you use in this mod for SMF 1.1.x is not optimized - and does not make use of the PRIMARY index at all.

When I did a "EXPLAIN", Your query uses "filesort" (which happens to be the worst).



I recommend you changing the query in (Sources/LoadAds.php) to :

Code Select Expand

$query = db_query("
SELECT *
FROM {$db_prefix}ads
WHERE ADS_ID > 0", __FILE__, __LINE__);

Using the code above, makes full use of the PRIMARY index  - and no more 'filesort'.

[vbgamer45]

Updated removed the order by.

[vbgamer45]

Done removed the order by part and updated.

Other part that might update next is for the loadads to use caching functions to reduce sql query calls if you have caching enabled.