[4529][2.0 RC4/Subs.php] member awaiting approval notice

[Sverre]

After upgrading my test forum from RC3 to RC4, the "There is one member awaiting approval." line in the header is displayed despite the fact that the approval queue is empty. It only seems to happen with the "Require admin approval when member deletes account" option checked.

No mods installed.

As far as I can tell, it is caused by the changes introduced in the following line (Revision 9916?):

Code (Subs.php) Select Expand

$context['unapproved_members'] = (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 2) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;

[Kolya]

Same problem here after upgrading to RC4.

[pitta]

I've got the same error. I opened this error related to the topic

http://www.simplemachines.org/community/index.php?topic=407527.0

[Jfdowim5]

It only seems to happen with the "Require admin approval when member deletes account" option checked.

Ditto.

[NanoSector]

Uncheck the option for now until a fix is found.

[Brettflan]

Same here on my test backup forum, with account deletion requiring admin approval set. I wasn't going to report it until I'd fully investigated it and come up with a good solution, but since this topic is already here... some screenshots:



When I navigate somewhere else in the admin Manage Members section, the "Awaiting Approval" menu item disappears:

If I set the registration method to "admin approval", that menu item always shows up. So, the code that determines whether to show that menu item should also be updated to show it if account deletion requires admin approval.

Is there some place where you can actually see a list of people who have requested account deletion? I haven't come across it anywhere, but I might well have just missed it.


I came to the same conclusion as Sverre on the cause of it showing up being that particular change in Subs.php, from this in RC3:

Code Select Expand

$context['unapproved_members'] = !empty($modSettings['registration_method']) && $modSettings['registration_method'] == 2 ? $modSettings['unapprovedMembers'] : 0;
to this in RC4:

Code Select Expand

$context['unapproved_members'] = (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 2) || !empty($modSettings['approveAccountDeletion']) ? $modSettings['unapprovedMembers'] : 0;


EDIT: I made a small mod package to revert that line of code for myself, so I figured I might as well share. It's attached to this post.

EDIT 2: also, I've reopened the report Sverre linked to and added a link back to this topic.

EDIT 3: attached package removed; better package with a more proper fix posted further down the thread.

[pitta]

my problem is solved, thanks

[Kolya]

Note that downgrading the relevant code is only a temporary fix, pitta.
Thank you for re-opening the issue in the bug tracker, Brett.

[pitta]

I am aware. thanks

[dsanchez]

this is the message I have in the Welcome area, however, when I clic on the link there are no members waiting for activations

[xenovanis]

There's already been a report for that. Please see here:
http://www.simplemachines.org/community/index.php?topic=407686.0

[dsanchez]

Same problem here after upgrading to RC4.

Same here.

[booch_21]

Oddly enough, I started to see this in RC3, before upgrading.  The error would occur when I either "Reject" or "Reject and Send Mail".  All other options would clear that flag and no message was displayed.

[Aleksi "Lex" Kilpinen]

I believe I have come across this one as well, but at the time I thought I just had some DB hickup - and forgot all about it.

[[SiNaN]]

As I said to Brettflan in private as well, I'm unable to reproduce this with a fresh RC4 install. If anyone is willing to provide me with temporary admin and database access via pm, I would be happy to investigate it further.

[Aleksi "Lex" Kilpinen]

Just checked, and this doesn't seem to happen on my install anymore either. Don't know what has changed.

[Brettflan]

Yeah, I tested it out further yesterday and new account deletion requests show up fine there, and can be handled without a hitch. The problem seems to be with old account deletion requests. The listed number of "awaiting approval" went from 73 -> 74 with the new account deletion request, though only the one new request showed up on the Awaiting Approval page, and the number went back down to 73 when I handled the new account deletion request.
As I told SiNaN, I'll investigate it further today (in a couple of hours or so) to find the cause and report back.

[Jfdowim5]

シナン, you're welcome to fiddle about with mine if it's any help.  Quiet forum so I'm not sure how much use it would be.

Brettflan, that would seem to make sense.  I was wondering why your number was so much higher than mine.  I know that there's only been one account deleted by a member since I started the forum and mine does say that one approval is needed.

[Brettflan]

OK, I think I've found the problem (or at least, a problem). The 'unapprovedMembers' value is stored in the settings table, and only ever incremented or decremented normally. Even if you run through "Recount all forum totals and statistics", it only bothers to recalculate that value if the forum is set to require admin approval for account activation, not if the forum is set to require admin approval for account deletion. So, in our cases, that value is never recalculated.

I'm currently testing it with another runthrough of "Recount all forum totals and statistics" without modification (which I did run without success earlier, but I just want be sure), and then again with a modification to the apparent problem line 285 in Subs.php. If successful, I'll post back with the code change and a mod package for it. It could take a while though, since this is a large forum it's recalculating statistics on.

EDIT: I'll go ahead and post the problem line, it's currently this:

Code Select Expand

if (!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 2)
Based on the other change made for RC4, it should be this:

Code Select Expand

if ((!empty($modSettings['registration_method']) && $modSettings['registration_method'] == 2) || !empty($modSettings['approveAccountDeletion']))

[Brettflan]

I was right. The above line needs to be updated. As for how the "unapprovedMembers" value got so far off track for us in the first place, I don't know.

For anyone who installed my package from earlier in the topic, you should uninstall it and use the new one attached to this topic.

EDIT: fix package received a further update, see page 2 for the final version of it attached to another post.