Table From CSV

[agridoc]

Thank you Anguz, it's the least I can do. 

I have used and tested the mod for quite some time, with many themes and SMF versions, so it's easy to test, I have many ready examples.

[Anguz]

Oddly enough, it seems to have started working, all by itself... :quizical look:
I'm PM'in you with login information so you can take a look around because there is some "odd" behavior.

Got the login data. Sorry for replying by PM, I didn't check this topic first.

I don't see the tag parsed in the example you showed me. Did you uninstall the mod?

[Anguz]

Thank you Anguz, it's the least I can do. 

I have used and tested the mod for quite some time, with many themes and SMF versions, so it's easy to test, I have many ready examples.

[rjscott]

Oddly enough, it seems to have started working, all by itself... :quizical look:
I'm PM'in you with login information so you can take a look around because there is some "odd" behavior.

Got the login data. Sorry for replying by PM, I didn't check this topic first.

I don't see the tag parsed in the example you showed me. Did you uninstall the mod?

Wow now really weird things are happening. My forum is now somehow at version 1.1.2 and all of my mods are "broken" too. What the heck could be going on?! It looks like at least on file is showing up when I try to uninstall any mods as not good: ./Sources/Subs.php

[Anguz]

No idea... weird. Maybe something to do with Joomla?

[rjscott]

No idea... weird. Maybe something to do with Joomla?

Possibly. I've got a post in the general board here. I backed up my entire /forums and then tried to reapply the SMF upgrade patch but received a bunch of "Test failed" errors...

[rjscott]

No idea... weird. Maybe something to do with Joomla?

Possibly. I've got a post in the general board here. I backed up my entire /forums and then tried to reapply the SMF upgrade patch but received a bunch of "Test failed" errors...

Getting back on topic... Here are the results when I try to uninstall the csv mod:

Uninstall Actions "Table From CSV":
Installing this package will perform the following actions:
   Type    Action    Description
1.    Execute Modification    ./Sources/Subs.php    Test failed
2.    Execute Modification    ./Themes/default/index.template.php    Test successful
3.    Execute Modification    ./Themes/default/style.css    Test successful
4.    Delete File    ./Themes/default/sorttable.js

That ./Sources?subs.php test failure shows up in all the broken mods. I rolled this file back to my backup file from a few days ago and now all the mods are working again but the SMF version is still wrong. I'll continue this saga over at http://www.simplemachines.org/community/index.php?topic=198373.msg1261174#msg1261174

[Iomega0318]

wow after reading through all of this I am surprised I did not find an answer to the question I am about to ask lol..

I can't post smilies!
When trying to put a smiley into the table cell it just shows up as the text for the smiley instead of the picture does anyone know why? If so how can I get it to work because I would really like to add them in..

[agridoc]

Smilies are properly parsed and displayed by the mod Iomega0318, except headers (first row).

But some smilies use the semicolon ;, so the mod parses it as separator.

You can use another separator, I use |. So the code should be

Code Select Expand

[table=|]
[/table]

And the contents separated by |.

You can see a working example of a CSV table with smilies here.

[Iomega0318]

Hmm well they aren't in the header but they do use colons, ex. :smiley:

**EDIT**
Tried changing the separator and it still wouldn't work..

[agridoc]

Have you tried | as separator?

[Iomega0318]

Yes that is what I tried as the separator and it still wouldn't show the smilies..

[agridoc]

Could you try this code with copy paste and see if smilies appear in second row?

Code Select Expand

[table=|]
1|2|3
:)| ;)| :D
[/table]

Are you using UTF-8? I don't think it matters and I believe that I have tested the mod with UTF-8, not with smilies however.

[Iomega0318]

Yes that worked fine and yes my board uses UTF-8

I just got them to work though, with regular smilies ex you do not need a space after it, apparently with my smilies ex :smiley: there needs to be a space.. ex. :smiley: blah, old ex. :smiley:blah (see the difference? no space) so all is good now, thank you for your help though..

[agridoc]

Good, I expected that UTF-8 was not a problem 

[agridoc]

3. On one csv the sorting works, on another, only the first 2 column headers will sort and clicking on the others simply reloads the page. My first guess is that something in the csv is odd but I don't know where to start looking. Any suggestions?

I had a message in my forum with 54 thumbnails and links from Photobucket in a very looong message, so I arranged them in a CSV table.

Sorting is not needed in such a table but I clicked on the header of the last column and ... the browser went on page top. That reminded me of rjscott' s message.

The answer was simple. I had two empty cells in the last row. After adding two separators, column sorting was OK. It's not necessary to have some content, just the separator declaring that there is a cell after.

Sorting will not work if the column has empty cells.

I don't know if Anguz will have the will and time to make and add an error trapping routine for empty cells in the sorting script. The mod is quite useful and functional as it is. Options to use or not headers and sorting would be more beneficial for the mod, if added.

[Anguz]

Thanks for the feedback, agridoc.

I won't change the javascript, I don't know the language and didn't write the script in this mod.

I have thought of making the headers and sorting optional, but couldn't think of a tag format for those variables that wouldn't be more complicated, like:

Code Select Expand

[table headers=no separator=|]

If I keep using the current format, anything placed after the = is the separator, and before it is the tag name, so there's no way of adding more variables. Unless I picked certain symbols that won't be parsed as separators, but as modifiers, like * meaning no headers, or something of the sort:

Code Select Expand

[table=*|]

Sorting could be left if headers are used and is not there if headers aren't, so that wouldn't need to be specified.

Thoughts?

[SONSiVRi]

I have installed on 1.1.4 and it works without problem.
But theme is a little bit tricky, default directories didnt work on me.
For "Dilber Multicolor" I used this configuration:

Code Select Expand


/Sources/Subs.php (same)
/Themes/dilbermc-rc3/index.template.php
/Themes/dilbermc-rc3/style.css
/Themes/default/sorttable.js (same)

[Garry]

Anguz

Thanks for your Mod  I hope you are set up to get emails when someone posts to this thread

I installed your mod in version 1.14 and it works fine

Then I went to the new ver 1 TP where you can now use BBC and I copied the code into an article and it worked ok as for building the Table

But the sorting feature doesn't work

which really doesn't surprise me

-------------------------------------------------------------------

I am just curious as to whether  you would be interested in seeing if you could bet it to work in the articles as that would be a tremendous function if you could sort in and article.


Its a great function as it is in an article   but sorting word make it greater

[agridoc]

Hello Gary

I use Anguz's Table from CSV mod and I am TP Language Team member.

Table From CSV works well in SMF 1.1.x and I have tested with SMF 2.0 beta 1 too http://www.simplemachines.org/community/index.php?topic=18917.msg1241133#msg1241133

TinyPortal v1.0.5 beta 1 was just announced 3 days ago as the first public beta version and as Bloc wrote

Note that it is still beta software and as such are bound to have some errors yet.

I can't say it's a TP bug but BBC articles is a new feature and as such it's more probable to have some small bugs.

You can report in TP or wait a more stable TP 1.0.x release to check with.

ADDITION: Tested OK

I tried Table From CSV in TP BBC articles with simple amd complex tables. Both display and sorting work OK.