GoogleTagged

[christicehurst]

Hi Karl

Have tried to install this on SMF 1.1.4 using default theme and got the blank line in the admin configuration panel issue

I checked both xml files and couldn't see anything that needed copied to the languages files for utf8

Stumped (but learning )

Any clues
Gaz

I got that issue too, but it's a great mod!

[taurean]

I've just tested it and whereas its showing tags on other forums, its not on yours.

Your host may have something in place which is blocking or clearing the http referer.

I've attached a 'test' file to check whether http referer is being passed.
The file only contains code to produce a link to the file itself, and writes where the http referer does not exist, is not blank or empty. If it exists it will write the http referer out.


Please Upload it to your host.  Then post the link so I can test it.

Mr. karlbenson,
can this test be done on our forum. i am uploading the same test.php file.

[karlbenson]

The http referrer variable is enabled on your forum.

The mod should technically work on your forum.

HOWEVER your forum is private, so the mod will NOT work because
a) spiders can't browse your site and spider your topics/posts
b) therefore your posts/topics won't be in search engines
c) therefore no users will come to your forum via search engines
d) therefore no googletags will be added.

This mod is ONLY suitable for public forums.

[christicehurst]

Hey Karl, you should work for a version for this mod for the 2.0. You know "hint hint, nudge nudge" for my bigger forum

[GazOutEast]

Karl - any clue yet why the menu item in the configuration box list is blank?

I've uninstalled it until you get a fix for that.

Gaz

[karlbenson]

If your usign utf-8 you need to copy the language strings for this mod from Modifications.english.php to Modifications.english-utf8.php

[taurean]

The http referrer variable is enabled on your forum.

The mod should technically work on your forum.

HOWEVER your forum is private, so the mod will NOT work because
a) spiders can't browse your site and spider your topics/posts
b) therefore your posts/topics won't be in search engines
c) therefore no users will come to your forum via search engines
d) therefore no googletags will be added.

This mod is ONLY suitable for public forums.

thanks Mr. Karl for the info.

helpe me out in making my site as a public forum

[GazOutEast]

If your usign utf-8 you need to copy the language strings for this mod from Modifications.english.php to Modifications.english-utf8.php

Hi Karl

I've got the two $txt lines in -
- modifications-english.php
- modifications-english-utf8.php
- modifications-english_british-utf8.php
(the first two installed themselves from the install script)

But it still doesn't show in the configuration side box in Admin, though the blank line for it is there.

Any ideas?

Gaz

[karlbenson]

all the language strings for the configuration admin area for this mod has its own files.

you need to check you've got GoogleTagged.english.php and GoogleTagged.english-utf8.php in Themes/{themename}/languages/

[GazOutEast]

yup - got them

GoogleTagged.english.php = 1k size
GoogleTagged.english-utf8.php = 2k size

Still got a blank line in the config box in admin

Gaz

[karlbenson]

I think you've found a bug GazOutEast.

With those 2 lines earlier that are required in Modifications.english.php and Modifications.english-utf-8.php
Its actually meant to be 3 lines.

Replace those 2 lines with these 3
   $txt['googletagged'] = 'GoogleTagged';
   $txt['googletagged_admin'] = 'GoogleTagged';
   $txt['googletagged_menu'] = 'GoogleTagged';

[karlbenson]

gaz, the the above should fix the configuration link for you and any one else with utf-8.

I've incorporated this fix into version 1.1. install which i've just uploaded to the mod area.
Thanks for your patience Gaz.

[catchpen]

Thanks for yet another mod I got from you. I was wondering what the CSS changes where for. I have a dark theme (mesh) so it didn't add this to the CSS.

Thanks,
C.P.

[karlbenson]

those two classes set the color of the tags

'googletag' sets the default color for most tags.

'googletagged' are ones which were 'tagged' by this visitor (if they JUST came from google/search engines and resulted in that word being tagged)

[GazOutEast]

I think you've found a bug GazOutEast.

With those 2 lines earlier that are required in Modifications.english.php and Modifications.english-utf-8.php
Its actually meant to be 3 lines.

Replace those 2 lines with these 3
   $txt['googletagged'] = 'GoogleTagged';
   $txt['googletagged_admin'] = 'GoogleTagged';
   $txt['googletagged_menu'] = 'GoogleTagged';

Yup - that's done the trick Karl - many thanks (I was starting to doubt my own ability to read instructions  )

Gaz

[karlbenson]

no thankyou Gaz.

Its another bug quashed

[Chirco]

This is a great mod!!!

I can really see what key words are driving traffic to my forum.

Thanks

[cru]

hi karl!

im a fan of your mods, coz u got great support.
i like this mod, and i would like to request that you can enable tagging in the topics too, where members can type tags like VBgamer's Tagging System

IMO, the mod lacks support. And one more thing, he's not developing it anymore.  http://www.simplemachines.org/community/index.php?topic=135761.msg1188782#msg1188782
TIA

[karlbenson]

Hey Cru. First off thanks for the comments.  It makes it worth the time I spend doing all my mods.

This mod was actually designed as an alternative to Topic Tagging by VbGamer.
Therefore I can't really envision working in user added tags into the mod.

There are a couple of small improvements/things I want to add to this mod, but I was hoping to hold off until I have to upgrade the mod to work for 2.0 before I add anything.

As for VbGamers mod, I don't think its true to say its not got support.  At least the way I understood what he was saying.
I am almost certain he will a) respond to/fix bug reports b) upgrade it to new version (eg 2.0).
I believe its just that he isnt actively developing eg adding more features to it, other than where he is doing custom paid work because user X wants it to have y, z.
I can fully understand that as VbGamer will also have the task of upgrading all of his mods to work for 2.0, which is why he may not be inclined to do much work on the mod.

For VbGamers mods you will probably get a higher level of support via the smf hacks website for bugs/issues etc.  IMO vbGamer makes some of the best mods, (he currently has a download/upload center mod awaiting approval for example).

[GazOutEast]

Karl - found another bug in it

This bug refers to the display of the GoogleTagged permissions titles in the Permissions by MemberGroup panel in Admin
( ... Admin - Members - Permissions - Permissions by membergroup - General Permissions - right hand column between Personal Messaging & Member Profiles)

The Array Name (bold text title) is missing
The Radio Buttons Name (normal text) is missing

right clicking on the page in browser (to view source code) confirms it is the GoogleTagged mod causing the problem - whilst all other sections of the permissions show two http lines for the titles, those lines are missing for GoogleTagged - hence no titles.

In Sources/ManagePermissions.php (about 80% of the way down is a 3-line entry for GoogleTagged =

  'googletagged' => array(
            'googletagged_manage' => false,
         ),

In /languages/googletagged.english.php and googletagged.english-utf8.php there is no $txt for googletagged_manage

But it goes deeper than that - I set a $txt in the language files (oh bollox this is a test LOL) but it did not display after saving the file and force refreshing the permissions screen (including closing and reopening it)

I am wondering if there's a sql element to the mod and the $ is missing from the sql inject and table set up (because of the language files' lines referring to an array)?

When you get a moment, could you look into this for me please?
It's not a project stopper now I know what the missing titles refer to, it's just a tidy-up before moving on to the next batch of mods.

Thanks
Gaz