News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

[Accepted] Recycle Bin

Started by Tim, August 05, 2003, 09:15:29 PM

Previous topic - Next topic

MrCue

I like Anguz's idea, it just makes things so simple.
I am neither a Pessimist nor an Optimist, Just a Realist.

Eve-Online Forum | View Latest Eve-Online Kills | Site Map | SMF Installation

Tomer


Ryan

When moving the deleted topic back... It leaves the recycle bin image there.. is this suposed to happen or isit a mistake lol.. i dunno

Gobalopper

Well moving never changes the topic icon. You can just modify the post to change it though.

pulpitfire

why go to all the trouble of moving a deleted topic around, if you want the option to restore it?  why not just leave it where it is, and UPDATE it with some kind of tag or status column, so the queries won't call it?  then, it just stays where it is, unrecognized, until you click to remove the tag, or update the column that tells the thread status.

Elden

Admin/Moderator/Author Option (editable after setting):  Auto Expire (delete) / Lock thread in X days.

Notice on posting page:  "This thread will expire/lock in X days."

Just a thought.
Visit the PlanetGloom Forums.

Compuart

Quote from: pege on February 25, 2004, 10:31:10 AM
why go to all the trouble of moving a deleted topic around, if you want the option to restore it?  why not just leave it where it is, and UPDATE it with some kind of tag or status column, so the queries won't call it?  then, it just stays where it is, unrecognized, until you click to remove the tag, or update the column that tells the thread status.
The current sollution is imo the least bloated. Any other sollution would require modifications in backbone queries, additional interfaces and database modifications.
Hendrik Jan Visser
Former Lead Developer & Co-founder www.simplemachines.org
Personal Signature:
Realitynet.nl -> ExpeditieRobinson.net / PekingExpress.org / WieIsDeMol.Com

Burpee

Hmm... the "restore" function is something which I do believe should be fixed. Returning something from the recycle bin just leaves several things messed up such as:
1. Message icons (why change them in the first place??)
2. User post count

Also, when moving something to the recycle board it does not get subtracted from the total count of messages on the board, does it?

I do think that these are things that should certainly be looked at, but I have no time to think about it anymore as I had to leave 5 minutes ago... :D

Ben_S

Quote from: Burpee on September 05, 2004, 01:24:04 PM
Hmm... the "restore" function is something which I do believe should be fixed. Returning something from the recycle bin just leaves several things messed up such as:
1. Message icons (why change them in the first place??)

To show that it has been deleted and restored.
Liverpool FC Forum with 14 million+ posts.

Burpee

Okay, that's an advantage if you want that...

I'd think that people would rather want to be able to restore the posts back to their original state with ease than to show to the whole world that apparently they made a mistake deleting a post and had to get it back out of the recycle bin...


To be honest... the current Recycle Bin feature is just too buggy... I'm thinking about disabling the feature on my board because it just doesn't do at all what I want it to do...

[Unknown]

How is it buggy?  If you move it out, it does not increase anyone's post count - but it doesn't decrease it again if you delete it either.

-[Unknown]

Burpee

Quote from: [Unknown] on September 05, 2004, 04:54:32 PM
How is it buggy?  If you move it out, it does not increase anyone's post count - but it doesn't decrease it again if you delete it either.

-[Unknown]

I may be mistaken, but isn't that wrong behaviour?
If the post is back in the public forum the post count should be restored as well...
The reason I'm taking this so heavily is that right now I have a thread with 4 posts from one person that has a post count of 1... Which just shows that there is obviously something wrong...

Is it possible to create an extra check when moving posts that checks if the board where the post is coming from is the Recycle Bin and if so the post count increases as well?

As for the total count.. I don't know how you could fix it but right now I've got a recycle-bin that has 1000 posts and as you saw before my board only has 5000 posts... so that means that 20% of that total is in the Recycle Bin... I don't know about you, but that just feels like a bug to me :(

[Unknown]

Why is that a bug?  It's the way it was intended.

A bug is something working a way it was not intended to.  A design flaw is something working the way it was meant to, but that way being bad.

You don't like the way it was designed, in other words.

-[Unknown]

Burpee

#33
Okay...

My complaint changes then: Read all the above and replace all complaints about "bugs" and change it to "illogic behaviour" and then see if this is a case of illogical behaviour

Otherwise, explain to me why the way that it's behaving right now would be considered logical. I might just be using the feature the wrong way, you never know...

But please remember... I'm here to criticize your work... with the intention of improving it... I do not mean to imply that you're doing a crappy job, I think you guys are all doing a great job...

[Unknown]

See, the way I view "delete" is, I must assume, more permanent than you do.

If a post is deleted, and then "resurrected" I view it as a "zombie".  I don't think of it as "just the same as before" because it *WAS* deleted.  It's a zombie now - living dead.  And I'd best remember to stay away 'cuz it'll try to eat my brains.

So, having the post count decrease on delete and then never change again makes complete sense to me.  Having a member with 4 zombie posts and only one listed post... also seems logical to me.

-[Unknown]

Anguz

Maybe have a checkbox in forum settings to have restored topics/posts from the Recycle Bin restore counts or not?
Cristián Lávaque http://cristianlavaque.com

Amacythe

How about leaving it as it is and training your MODs and Admins not to delete posts that shouldn't be deleted?

Burpee

Quote from: [Unknown] on September 05, 2004, 06:08:12 PM
See, the way I view "delete" is, I must assume, more permanent than you do.

If a post is deleted, and then "resurrected" I view it as a "zombie".  I don't think of it as "just the same as before" because it *WAS* deleted.  It's a zombie now - living dead.  And I'd best remember to stay away 'cuz it'll try to eat my brains.

So, having the post count decrease on delete and then never change again makes complete sense to me.  Having a member with 4 zombie posts and only one listed post... also seems logical to me.

-[Unknown]

Nice story :D
I still don't believe it's fair to punish users for our mistakes...
Let's say I were to create a poll in public and ask for the general public's opinion on the best description of the functionality you would expect from a recycle-bin... who do you think will get the most votes?

Quote from: Amacythe on September 05, 2004, 07:28:17 PM
How about leaving it as it is and training your MODs and Admins not to delete posts that shouldn't be deleted?
Sorry Amacythe, but if you can manage to do that, I'd love to see you teach all people that drive cars not to have any accidents...

dschwab9

If you want the users post count to say 4, just edit their profile and change it.

Amacythe

Well, on my board, all forums have two mods, and they are all instructed not to delete any post without a second opinion.  They can move it to a Moderator only forum, to discuss it with others when the other MODs are available.  It has worked well thus far :) 

As for those drivers having accidents... let's get rid of all drivers under the age of 30 and over the age of 50... no let's refine that... Let's get rid of all drivers except ME ;)

Advertisement: