News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Yet Another Global Announcements Mod (YAGAM)

Started by Nibogo, February 11, 2009, 12:47:15 AM

Previous topic - Next topic

edi67

Quote from: drhamad on February 13, 2009, 03:39:23 PM
NIBOGO: Works like a charm, THANKS! There do seem to be errors with the package... or if not errors, then at least inefficiencies.  Using replaces on those arrays, for instance, is a bad idea, because a lot of mods at to those array and therefore it's rarely (in a decently modified board) as it shows there.  I'd highly recommend using search mode before or after, and NOT using the array titles when you're trying to add to the array, if you can avoid it.  Just use contents of the array as a search string.

The fact that YAGAM supports commenting is a great improvement... now the next step, I hope, is the ability to un-GA a GA, making it a regular thread with all the comments saved.  I hope that can be done at some point.

To anyone experiencing errors... go through manually and make sure what the package says is actually what has happened.  I don't use packages, so I can't speak for it, but the code itself works perfectly.

Very strange, but you trying to make one Global announcemente and click on it for read GA as one topic? for me everything is ok, i can create GA, edit GA, See GA in Topic list but when i try to OPEN it i receive error, the mod is installed correctly in all part but nothing seems so strange that for you work with RC1
CrazyZone - My SMF Forum


From the difficult the hardening of the man you can see

Nibogo

I just dont understand edi67 , I can only say of you can overwrite your announcements.php and announcements.template.php with the files in the Mod Package , maybe is something wrong with the Database , did you check the DB??

Özgür

#42
Hmm.. Nibogo,  can you give me sql query, maybe its work.?

I found finally...

I delete this code line.. And work now..


// Show online and offline buttons?
if (!empty($modSettings['onlineEnable']) && !$context['author']['member']['is_guest'])
echo '
', allowedTo('pm_send') ? '<a href="' . $context['announcement']['author']['online']['href'] . '" title="' . $context['announcement']['author']['online']['label'] . '">' : '', $settings['use_image_buttons'] ? '<img src="' . $context['announcement']['author']['online']['image_href'] . '" alt="' . $context['announcement']['author']['online']['text'] . '" border="0" style="margin-top: 2px;" />' : $context['announcement']['author']['online']['text'], allowedTo('pm_send') ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['announcement']['author']['online']['text'] . '</span>' : '', '<br /><br />';
So Long

Nibogo

Quote from: Özgür´ on February 13, 2009, 07:07:48 PM
Hmm.. Nibogo,  can you give me sql query, maybe its work.?

I found finally...

I delete this code line.. And work now..


// Show online and offline buttons?
if (!empty($modSettings['onlineEnable']) && !$context['author']['member']['is_guest'])
echo '
', allowedTo('pm_send') ? '<a href="' . $context['announcement']['author']['online']['href'] . '" title="' . $context['announcement']['author']['online']['label'] . '">' : '', $settings['use_image_buttons'] ? '<img src="' . $context['announcement']['author']['online']['image_href'] . '" alt="' . $context['announcement']['author']['online']['text'] . '" border="0" style="margin-top: 2px;" />' : $context['announcement']['author']['online']['text'], allowedTo('pm_send') ? '</a>' : '', $settings['use_image_buttons'] ? '<span class="smalltext"> ' . $context['announcement']['author']['online']['text'] . '</span>' : '', '<br /><br />';


That code works fine for me :s

Anyway glad to see of you have the mod working now

Özgür

Problem is !$context['author']['member']['is_guest']  this problem "only" my site..

Anyway, thank you for everthing =)
So Long

edi67

Quote from: NIBOGO on February 13, 2009, 06:53:49 PM
I just dont understand edi67 , I can only say of you can overwrite your announcements.php and announcements.template.php with the files in the Mod Package , maybe is something wrong with the Database , did you check the DB??
i will try by the way i not critic this mod is simply beautiful for me by time i waiting such me that smf must need by default :)
CrazyZone - My SMF Forum


From the difficult the hardening of the man you can see

mgrmgr

As a first thing let me say thank you for this mod, I think it's great.

Works like a charm (for one board :) (You smell something? Yep.)

I tried to make a global announcement on five or six different staff boards at one time, announcement shows up OK, but for the complete result see the attached screenshot.

As said above: One board at a time works fine :)

Now I'm a bit worried. I'd really like the possibility to make one announcement in several boards at one time.

Nibogo

Quote from: edi67 on February 14, 2009, 04:59:37 AM
Quote from: NIBOGO on February 13, 2009, 06:53:49 PM
I just dont understand edi67 , I can only say of you can overwrite your announcements.php and announcements.template.php with the files in the Mod Package , maybe is something wrong with the Database , did you check the DB??
i will try by the way i not critic this mod is simply beautiful for me by time i waiting such me that smf must need by default :)

Yep , is true will be a nice feature and yep this can be a better mod but is all of I can do.

Quote from: mgrmgr on February 14, 2009, 10:27:01 AM
As a first thing let me say thank you for this mod, I think it's great.

Works like a charm (for one board :) (You smell something? Yep.)

I tried to make a global announcement on five or six different staff boards at one time, announcement shows up OK, but for the complete result see the attached screenshot.

As said above: One board at a time works fine :)

Now I'm a bit worried. I'd really like the possibility to make one announcement in several boards at one time.

Thanks for report , I will check if I can reproduce this bug.

I am making the 1.2 version with all the translations and all the bugs fixed , no additional features will be added

Don Pepito

Is it going to work with 1.1.x if i manually install...??


Don Pepito

I already have that mod installed, but ability of comments....:D


Don Pepito

Well, nvm...tnx for unhospitality...
I just have wanted answer, is it going to work if i manually install mod...?? :S


Nibogo

#54
NEW v1.2 Version Uploaded

Changelogs:


Version 1.2 - Feb 14, 2009
- Added Spanish_es , Spanish_latin , Swedish (Nas) , German (CvH) and Turkish (Özgür´) all with UTF-8 (less Swedish)
- New ManagePermission Edit , for compatibility with other mods
- Fixed the bug with multiple "Global Announcement" Bar reporte by mgrmgr in this post
- Fixed the bug "undefined index error in error log.[$sourcedir/Announcements.php ~ line 338]" reported by Yagiz... in this post

Show me the bugs! :)

fords8

Quote- New ManagePermission Edit , for compatibility with other mods

Install went great for me with the mods I said I had installed in my earlier post. I am still getting the line 292 error when I look at the announcement I make.

QuoteFatal error: Cannot use string offset as an array in /***/***/***/***/Sources/Load.php(2032) : eval()'d code on line 292

I have not looked at the error yet. If I get a chance, I will later.


edi67

Please is somebody have this mod working can attach messageindex.template.php, i beginning crazy with this error in that file, i need someboby him Messageindex.template.php of one wokring forum where this forum work correctly, .... i have the same error after the upgrading new version too.

QuoteFatal error: Cannot use string offset as an array in /***/***/***/***/Sources/Load.php(2032) : eval()'d code on line 292


Quoteif ($announcement['can_comment'] == '1')
                      echo''.$announcement['comment_total'].'';

NIBOGO:
colud be there solution ?
http://informationideas.com/news/2006/06/14/fatal-error-cannot-use-string-offset-as-an-array-in/
http://www.zend.com/forums/index.php?t=msg&goto=6396
CrazyZone - My SMF Forum


From the difficult the hardening of the man you can see

fords8

My line for 292 is:

   if (defined('SMF_INTEGRATION_SETTINGS'))

I have not had a chance to look at the error more. Maybe I can get to it this week sometime.

EDIT: I just installed it on my test forum. And it does the same thing on it.

edi67

Quote from: fords8 on February 15, 2009, 07:16:24 AM
My line for 292 is:

   if (defined('SMF_INTEGRATION_SETTINGS'))

I have not had a chance to look at the error more. Maybe I can get to it this week sometime.

sorry but in Message.index.template.php not exist that line, i talk about smf RC1
CrazyZone - My SMF Forum


From the difficult the hardening of the man you can see

fords8

Quote from: edi67 on February 15, 2009, 07:20:45 AM
Quote from: fords8 on February 15, 2009, 07:16:24 AM
My line for 292 is:

   if (defined('SMF_INTEGRATION_SETTINGS'))

I have not had a chance to look at the error more. Maybe I can get to it this week sometime.

sorry but in Message.index.template.php not exist that line, i talk about smf RC1

That line is from my Load.php file and not Message.index.template.php.

Advertisement: