Avatar Verification

[Akyhne]

Guess it's a bug in your browser, as the 5 browsers I use don't have the errors.

[JulesW]

Just happened to me with chrome as well, and presumably with other peoples browsers too, as I regularly have these errors in the log of the forum.

Screenshot of chrome:

[butchs]

I am getting complaints that images are x'ed out (I know one has IE8) and have several pages of the following errors in the log:

Code Select Expand

index.php?PHPSESSID=b431a0564614d0414bd57157379695fe&action=verificationsimages&avatar=f6b339aa2714e3d97416c9fc540cefc3&type=22: Invalid argument supplied for foreach()File: ...Sources/Subs-CaptchaAvatar.php
Line: 16

Code Select Expand

index.php?PHPSESSID=b431a0564614d0414bd57157379695fe&action=verificationsimages&avatar=f6b339aa2714e3d97416c9fc540cefc3&type=28: Undefined index: AvatarsToShowFile: .../Sources/Subs-CaptchaAvatar.php
Line: 16

[butchs]

I like this mod so much I tried to fix it.  Attached is my attempt to get rid of the errors.

It does look like it is working on RC3.

[Akyhne]

Thanks. Hopefully it will help people.

[Akyhne]

Finally got time to update for RC3 support. Added butchs' fix - hope it solves peoples problem as I can't generate those errors myself.

[Bugo]

It's a visual bug => look at screenshot

[Akyhne]

Small visual error. I'll fix it soon.

[Akyhne]

I corrected the visual error and made a small update. It's not nessescary to update, unless you don't like to see the error.

[societyofrobots]

After installing I noticed my error log is getting filled with this:

2: imagedestroy(): supplied argument is not a valid Image resource
File: /home/a_folder/public_html/forum/Sources/Subs-CaptchaAvatar.php
Line: 144

Further investigating the IPs revealed its caused by search engine spiders like microsoft and google.

Any way to prevent this error from occurring?

[Akyhne]

It happens because the search engines/spiders follows old links. Because the links on the images are unique from one visit to the next, the spiders follow links that are not valid anymore.
I never really figured a way to prevent it from happening, then again it's not that often that spiders visit those links.

[societyofrobots]

I never really figured a way to prevent it from happening, then again it's not that often that spiders visit those links.

This mod causes ~3 pages of errors per day . . . spiders like my website . . .

[butchs]

What about "nofollow", SMF uses it for some links.  I am sure you can copy it from the source.   

[Akyhne]

nofollow doesn't give any guaranties. So if you want the mod error free, another solution is needed.

[Arantor]

Hang on, why is visiting old links causing imagedestroy errors exactly?

If you're attempting to load images into resources, and that fails, check for it before calling imagedestroy.

[Akyhne]

Hang on, why is visiting old links causing imagedestroy errors exactly?

If you're attempting to load images into resources, and that fails, check for it before calling imagedestroy.

If you click the register page, the mod fetches some random pictures and generates an array with the images. The array is used to decide what images are used.
If you click an old link to the verification without that array created, you get the errors.

[Arantor]

Then surely you should be able to check whether the array is created before using it?

[Akyhne]

It's not as simple as that.

[Arantor]

Why not?

[butchs]

Something like?

Code Select Expand

if (is_array($???))  // Is this an array