SimpleSEF 2.0 (SMF 1.1.x and SMF 2.0)

[mike s]

I'm working with a fresh copy of my RC3 forum under a different domain.

   

   
• I uninstalled all Mods, tested functionality and then did large upgrade with RC4. All ok.
• First mod I reinstalled was AevaLite 1.7. All ok.
• 2nd mod installed was PortaMx990. PortaMx was ok but issue with white page for messages with embedded video. Found fix for this (comment out one line from subs-aeva.php). All tested ok after that.
• 3rd Mod to install was SimpleSef (vers1.1.1). It passed the installation checks but came back with a white screen and nothing else. I had a 2nd browser to my forum still open from before the install, but when I hit F5 to refresh, I got this line displayed: Numeric request keys are invalid.

I've been able to reproduce this scenario. Not sure how to proceed. Any help would be appreciated.

[eXtreme]

@SlammedDime - I have both SimpleSEF and Sitemap installed. I find a URL rewrite rule in .htaccess for sitemap link, but I am not able to access it from http://forumname. com/ forum / sitemap.xml. It redirects to homepage.

On a test site, I have Pretty URLs with Sitemap. There it appears to be fine. I can access it via  http://forumname. com/ forum / sitemap.xml

Any idea?

PS: I'm still using SimpleSEF 1.0.3. Could that be an issue?

[SlammedDime]

I would recommend using the normal XML sitemap url and not using the rewritten url as you are trying to do.  The reason for those instructions are now moot as google no longer cares in what folder the sitemap is.

[eXtreme]

I would like to know if the rewritten url for Sitemap is supposed to work with SimpleSEF. If it is broken for me, I want to fix it.

Yea, Google does accept "action=sitemap;xml" but certain search engines don't accept this format or even /sitemap/xml/. That's why I wanted to find if it's possible to use /sitemap.xml format.

[SlammedDime]

What search engines won't accept either of the other formats?

What is the contents of your .htaccess file?

[rgb90]

I have a problem with this Mod, I don´t know if it is normal or not.
In 2 SMF 1.1.12 (1 recently installed an other old), when I install this mod, everything works OK, but, if I put (for example) in the URL:
http://forum.com/index.php?action=testing [nofollow]

In the "actions" textbox of Mod, "testing" appears.

Thanks in advance

Ps. Sorry for my bad english

[SlammedDime]

If you are using the latest version of this mod, that shouldn't happen

[rgb90]

It happen with de last version of SMF and las version of the Mod.
I installed a few minutes ago a new forum and it happen...

EDIT:

Is not this part of SimpleSEF.php ?? (Line 282)

Code Select Expand

// Only do this if it's an URL for this board and doesn't contain the admin action
if (strpos($setLocation, $scripturl) !== false && strpos($setLocation, 'action=admin') === false)
{
$setLocation = create_sef_url($setLocation);

// Check to see if we need to update the actions lists
$changeArray = array();
$possibleChanges = array('actions', 'useractions');
foreach ($possibleChanges as $change)
if (empty($modSettings['simplesef_' . $change]) || (substr_count($modSettings['simplesef_' . $change], ',') + 1) != count($simpleSEF[$change]))
$changeArray['simplesef_' . $change] = implode(',', $simpleSEF[$change]);

if (!empty($changeArray))
updateSettings($changeArray);
}

REEDIT:

I reemplace that for this, and the "trouble" doesn´t happen again:

Code Select Expand

// Only do this if it's an URL for this board and doesn't contain the admin action
if (strpos($setLocation, $scripturl) !== false && strpos($setLocation, 'action=admin') === false)
$setLocation = "http://boardurl.com/";


Other trouble:
In any post, if I have default SMF URLs posted (for example: http://board.com/index.php/topic,20.0.html [nofollow]) the "<a href" goes to "http://board.com [nofollow]" :S

I need to install the mod in a production SMF, and in a lot of threads there are links to other post, obviously in the default SMF format

Thanks for quickly answer

[eXtreme]

What search engines won't accept either of the other formats?

Ask.com and Yahoo doesn't accept it.  These 2 may not be as important as Google, but still I want to resolve this url issue. Can you please tell me if Sitemap url actually works with SimpleSEF just like it does with Pretty URLs?

One more thing, if this could be of any help to you - I disabled SimpleSEF and checked the sitemap url. But the url shows /index.php?action=sitemap;xml and not the rewritten one.

What is the contents of your .htaccess file?

Here it is:

Code Select Expand


RewriteEngine On
RewriteRule ^sitemap.xml$ /forum/index.php?action=sitemap;xml
RewriteCond %{REQUEST_FILENAME} !-f
RewriteCond %{REQUEST_FILENAME} !-d
RewriteRule (.*) index.php

My forum is installed in the folder "forum" - so the path mentioned in rewrite rule is fine.

SimpleSEF version: 1.0.3
SMF 1.1.12

[SlammedDime]

Yes, Sitemap and SimpleSEF work just fine together when used normally (and keep in mind, Pretty URLs and SimpleSEF work in two completely different manners), basically what is happening is that sitemap.xml is being rewritten to /forum/index.php?action=sitemap;xml, which is then being redirected by SimpleSEF to /forum/sitemap/xml,

You can try changing the RewriteRule for sitemap.xml to this:
RewriteRule ^sitemap.xml$ /forum/sitemap/xml

If that doesn't work, I can probably give you some code to use to alter SimpleSEF.php, but I won't incorporate it as a fix into the package permanently mainly because I don't recommend using the sitemap rewrite any longer.

[SlammedDime]

rgb90 - Thanks for pointing that out... I'll make a fix for it for the next release.

[eXtreme]

.. basically what is happening is that sitemap.xml is being rewritten to /forum/index.php?action=sitemap;xml, which is then being redirected by SimpleSEF to /forum/sitemap/xml,

Ah! Thanks for clarifying that. I thought /forum/index.php?action=sitemap;xml is being rewritten to sitemap.xml which is then rewritten to /forum/sitemap/xml.

I tried changing that rewrite rule, it didn't work. I even removed that rule but still it didn't work.

[eXtreme]

If that doesn't work, I can probably give you some code to use to alter SimpleSEF.php, but I won't incorporate it as a fix into the package permanently mainly because I don't recommend using the sitemap rewrite any longer.

Please send me the code when you find time.

Thanks

[[Axel]]

Hi there,

I think I found a bug. if you go on Members (the alphabetic  list) on a board with a big member-base you get at the top and bottom of the page-list. ( example: 1 ... 14 15 [16] 17 18 ... 1152). If you now click on the 3 dots to show the next 50 members, all the links are just "/start,%1/$d". They work fine if simpleSEF is turned off. Also the links before the the displayed page work as supposed.

[edit] I just found out the same happens with a list of posts. [/edit]

Hopefully this is an easy fix.

Greetz

[Axel]

[Yağız...]

One lite problem: Simpleportal and /index.php -> /action=forum
if you have installed simpleportal and run forum hxxp://yourforum.com/index.php and SimpleSEF is enabled, the URL change to hxxp://yourforum.com/action=forum and call 404: Not Found
How can I fix it?
Thanks

I've the same issue. Just upgraded my SMF to 2.0 RC4 and reinstalled the new version. I didn't have this problem on my RC3 with SSEF 1.0.3. Oh and, when I hover any link, it shows the old URL (http://www.site.com/index.php?action=blabla), but when I click it redirects to the new one (http://www.site.com/blabla).

Fixed, uninstall the mod > delete all SSEF settings from {prefix}settings table > reinstall

[franklinrony]

Hi i have aproblem with spanish language. Enable simple SEF, but in the top appear the follow message

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string inSources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in Sources/SimpleSEF.php on line 669

Try comment the lines

if (function_exists('iconv'))
         $string = iconv($char_set, 'UTF-8//IGNORE', $string);
      elseif (function_exists('mb_convert_encoding'))
         $string = mb_convert_encoding($string, 'UTF8', $char_set);

but dont work, 
good work with the mod

[Awilum]

how it can be ?

subject is "@! test

url must be

topka/test-28.0.html

i have

topka/%26quot;%40!test-28.0.html

why its not work ?

[SlammedDime]

What do you have set in the admin panel for Characters to strip?

[SlammedDime]

Hi i have aproblem with spanish language. Enable simple SEF, but in the top appear the follow message

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string inSources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in Sources/SimpleSEF.php on line 669

Try comment the lines

if (function_exists('iconv'))
         $string = iconv($char_set, 'UTF-8//IGNORE', $string);
      elseif (function_exists('mb_convert_encoding'))
         $string = mb_convert_encoding($string, 'UTF8', $char_set);

but dont work, 
good work with the mod

I'll need to see a specific example of the characters causing that to nail down what's going on...

[Awilum]

SlammedDime
default values

&quot,&amp,&lt,&gt,`,~,!,@,#,$,%,^,&,*,(,),-,_,=,+,[,{,],},;,:,',",",/,?,\,|

first I think that is some thing wrong in php.ini maybe magic qoutes, but all charsets dosnt work,  its strange