SimpleSEF 2.0 (SMF 1.1.x and SMF 2.0)

[Am']

Find in /Sources/SimpleSEF.php

Code Select Expand


// Gotta fix up some javascript laying around in the templates
$extra_replacements = array(
'/rand,' => '/rand=',
$boardurl . '/topic/' => $scripturl . '?topic=',
'var smf_scripturl = "' . $boardurl . '/' => 'var smf_scripturl = "' . $scripturl,
);


and change to:

Code Select Expand


// Gotta fix up some javascript laying around in the templates
$extra_replacements = array(
'%1/$d' => '%1$d',
'/rand,' => '/rand=',
$boardurl . '/topic/' => $scripturl . '?topic=',
'var smf_scripturl = "' . $boardurl . '/' => 'var smf_scripturl = "' . $scripturl,
);


Fel

thx for this fix fel 

the pagination bug is fixed in memberlist, but not in display messages and sitemap

when i click a number, i have this url :

http://localhost/Forum/NameBoard/NameTopic_20195.%1.html$d

any idea ? 

[SlammedDime]

Just to note, SimpleSEF has been opened up to Google Code and the next version will be released/is being developed under the MPL 1.1 license.  It can be found at http://smf-simplesef.googlecode.com and can be checked out using Mercurial.

[feline]

thx for this fix fel 
the pagination bug is fixed in memberlist, but not in display messages and sitemap
when i click a number, i have this url :
http://localhost/Forum/NameBoard/NameTopic_20195.%1.html$d
any idea ? 

Currently not .. sorry.
You have a link to a example page on your forum?

Fel

[Awilum]

when will support Russian language?

[SlammedDime]

It does support Russian language... like I said before, if you see issues with the Russian translations and can substantiate that with others, let me know the changes that need to be made.  I do not speak, nor read, Russian, so I cannot fix something I don't know is broken.

[Awilum]

Know the population of Russia alone 141930000
and Belarus, Ukraine, Georgia ... However, quite a few Russian

http://www.simplemachines.org/community/index.php?topic=352351.msg2772500#msg2772500

[SlammedDime]

And as i have said now twice before...

As for the Russion translation, this is what I currently have, located in SimpleSEF-Db/x04.php

array (
'А' => 'A', 'Б' => 'B', 'В' => 'V', 'Г' => 'G', 'Д' => 'D',
'Е' => 'Ie', 'Ж' => 'Zh', 'З' => 'Z', 'И' => 'I', 'Й' => 'I',
'К' => 'K', 'Л' => 'L', 'М' => 'M', 'Н' => 'N', 'О' => 'O',
'П' => 'P', 'Р' => 'R', 'С' => 'S', 'Т' => 'T', 'У' => 'U',
'Ф' => 'F', 'Х' => 'Kh', 'Ц' => 'Ts', 'Ч' => 'Ch', 'Ш' => 'Sh',
'Щ' => 'Shch', 'Ъ' => '', 'Ы' => 'Y', 'Ь' => '\'', 'Э' => 'E',
'Ю' => 'Iu', 'Я' => 'Ia', 'а' => 'a', 'б' => 'b', 'в' => 'v',
'г' => 'gh', 'д' => 'd', 'е' => 'ie', 'ж' => 'zh', 'з' => 'z',
'и' => 'i', 'й' => 'i', 'к' => 'k', 'л' => 'l', 'м' => 'm',
'н' => 'n', 'о' => 'o', 'п' => 'p', 'р' => 'r', 'с' => 's',
'т' => 't', 'у' => 'u', 'ф' => 'f', 'х' => 'kh', 'ц' => 'ts',
'ч' => 'ch', 'ш' => 'sh', 'щ' => 'shch', 'ъ' => '', 'ї' => 'yi',
'Ї' => 'Yi', 'є' => 'ie', 'Є' => 'Ie', 'ы' => 'y', 'ь' => '\'',
'э' => 'e', 'ю' => 'iu', 'я' => 'ia',
)

The ones that are different are:
array ( 'Е' => 'Ie', 'Ж' => 'Zh', 'Й' => 'I', 'Х' => 'Kh', 'Ц' => 'Ts', 'Ч' => 'Ch', 'Ш' => 'Sh', 'Щ' => 'Shch', 'Ы' => 'Y', 'Ь' => '\'', 'Ю' => 'Iu', 'Я' => 'Ia', 'г' => 'gh', 'е' => 'ie', 'ж' => 'zh', 'й' => 'i', 'х' => 'kh', 'щ' => 'shch', 'ъ' => '', 'ї' => 'yi', 'Є' => 'Ie', 'ы' => 'y', 'ь' => '\'', 'ю' => 'iu', 'я' => 'ia', )

If you can find others that agree this should be changed, I will make the change for the next release.  I can't, however, go off the word of just one person.

[hartiberlin]

Just to note, SimpleSEF has been opened up to Google Code and the next version will be released/is being developed under the MPL 1.1 license.  It can be found at http://smf-simplesef.googlecode.com and can be checked out using Mercurial.

Does this mean it is now GPL and Feline can offer her modification of it for her portal ?

Quote

    2. Where is SimpleSEF 1.1-pmx ?

If slammeddime develop SimpleSEF under GPL, we will make a fixed release.

Fel

See:
http://portamx.com/topic_2182.msg12591.html#msg12591

Many thanks.

[SlammedDime]

I believe GPL is the *worst* software license to use for PHP scripts and will never use it for any project I ever code, for this forum nor any other project.  It is released under the MPL which is NOT GPL compatible.

From Wikipedia:

Compatibility with GPL

The Free Software Foundation (FSF) considers the license a free software license, albeit one with a weak copyleft. However, "unlike the X11 license" (MIT License) the license has "some complex restrictions" making it incompatible with the GNU GPL. They urge people not to use the license because of this incompatibility unless the provision in section 13 of the MPL is exercised to provide the work under either the GPL or any other GPL-compatible license.[2]

Anyone wishing to fork or otherwise develop the code must do so under the same license.  The code may also be combined with other works which are licensed under a different license, however the code for this mod still falls under the MPL, not the license of the combined work.

[feline]

Of course if we make a fork, then this is NOT licensed under our Portal license.
This fork is continue licensed under MPL with a referrer to the founder (SlammedDime).

Fel

[botb2]

I am currently running SMF 1.1.12 with blackbox theme. I installed the package did all the parse information but simpleSEF still doesn't work. I do not even see it in the backend admin pannel. Not sure whats going on, site is forum.thepokerdream.net

[SlammedDime]

Have you checked the installation instructions and compared them to your files to see if your files were even edited?  If they weren't, that would be why and you'll have to manually install the modification.

[botb2]

Yes, I manually installed it, went to the files separately, edited them, moved them checked the codes and I still don't see the menu. On your postinstall description you say to visit the admin pannel and click on the help link, either I can't find it or I don't have it, but I don't see SimpleSEF in the backend.

[SlammedDime]

Not sure what to really tell you then... if you don't see the option in the admin panel then it wasn't installed properly... the language strings need to be installed in every Modifications.language.php file that is in every Theme's language directory.  If the language strings aren't installed properly, you won't see the text for the menu entries.  You can check the source html of the admin page to see if the menu option exists or not just with no text.

[botb2]

k so i reinstalled moved back to original theme to isolate the problem and I don't think its my template. Attached is the sc i took after installing it

[SlammedDime]

Yup, as I suspected, you're missing all of the language strings.  They are normally installed to Modifications.english.php, but if you are using English-UTF8 as your language, you need to add the language strings to Modifications.english-utf8.php as well.

[botb2]

thx for the help there, got it workign now, except now I have a bunch of at the top of my site no idea where they came from. forum.thepokerdream.net

I realized this is due to error and I'm getting this error  I applied your fix but am still getting the error

2: Cannot modify header information - headers already sent by (output started at /home/thepok8/public_html/forum/Sources/SimpleSEF-Db/x00.php:1)
File: /home/thepok8/public_html/forum/Sources/Subs.php
Line: 3289
?action=viewErrorLog;desc=   

[eXtreme]

Can you please tell me what code to alter? Because I'm not able to submit my sitemap to any of the local search engines.

It's not as easy as I thought it might be... I'm still working on trying to figure it out but I have very limited time. 

I can understand that. I'll wait for it and I hope that you will find a solution when you update it for 2.0 final.

[Yağız...]

Hi i have aproblem with spanish language. Enable simple SEF, but in the top appear the follow message

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string inSources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in /Sources/SimpleSEF.php on line 669

Notice: iconv() [function.iconv]: Detected an illegal character in input string in Sources/SimpleSEF.php on line 669

Try comment the lines

if (function_exists('iconv'))
         $string = iconv($char_set, 'UTF-8//IGNORE', $string);
      elseif (function_exists('mb_convert_encoding'))
         $string = mb_convert_encoding($string, 'UTF8', $char_set);

but dont work, 
good work with the mod

I'm getting the same error with iconv, mb_convert_encoding and unicode_decode on SMF 1.1.12. Using ISO-8859-9 as encoding, and using latin5_turkish_ci and latin1_swedish_ci as DB encoding.

[SlammedDime]

I'll have to try to reproduce... but I'll need some sample text strings in turkish that might replicate the error.  (I'd actually recommend converting the board to UTF8, but that's not always feasible for everyone).