Visual Warning

permutations · July 19, 2005, 06:29:51 PM

Link to Mod

This is an update by Permutations of Grudge's Visual Warning mod. Changes:

- Modified package and instructions to add support for SMF v1.1 Beta 3. SMF 1.0.3-1.0.5 are also supported.
- Edited readme.txt for clarity and completeness.
- Added missing theme file (members.gif).
- Fixed various minor bugs.

The updated package includes both a MOD file and an XML file for 1.1 Beta 3. Both work. The package file (package-info.xml) points to the xml version.

Note: This update replaces the previous listing here:

http://mods.simplemachines.org/index.php?mod=6

lithanual · July 20, 2005, 01:00:24 AM

have any instruction for making this compatible with non-default themes?

xenovanis · July 20, 2005, 09:14:18 AM

Quote from: lithanual on July 20, 2005, 01:00:24 AM
have any instruction for making this compatible with non-default themes?

How to make mods work with themes?

kdunn · July 20, 2005, 09:15:45 AM

Do I need to uninstall v1.21 before installing v1.22?

permutations · July 20, 2005, 11:17:03 AM

The v1.22 update is for people who are running SMF 1.1 (or want to). It doesn't change or enhance anything in the basic functionality of the Visual Warning mod - that is the same. It just adapts the mod to run correctly on SMF 1.1.

If you're running Visual Warning on SMF 1.0.x and you're happy with that setup, there is no need to upgrade. The 1.22 update provides no new functionality.

If you are running Visual Warning on SMF 1.0.x and want to upgrade to SMF 1.1, then do this:

1. Uninstall the Visual Warning mod (and any other mod that runs only on SMF 1.0.x.

2. Upgrade to SMF 1.1.

3. Install Visual Warning v1.22.

Lunatic_10QT · July 20, 2005, 02:16:12 PM

When I try to approve a post, I get this error :

Code Select

Fatal error: Call to undefined function: updatelastmessages() in c:\program files\easyphp\www\smf_1-1-beta3p_install\Sources\VisualWarning.php on line 428

Indeed, I don't find this function in any file

Thanks for your help.

permutations · July 20, 2005, 05:55:52 PM

I see the problem. Fixing...

permutations · July 20, 2005, 06:35:57 PM

Quote from: Lunatic_10QT on July 20, 2005, 02:16:12 PM
When I try to approve a post, I get this error :

Code Select Expand
Fatal error: Call to undefined function: updatelastmessages() in c:\program files\easyphp\www\smf_1-1-beta3p_install\Sources\VisualWarning.php on line 428

Indeed, I don't find this function in any file

Thanks for your help.

What version of SMF are you running?

Lunatic_10QT · July 20, 2005, 06:50:25 PM

Quote from: permutations on July 20, 2005, 06:35:57 PM
Quote from: Lunatic_10QT on July 20, 2005, 02:16:12 PM
When I try to approve a post, I get this error :

Code Select Expand
Fatal error: Call to undefined function: updatelastmessages() in c:\program files\easyphp\www\smf_1-1-beta3p_install\Sources\VisualWarning.php on line 428

Indeed, I don't find this function in any file

Thanks for your help.

What version of SMF are you running?

SMF 1.1 Beta Public, local

permutations · July 20, 2005, 08:02:55 PM

This is fixed now - version bumped to 1.24.

Please uninstall the previous version, delete the package, download the new package, and reinstall.

Minsc · July 20, 2005, 10:01:37 PM

I notice with 1.24 I get this error.

12. Execute Modification ./Themes/default/languages/Modifications.english.php Test failed

However with 1.22 it works fine (this is with a clean copy of modifications.english.php).

permutations · July 20, 2005, 11:24:00 PM

What do you mean by:

Quote from: Minscthis is with a clean copy of modifications.english.php

? "Clean" how? This is one of the files that is changed by the mod. If you replaced the modified file with the original file before applying the mod, it won't work.

The change I made in 1.24 was very minor and had nothing to do with this file. There's no reason why 1.22 would be fine and 1.24 would not.

Please try uninstalling the mod, deleting the package, redownloading the mod, and then reinstalling the mod. If you get the error again, please tell me the exact steps to reproduce.

permutations · July 21, 2005, 01:14:58 AM

To be clear...

This mod does not support upgrades. If you are running Visual Warning 1.21 on SMF 1.0 x and you want to upgrade to SMF 1.1, you must do this:

1. Uninstall any previous version of Visual Warning (and any other mod that only runs under SMF 1.0.x) and delete the package.
2. Upgrade to SMF 1.1.
3. Download the new version of Visual Warning and install it.

Any time you want to update to a later version of Visual Warning, you must start clean:

1. Uninstall the version you're currently running, and delete the package.
2. Upload and install the new version of the package.

Don't worry about losing your member settings - the database isn't touched when you uninstall.

anunlike · July 21, 2005, 01:23:37 AM

I also got a failure message for one instance:

Quote13. Execute Modification ./Sources/ManagePermissions.php Test failed

I previously (just a couple of days ago) installed VisualWarning_v1[1][1].22.tar.gz on my 1.1 Beta 3 Public and all went as planned. So, I uninstalled it tonight and installed VisualWarning_v1[1][1].24.tar.gz afterwards. I easily went in and manually fixed it, but for some reason, it screwed up in the first place.

Thank you much for updating this, this is a really great mod!!

permutations · July 21, 2005, 01:27:39 AM

I'm not able to reproduce this. When I install it, it works fine.

What error did you find and fix in the file?

anunlike · July 21, 2005, 01:36:31 AM

It just didn't install at all. I had to manually insert the whole bit:

Quote<edit file>
$sourcedir/ManagePermissions.php
</edit file>

<search for>
         'profile' => array(
            'profile_view' => true,
            'profile_identity' => true,
            'profile_extra' => true,
            'profile_title' => true,
            'profile_remove' => true,
            'profile_remote_avatar' => false,
         )
</search for>
<add after>
         ,
         'visual_warn' => array(
            'visual_warn_any' => false,
            'visual_approve_any' => false,
         )
</add after>

Padfoot · July 21, 2005, 06:24:50 AM

QuoteExecute Modification ./Themes/default/languages/Modifications.english.php Test failed

Getting this error when trying to install the new mod.

Running 1.1 beta 3 with Bar of experience mod, and Member Specific permissions mod.

When i try and unistall bar of experience mod i get the same error, although member specific seems to uninstall without any issues..

permutations · July 21, 2005, 08:54:21 AM

To the people who saw install errors,

I have tested this mod on both 1.0.5 and 1.1, and I don't get any installation errors. Also, the modification of Modifications.english.php is trivial and always is. It's hard to imagine how any mod can fail on that file, since it just adds text strings to the end of the file. I've also looked at the modified file and it's fine, so I can't explain what causes the errors.

Same with the unchanged lines in ManagePermissions.php - I can't reproduce it and can't explain it. And apparently others are not experiencing failure on this same line, so it must be specific to your installation. Do you have any other mods installed? Other mods can cause installation failure because lines move around and the mod can't find what it's looking for.

There might be something going on with the package manager because I've had problems installing a mod, then reinstalled it and it was fine.

oliverkahn · July 21, 2005, 09:43:04 AM

Installing this package will perform the following actions: Type Action Description
1. Execute Code VisualWarningPdb.php
2. Execute Modification ./index.php Test successful
3. Execute Modification ./Sources/ModSettings.php Test successful
4. Execute Modification ./Themes/default/Profile.template.php Test successful
5. Execute Modification ./Sources/Display.php Test successful
6. Execute Modification ./Themes/default/Display.template.php Test successful
7. Execute Modification ./Sources/Post.php Test successful
8. Execute Modification ./Themes/default/Post.template.php Test successful
9. Execute Modification ./Sources/Karma.php Test successful
10. Execute Modification ./Sources/Subs.php Test successful
11. Execute Modification ./Sources/Security.php Test successful
12. Execute Modification ./Themes/default/languages/Modifications.english.php Test failed
13. Execute Modification ./Sources/ManagePermissions.php Test successful
14. Execute Modification ./Themes/default/index.template.php Test successful
15. Execute Modification ./Sources/Load.php Test successful
16. Extract File ./Sources/VisualWarning.php
17. Extract File ./Themes/default/VisualWarning.template.php
18. Extract File ./Themes/default/images/warnban.gif
19. Extract File ./Themes/default/images/warnpmod.gif
20. Extract File ./Themes/default/images/warnmute.gif
21. Extract File ./Themes/default/images/warnwarn.gif
22. Extract File ./Themes/default/images/members.gif
23. Extract File ./Themes/default/images/english/im_visualw.gif

permutations · July 21, 2005, 09:56:40 AM

Quote from: oliverkahn on July 21, 2005, 09:43:04 AM
Installing this package will perform the following actions: Type Action Description
1. Execute Code VisualWarningPdb.php
2. Execute Modification ./index.php Test successful
3. Execute Modification ./Sources/ModSettings.php Test successful
4. Execute Modification ./Themes/default/Profile.template.php Test successful
5. Execute Modification ./Sources/Display.php Test successful
6. Execute Modification ./Themes/default/Display.template.php Test successful
7. Execute Modification ./Sources/Post.php Test successful
8. Execute Modification ./Themes/default/Post.template.php Test successful
9. Execute Modification ./Sources/Karma.php Test successful
10. Execute Modification ./Sources/Subs.php Test successful
11. Execute Modification ./Sources/Security.php Test successful
12. Execute Modification ./Themes/default/languages/Modifications.english.php Test failed
13. Execute Modification ./Sources/ManagePermissions.php Test successful
14. Execute Modification ./Themes/default/index.template.php Test successful
15. Execute Modification ./Sources/Load.php Test successful
16. Extract File ./Sources/VisualWarning.php
17. Extract File ./Themes/default/VisualWarning.template.php
18. Extract File ./Themes/default/images/warnban.gif
19. Extract File ./Themes/default/images/warnpmod.gif
20. Extract File ./Themes/default/images/warnmute.gif
21. Extract File ./Themes/default/images/warnwarn.gif
22. Extract File ./Themes/default/images/members.gif
23. Extract File ./Themes/default/images/english/im_visualw.gif

Thanks for moving your post over here. As you can see from my previous post, I have no explanation for the error you're seeing. I can't reproduce it and I can't explain it. (You said in the other thread that this was a clean install with no other mods.)

Of all the files that are modified, that is the simplest of all, and I can see from looking at the post-mod change that the modification was done correctly. Someone else here said he had a similar error, installed anyway, and it worked fine. I don't usually recommend installing when a test fails, but it makes no sense why the modification of this file, in particular, would fail. This file is just a list of text strings. Mods add their strings to the bottom of the file, just before the closing '?>' tag. There's not very much that can go wrong here.

Unless... (Just thought of two possibilities...)

Are you using a non-English version of SMF? In that case, you might not have this file.

Or are you using a theme other than the default theme? This mod only works with the default theme.

News:

Visual Warning