Pretty URLs

[pikeman]

There are no records of errors in this regard. Now the Preety URLs is off so I can't keep track of the details.

[vbgamer45]

Ok will check it out this weekend and run some tests

[pikeman]

Thanks.

[Oldiesmann]

On my server I get a 404 error when trying to login with Pretty URLs enabled. I added login, login2 and logintfa to the disabled actions list and it works again. It's trying to POST to /login2/;ajax.

[vbgamer45]

Update
Pretty URLs 2.5                                               2  February 2022
   ================================================================================ 
  !Fixes for SMF 2.1 for logins Thanks to Oldiesmann
  +Redid the template for pretty urls settings area for SMF 2.1
  +Now uses hooks for the main admin menu for SMF 2.1
 

[pikeman]

It works great, thanks! 

[Oldiesmann]

Thanks for the quick fix. I'm going to be upgrading my site again soon so I'll hold off on updating the mod until then (just got around to updating to 2.1 RC4 a few days before 2.1 was released)

[Oldiesmann]

Decided to go ahead and upgrade anyway...

Only thing now is it seems the actions array isn't getting updated when I run maintenance tasks - it still shows "action=login" for the login button rather than /login/ even though I removed that from the disabled actions list and ran maintenance tasks (not a big deal though)

[vbgamer45]

Decided to go ahead and upgrade anyway...

Only thing now is it seems the actions array isn't getting updated when I run maintenance tasks - it still shows "action=login" for the login button rather than /login/ even though I removed that from the disabled actions list and ran maintenance tasks (not a big deal though)

I hardcoded for SMF 2.1 final those three actions login, login2 and logintfa

For the past in SMF 2.1 prior I had to inject an extra ; character in order to get the popup login to work correctly.

[gevv]

Hi,

Https or non-http links are broken




forum ;  https://site.com/forum

link added to topic (without http or https):  site.com/forum  or another site link  anothersite.com

clickable link html output

Code Select Expand


<a href="https://site.com/forum///site.com/forum/" class="bbc_link" target="_blank" rel="noopener">site.com/forum/</a>



Code Select Expand


<a href="https://site.com/forum///anothersite.com" class="bbc_link" target="_blank" rel="noopener">anothersite.com</a>



SMF 2.1.1, Pretty Urls 2.5 PHP 7.4

[vbgamer45]

Check that your pretty urls root is set correctly. I see to many ///

[gevv]

Pretty Urls Root: https://site.com/forum

[vbgamer45]

It looks more like a link issue
Your links are not starting with http:// or https:// so they are not getting linked correctly.

[gevv]

same problem in wamp and real server

mod installed

You cannot view this attachment.



mod. uninstall

You cannot view this attachment.


Note: other mod. are disabled

[vbgamer45]

I haven't been able to recrate on my test site you can try to remove this code
From Sources/PrettyUrls-Filter.phpp

Code Select Expand

// Absolutise relative URLs
if (!preg_match('~^[a-zA-Z\-]+:|^#|@~', $match) && SMF != 'SSI')
$match = $boardurl . '/' . $match;


[gevv]

Hi,

I tried the problem persists

Could this be a problem because the forum is installed in the folder?

site.com/forum/

[vbgamer45]

I don't think so my test forum is in a sub folder.

[engrz]

The mod is not rewriting the urls in sitemap. this results in google is not indexing the urls and error shows, urls blocked by robots.txt

[gorbi]

@engrz +1

[vbgamer45]

What sitemap mod? Probably requires edits.