Repulse

Started by Diego Andrés, March 01, 2023, 02:33:27 PM

Previous topic - Next topic

bod22

I've started testing and adjusting this theme. It's my favourite as far as SMF 2.1 is concerned.

However, I have a few issues to discuss.

The first one is only the idea :)


1. Is it possible to have a different logo for light and different for dark version?
I guess most forums have a graphic logo which is difficult to adjust for both light and dark themes at the same time. It would be nice to have this option that logo changes when you switch to a different version of the forum - light/dark.


There rest are some issues with reponsiveness of this theme. I checked them on my mobile and with Google Chrome on PC so I guess they are global.

1. I don't know why but when a user has an image in signature something crashes a layout of the forum.

https://i.imgur.com/BXC1HnT.png

2. In the list of topics I have something like this. I don't know if it's the matter of the theme or Polish translation but it would be great to have it in one straight line.

https://i.imgur.com/yeonABo.png

3. I think there is a problem with your board icons too or the mod "smf fa board icons". On PC, mobile it's great but on TV where we have a huge resolution despite using the mod with different icons, there are still present the default circles. I know that noone is using a forum on TV but I wanted to check how this theme works on it.

I used this code from your previous hint, that's why the circles are full inside but without it the situation is the same but with empty circles inside.

.boardindex_table div.up_contain:not(.b_board, .b_redirect) .board_icon a::before { display:none;}

4. Finally it's not a problem but what does this icon stand for and how can I get rid of it?

https://i.imgur.com/7dYYtQE.png

Thanks for any help :)

Diego Andrés

Hello.

Quote from: bod22 on February 16, 2024, 10:38:19 AM1. Is it possible to have a different logo for light and different for dark version?
I guess most forums have a graphic logo which is difficult to adjust for both light and dark themes at the same time. It would be nice to have this option that logo changes when you switch to a different version of the forum - light/dark.
Yes but only changing the image manually.
For instance, you'd need to add the image as a background image for a new div or container, and possibly define the path in a new CSS variable, and then change the value for dark.css
So if you don't mind having to manually replace your logo every now and then, I could provide you some code for this.

Quote from: bod22 on February 16, 2024, 10:38:19 AM1. I don't know why but when a user has an image in signature something crashes a layout of the forum.

https://i.imgur.com/BXC1HnT.png
I might've seen this issue on the default theme too... I'll look into it.

Quote from: bod22 on February 16, 2024, 10:38:19 AM3. I think there is a problem with your board icons too or the mod "smf fa board icons". On PC, mobile it's great but on TV where we have a huge resolution despite using the mod with different icons, there are still present the default circles. I know that noone is using a forum on TV but I wanted to check how this theme works on it.

I used this code from your previous hint, that's why the circles are full inside but without it the situation is the same but with empty circles inside.

.boardindex_table div.up_contain:not(.b_board, .b_redirect) .board_icon a::before { display:none;}
This might not work anymore as I updated the theme, not sure if you updated it too recently? I'll have a look later and let you know if the CSS rule needs to be changed.

Quote from: bod22 on February 16, 2024, 10:38:19 AM4. Finally it's not a problem but what does this icon stand for and how can I get rid of it?

https://i.imgur.com/7dYYtQE.png
This is part of the legend icons that appear below the topics list. That specific icon means the user has previously participated in the topic.
Do you want to remove all of those hints?

SMF Tricks - Free & Premium Responsive Themes for SMF.

bod22

Quote from: Diego Andrés on February 16, 2024, 10:54:04 AMYes but only changing the image manually.
For instance, you'd need to add the image as a background image for a new div or container, and possibly define the path in a new CSS variable, and then change the value for dark.css
So if you don't mind having to manually replace your logo every now and then, I could provide you some code for this.

Great, it would be nice. I think I'll manage to do it manually on my own.

Quote from: Diego Andrés on February 16, 2024, 10:54:04 AMI might've seen this issue on the default theme too... I'll look into it.

Thank you.

Quote from: Diego Andrés on February 16, 2024, 10:54:04 AMThis might not work anymore as I updated the theme, not sure if you updated it too recently? I'll have a look later and let you know if the CSS rule needs to be changed.

I use the last version 1.1.1 and as I said I noticed it only when showing on TV.


Quote from: Diego Andrés on February 16, 2024, 10:54:04 AMThis is part of the legend icons that appear below the topics list. That specific icon means the user has previously participated in the topic.

Yes, I'd like to get rid of this icon. To to be precise the one in a circle.



And what about number 2?

"2. In the list of topics I have something like this. I don't know if it's the matter of the theme or Polish translation but it would be great to have it in one straight line.



Steve

The icon in your red circle can be gotten rid of this way:

Make copy of MessageIndex.template.php from Default theme (If Repulse doesn't already have one.):

Delete:

', $topic['is_posted_in'] ? '<span class="main_icons profile_sm"></span>' : '', '
My pet rock is not feeling well. I think it's stoned.

Diego Andrés

#124
Quote from: bod22 on February 16, 2024, 10:38:19 AM1. I don't know why but when a user has an image in signature something crashes a layout of the forum.

https://i.imgur.com/BXC1HnT.png
Can't reproduce, what's the signature content?

Quote from: bod22 on February 16, 2024, 01:55:34 PMI use the last version 1.1.1 and as I said I noticed it only when showing on TV.
I just tested this but I'm not sure what are the changes you made, are you using a MOD or what exactly did you change to add your icon?
Dos it work if you change the CSS to this?
.boardindex_table div.up_contain .board_icon a::before { display:none;}

SMF Tricks - Free & Premium Responsive Themes for SMF.

bod22

Quote from: Steve on February 16, 2024, 05:37:05 PMThe icon in your red circle can be gotten rid of this way:

Make copy of MessageIndex.template.php from Default theme (If Repulse doesn't already have one.):

Delete:

', $topic['is_posted_in'] ? '<span class="main_icons profile_sm"></span>' : '', '

Works perfectly. Thanks.

Quote from: Diego Andrés on February 16, 2024, 07:18:46 PMCan't reproduce, what's the signature content?

These are usually some images with different profiles. Here the example.

[URL=http://psnprofiles.com/G-R-Z-E-C-H][img width=338 height=100]http://card.psnprofiles.com/1/G-R-Z-E-C-H.png[/img][/URL]
Perhaps the problem is not with the theme but these set dimensions of images? I should edit them manually?

Quote from: Diego Andrés on February 16, 2024, 07:18:46 PMI just tested this but I'm not sure what are the changes you made, are you using a MOD or what exactly did you change to add your icon?
Dos it work if you change the CSS to this?

I used FA Board Icons. Now it works great with your code. Thanks.


Diego Andrés

1.1.2 - 19 February 2024
  • Bug Fix Fixed last poster layout issue.
  • Bug Fix Fixed issues with dark mode or color variants when forum is closed to guests or in maintenance.
Full Changelog: v1.1.1...v1.1.2

SMF Tricks - Free & Premium Responsive Themes for SMF.

bod22

Is it OK that while zooming site avatars overlap the space with messages counter?



You can check it in 110% view, 120% view etc.



Kindred

Zooming screws up all sorts of layouts
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Diego Andrés

1.2 - 30 June 2024
  • New Feature Changed the memberlist layout.
  • Bug Fix Fixed not loading font locally when set in the settings.
  • Improvement Replaced 'Auto' color mode with 'System'.
  • Improvement Code improvements for 'Theme Customs'

Full Changelog: v1.1.2...v1.2

Due to the outrageous size of the fonts folder, I've included an additional package suffixed '_nofonts' for those that don't want them (why wouldn't you though). This is because the limitation in uploads sometimes is around 2MB. My recommendation is to give it a try and hope there is no timeout, or upload via FTP with the fonts.

Note: The update is essentially improvements to the code. You can take your time updating, no need to do it right away as there were many changes. As always, remember that the /themecustoms folder can be replaced in it's entirety.
Most files can be certainly replaced without issue if you didn't edit them or no MODs affected them. Only observations for those interested:

- The data-attributes for variants and dark mode changed:
    - data-themecolor is now data-variant
    - data-colormode is now data-mode  (and now you need to use both :root[data-mode="dark"] and :root[data-mode="system"] to target dark styles.

SMF Tricks - Free & Premium Responsive Themes for SMF.

robrahn123

Start out by saying thanks for the clean modern theme! Fresh install with no edits and PHP 8.2.  The menu background is missing on windows chrome but is there for android chrome.  The theme color does not save.  Saves for drop down but not for preview or live site.  Wasn't sure if this is a bug in new update.  Your demo site looks fine.  Thanks again for the great theme!

Diego Andrés

I will check the menu issue you have later today.
For the variant selection, did you have any visible error or issue? I will add to this, as an admin you're always allowed to change your variant, at least that's what I remember doing.

Did you check your profile to make sure it matches your selection? Keep in mind that if you used the URL directly without JS, it will keep that color selected in your session for longer.

SMF Tricks - Free & Premium Responsive Themes for SMF.

erkman77

Hello , always when i activate this Theme i got this
Parse error: syntax error, unexpected 'object' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /srv/users/webserver/apps/webserver/public/tests/smf_21/Themes/Repulse_v1.2/themecustoms/Theme/Integration.php on line 20no mods or something else installed

Diego Andrés

Quote from: erkman77 on August 09, 2024, 10:18:04 AMHello , always when i activate this Theme i got this
Parse error: syntax error, unexpected 'object' (T_STRING), expecting function (T_FUNCTION) or const (T_CONST) in /srv/users/webserver/apps/webserver/public/tests/smf_21/Themes/Repulse_v1.2/themecustoms/Theme/Integration.php on line 20no mods or something else installed

You need at least PHP 8.0 to use the theme.

SMF Tricks - Free & Premium Responsive Themes for SMF.

erkman77


robrahn123

Quote from: Diego Andrés on August 09, 2024, 08:37:25 AMI will check the menu issue you have later today.
For the variant selection, did you have any visible error or issue? I will add to this, as an admin you're always allowed to change your variant, at least that's what I remember doing.

Did you check your profile to make sure it matches your selection? Keep in mind that if you used the URL directly without JS, it will keep that color selected in your session for longer.

Thanks for the reply.  Hope this isnt to confusing!

With Default theme variant in admin setting saved as yellow, yellow never shows anywhere until user does it in profile or color changer (saves here per #7).

Wouldn't Default theme variant in theme settings/color settings be the color a non registered and registered user would start on by default until they change it with color changer or settings in profile?  They see light blue no matter what.

If I clear all history, forum always goes back to light blue when logged out.

------------

Placed this in forum root index.php to display errors in php on fly.  No error in entire process.

ini_set('display_errors', 1);
ini_set('display_startup_errors', 1);
error_reporting(E_ALL);

1 - Cleared All history, ALL Checked in Brave, Chrome and Edge. (Clear Everything)
2 - Logged in admin with Brave.  Changed Theme Settings/Color Settings/Default theme variant to Yellow and save.  Everything still default light blue other than drop down says yellow.
3 - Log out with brave and refresh.  Brave still shows default light blue.  Clean Chrome and Edge also light blue.
4 - Registered new user with Chrome and logged in still default light blue.
5 - With Brave admin and Chrome New User profile look and layout Select Color Variant both say default.
6 - With Brave admin and Chrome New User profile look and layout Select Color Variant change to dark blue.  Everything now dark blue on both.  (Setting worked in profile and clolor chooser in header).
7 - Logout on both, both back to defulat light blue.  Loaded Edge and was light blue.  Logged in new user and it changed to dark blue at per setting in profile set with Chrome.

------------

Thanks for your help!

Diego Andrés

Okay, there are indeed some silly bugs I left in the code and are causing issues.
In additon, I'm always as confused as the users by this functionality because I always forget to mention the member options.

Essentially this will be the new description for the default variant setting:

If the user selection is disabled, this will be the default and locked mode. Admins can still change their preference.
This does not affect the default values for the users, for that you can use the Member Options section.


I will be releasing a new package shortly, addressing the issues.

SMF Tricks - Free & Premium Responsive Themes for SMF.

robrahn123

#137
Thanks for the update on the menu.  Will be waiting for the update.  I still might be confused on color change. Its not that big of deal anyhow.  Default light blue works.  Thanks again!

Log in as admin and set Default theme variant: Default and Disable user variant selection: Checked.  Log out and theme is default light blue as it should.

Log in as admin and set Default theme variant: Yellow and Disable user variant selection: Checked.  Log out and theme is default light blue not yellow like I would think.  Now error below is logging.  If I uncheck Disable user variant selection: the error goes away.

/Themes/Repulse_v1.2/themecustoms/Color/Variants.php (Line 56)
Undefined array key "default_variant"

With Default theme variant: Yellow and Disable user variant selection: Checked the user would only be able to see the default light blue never yellow.

Extra edit:
Default theme variant: Yellow and Disable user variant selection: Checked.
Configure guest and new user options for this theme: Changed to yellow.
Change current options for all members using this theme: Changed to yellow.

After logout stayed yellow but changed to light background.  Alot going on with background and colors.  Like I said no biggie can work around.  Just adding some info.  Thanks again!

Diego Andrés

Quote from: robrahn123 on August 09, 2024, 05:10:52 AMStart out by saying thanks for the clean modern theme! Fresh install with no edits and PHP 8.2.  The menu background is missing on windows chrome but is there for android chrome.

Can't reproduce this issue, it's not supposed to have any background in the menu.

SMF Tricks - Free & Premium Responsive Themes for SMF.

Diego Andrés

1.2.1 - 10 August 2024
  • Improvement HTML attributes definition.
  • Bug Fix Fixed issues with the defaults for Variants and Dark Mode.
  • Bug Fix Fixed issues with the data attributes for the Variants and Dark Mode.


Full Changelog: v1.2...v1.2.1

SMF Tricks - Free & Premium Responsive Themes for SMF.

Advertisement: