News:

Want to get involved in developing SMF, then why not lend a hand on our github!

Main Menu

Topic Ratings

Started by Oldiesmann, January 20, 2005, 01:59:43 PM

Previous topic - Next topic

Gary

No Luck;

Parse error: parse error, unexpected T_CONSTANT_ENCAPSED_STRING, expecting ')' in /****/****/****/****/Sources/MessageIndex.php on line 630
Gary M. Gadsdon
Do NOT PM me unless I say so
War of the Simpsons
Bongo Comics Fan Forum
Youtube Let's Plays

^ YT is changing monetisation policy, help reach 1000 sub threshold.

SleePy

that should be it....

hmmm... odd the beta2c didn't get the fixed code into it... how odd.

http://lordsofclantribe.com/SleePys/Topic_Rating_RC2_beta2d.tar.gz

That is 100% should work. and not give you that error.

Thanks for being brave and downloading the beta and trying.
Jeremy D ~ Site Team / SMF Developer ~ GitHub Profile ~ Join us on IRC @ Libera.chat/#smf ~ Support the SMF Support team!

Webrunner

All scores i enter show up as N/A  :(
There is a difference between knowing the path and walking the path.

=========================================
Vrouwen Power! | Sprintweb: No nonsense e-Business consultancy

L.G.S

Can this be made for 1.1 RC2?
FREE and LIVE World Cup + Premier League football streams:

www.gamesandgoals.com


Gary

Thats what the guy is trying to do.

Again, I get a 404.
Gary M. Gadsdon
Do NOT PM me unless I say so
War of the Simpsons
Bongo Comics Fan Forum
Youtube Let's Plays

^ YT is changing monetisation policy, help reach 1000 sub threshold.

SleePy

Quote from: Webrunner on February 11, 2006, 10:24:37 AM
All scores i enter show up as N/A  :(

that is a bug i got to find out.. im not sure why but it does do that...

Quote from: AwwLilMaggie on February 11, 2006, 12:51:35 PM
Thats what the guy is trying to do.

Again, I get a 404.

send me your MessageIndex.php in your Sources so i can look at it... this shouldn't be happening..
Jeremy D ~ Site Team / SMF Developer ~ GitHub Profile ~ Join us on IRC @ Libera.chat/#smf ~ Support the SMF Support team!

L.G.S

Quote from: AwwLilMaggie on February 11, 2006, 12:51:35 PM
Thats what the guy is trying to do.

Again, I get a 404.

Sorry, couldn't make it out through the coding ;)
FREE and LIVE World Cup + Premier League football streams:

www.gamesandgoals.com


Gary

#127
Okay. PM me your email, or contact me on AIM: AwwLilMaggie
Gary M. Gadsdon
Do NOT PM me unless I say so
War of the Simpsons
Bongo Comics Fan Forum
Youtube Let's Plays

^ YT is changing monetisation policy, help reach 1000 sub threshold.

muslimways

Quote from: L.G.S on February 11, 2006, 10:39:39 AM
Can this be made for 1.1 RC2?

I am trying to install this MOD, cos I really need a topic rating function, but its not working, and I also have 1.1 RC2 version of SMF, please help!!!!!!!!!1

perplexed

I used to have this on a previous version so I tried to install the file from the previous page now for RC2, but I got the following errors.

Installations actions for "Topic Ratings":
Installing this package will perform the following actions:  Type Action Description
1. Execute Code RatingsPdb.php 
2. Execute Modification ./Sources/Display.php Test successful
3. Execute Modification ./Sources/Load.php Test successful
4. Execute Modification ./Sources/ManageBoards.php Test successful
5. Execute Modification ./Sources/Subs-Boards.php Test failed
6. Execute Modification ./Sources/Subs-Members.php Test successful
7. Execute Modification ./Sources/MessageIndex.php Test failed
8. Execute Modification ./Sources/RemoveTopic.php Test successful
9. Execute Modification ./Themes/default/Display.template.php Test successful
10. Execute Modification ./Themes/default/ManageBoards.template.php Test successful
11. Execute Modification ./Themes/default/MessageIndex.template.php Test successful
12. Execute Modification ./Themes/default/languages/Modifications.english.php Test successful

I have other mods installed so I dont know what might be causing the problem, hope this helps

SleePy

well since i don't know the other mods check which mods modified the files that are failing and then either uninstall them or manually edit it yourself.
Jeremy D ~ Site Team / SMF Developer ~ GitHub Profile ~ Join us on IRC @ Libera.chat/#smf ~ Support the SMF Support team!

perplexed

lol I got 27 mods installed already and tiny portal but I dont want to uninstall them. Im not familiar with editing the files either so I guess I'll have to leave it for now

~thanks

trenchteam

I attempted to be mr. hero and manual install on 1.1rc2, but it seems there have been some big changes in the SOURCE files.  I couldn't find half the things that needed to be changed.

Gobo

Well Mr. Hero you should be proud of yourself! I was going to try a manual install as well - bt thanks to you now 100's of people like me will know not to attempt it.

Thanks and here is your medal --> O

evillair

#134
Quote from: Webrunner on February 11, 2006, 10:24:37 AM
All scores i enter show up as N/A  :(

I had the same thing... I fixed it though...

In Sources/MessageIndex.php

line 594 and 595 add a "," (no quotes) at the end of the lines.

           'views' => $row['numViews'],
            'rating' => $row['rating'],

I was getting a parse error before too @ line 594 so I added a , then I was getting the N/A untill I added a , at line 595.

Change the rating for it to update.
I installed the http://lordsofclantribe.com/SleePys/Topic_Rating_RC2_beta2d.tar.gz by SleePy on this page.
I installed a clean smf RC2 and only have TinyPortal v.0.8.6 installed as MOD's.

Works for me on my home machine. W000t!

Does this work for everyone else?

Thank you SleePy and Oldiesmann! :D


edit--->

I was looking in the forum error log and found and error, to fix this do the following:

Sources/Subs-Boards.php
Line 1004, 1005:

Look for:

if (isset($boardOptions['permission_mode']) && empty($modSettings['permission_enable_by_board']))
$boardUpdates[] = 'is_rated = ' . $_POST[is_rated];


Change to:

if (isset($boardOptions['permission_mode']) && empty($modSettings['permission_enable_by_board']))
$boardUpdates[] = 'is_rated = ' . $_POST['is_rated'];


Changed [is_rated] to ['is_rated']

edit 2-->

A rating of 5 gives me a "N/A". The other rating work fine.

:(




Oldiesmann

Give me about 20 minutes and there should be an "official" RC2 version. I've got some free time right now so I'm going to go ahead and update this one because it's the easiest one to update :)
Michael Eshom
Christian Metal Fans

ghostfreak


http://www.xfilesforum.net - Dare To Believe?
http://www.idealforum.co.uk - The Green Blitz!

Oldiesmann

Ok... So it took me 40 minutes instead of 20 :P

Updated the mod for RC2. Let me know if you have any problems.
Michael Eshom
Christian Metal Fans

Gary

I got;

1.     Execute Code     RatingsPdb.php     
2.    Execute Modification    ./Sources/Display.php    Test successful
3.    Execute Modification    ./Sources/Load.php    Test successful
4.    Execute Modification    ./Sources/ManageBoards.php    Test successful
5.    Execute Modification    ./$sourcdeir/Subs-Boards.php    File not found
6.    Execute Modification    ./Sources/Subs-Members.php    Test successful
7.    Execute Modification    ./Sources/MessageIndex.php    Test failed
8.    Execute Modification    ./Sources/RemoveTopic.php    Test successful
9.    Execute Modification    ./Themes/default/Display.template.php    Test successful
10.    Execute Modification    ./Themes/default/ManageBoards.template.php    Test successful
11.    Execute Modification    ./Themes/default/MessageIndex.template.php    Test successful
12.    Execute Modification    ./Themes/default/languages/Modifications.english.php    Test successful

When installing on RC2

./$sourcdeir/Subs-Boards.php Is obviously a typo $sourcedir/Subs-Boards.php :P it should be.
Gary M. Gadsdon
Do NOT PM me unless I say so
War of the Simpsons
Bongo Comics Fan Forum
Youtube Let's Plays

^ YT is changing monetisation policy, help reach 1000 sub threshold.

evillair

In ratings_v1.03_rc2.mod:

<search for>
   $context['name'] = $row_board['name'];
   $context['description'] = $board_info['description'];
</search for>

Should be:

<search for>
   $context['name'] = $board_info['name'];
   $context['description'] = $board_info['description'];
</search for>


Thank you! :)


Advertisement: