Theme alterations made in RC2

[EuropeanWars]

Hello,

I tried to pass my them in RC2, therefore I followed all the stages above, but when I passed in RC2, I wanted to give the them "modified" and it does not go, an error message is posted:

Code Select Expand

Parse error: syntax error, unexpected T_STRING in .../Themes/endar/index.template.php on line 120

111: // Guests don't have theme options!!
112: if ($context['user']['is_guest'])
113: echo '
114: document.cookie = "upshrink=" + (mode ? 1 : 0);';
115: else
116: echo '
117: smf_setThemeOption("collapse_header", mode ? 1 : 0, null, "' . $context['session_id'] . '")';';
118:
119: echo '

120: document.getElementById("upshrink").src = smf_images_url + (mode ? "/expand.gif" : "/collapse.gif");

121:
122: document.getElementById("upshrinkHeader").style.display = mode ? "none" : "";
123:
124: current_header = mode;

Could you help me to "repar" my them ? I hold to with it much because I spent much time to personalize it...  Thank you in advance

PS: Sorry for my English 

[JayBachatero]

Take a look at http://www.simplemachines.org/community/index.php?topic=64744.0

[EuropeanWars]

Ok, thank you a lot !!

[JayBachatero]

You're welcome.

[basys]

Hi Folks

Don't know if this was intentional, or posted elsewhere.

Issue 1
function theme_linktree()
has different code in the two themes default & classic.

In the SMF default theme,
it's no longer possible to display the post location as a tree.

This creates quite a navigation problem for users in deeply nested boards,
particularly for users on lower screen res's.

No matter what the setting is in Theme Settings - SMF Default Theme -
[]  Enable inline links
Enabling this will cause your current location to be drawn in a single line, as opposed to in a tree-like manner.

Doesn't work.     

Copying the function from classic to default restores this capability.



Issue 2
In IE6.0.29 the forum will not display as the full width of the browser window.
On both sides there is an approx 15 pixel width border.
Classic displays ok as full width.



HTH
Paul

[JayBachatero]

1.  This was done intentionally.  Core (NDT) doesn't support Tree style.  It didn't look good with it.

2.  Edit the width in index.template.php.  There is a section that says that IE will add an extra amount of pixels to the width.

[basys]

Hi Folks

re: function theme_linktree() and []  Enable inline links
If this function is not available in the Default Theme
the admin Theme Options and Preferences
should not display it as being so.
LOL.

Could this be suppressed from displaying please.
(Comment out of template rather than delete)



re: Portal width
My apologies Jay
Please could you be more specific   
as to where to force full screen
within the index.template.php

I've only spotted references to -
resizing fonts
fixing overflow heights



Many thanks
ATB
Paul

[basys]

Hi Folks

Tracked this down to hardcoding in the style sheet.

Code Select Expand


/* The main body of the entire forum. */
body
{
background-color: #E5E5E8;
margin: 0px;
padding: 12px 30px 4px 30px;
}


Set all padding to 0 and fixed.

Thanks for your assistance.

ATB
Paul

[JayBachatero]

re: function theme_linktree() and []  Enable inline links
If this function is not available in the Default Theme
the admin Theme Options and Preferences
should not display it as being so.
LOL.

The reason as to why it was left there is because other themes use the default theme's settings.template.php file so if that line is missing then you wouldn't be able to change that setting in other themes.

[basys]

Hi Folks

Many thanks Jay.

Can the code be amended
so if the current theme name is 'default'
then the box is grayed out,
& description message explains unavailable in 'default'.

Many Thanks
ATB
Paul

[JayBachatero]

I'll bring this up on the team boards and see what the Devs' decide.

[basys]

Many thanks Jay

ATB
Paul