Smiley Pops

[Mother Goose]

OOoooooo now see I love you!! Step by step instructions of the simple minded!!!  Perfect!! LOL

Will do Captin'

[Mother Goose]

Ok.. we got it up and working, all was going well. Now I have 11 pages of errors, and the new pop up windows don't pop up.

This is where all the errors are

*****    Today at 12:47:54 PM
216.227.117.27      9800dc60f62325914476d3d8104abc1d
http://homesteadexchangenetwork.net/smf/index.php?action=post;topic=915.0;num_replies=4

8: Undefined index: 11
File: /home/homestea/public_html/smf/Sources/Subs-Post.php
Line: 1258

Any ideas when we did wrong?

[Rumbaar]

In my testings I've installed this mod on a complete fresh and mostly empty test install.  No mods and a fresh install of 1.1.4

Installed mod, created two test groups.  Then in the default icons, tried to move 'evil' icon to the first group and got this error:

Code Select Expand

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'LENGTH(code) DESC' at line 2
File: F:\htdocs\Sources\ManageSmileys.php
Line: 719

Also in the logs

Code Select Expand

http://localhost/index.php?action=smileys;sa=editsmileys
Apply Filter: Only show the errors with the same message
8: Undefined index: smiley_groups
File: F:\htdocs\Themes\default\ManageSmileys.template.php
Line: 303

http://localhost/index.php?action=smileys;sa=editsmileys
Apply Filter: Only show the errors with the same message
2: Invalid argument supplied for foreach()
File: F:\htdocs\Themes\default\ManageSmileys.template.php
Line: 303

http://localhost/index.php?action=smileys;sa=modifygroup;groupid=2
Apply Filter: Only show the errors with the same message
8: Undefined variable: modify_id
File: F:\htdocs\Themes\default\ManageSmileys.template.php
Line: 785

http://localhost/index.php?action=post;topic=18.0;num_replies=0
Apply Filter: Only show the errors with the same message
8: Undefined index: 2
File: F:\htdocs\Sources\Subs-Post.php
Line: 1257

To just name a few.  Are you sure this mod doesn't rely on some other mod to work?  Did it install and run correctly on your site when you were designing it?  Did you maybe have some other mods installed that allowed it to function correctly?

[Mother Goose]

Thank you beyond words Rumbaar for your time and efforts at my forum. I appreciate it a great deal.

[BiGBLiZZ]

This mod relies on SQL to work, and hidden smileys (not icons).  You MUST have selected "enable customized smileys" in Admin>SMileys and Message Icons >Settings.

Also Rumbar, I thank you for your testing, but I never once claimed this worked on local machine tests.  There are differences between running an install of SMF from the harddrive of your computer and on a server, however slight, and I can't take responsibilities for those type of installs.  I know the value as I do it myself for php and java testing, but nothing beats a live test.

To that, I have tested this mod on a fresh install 1.1.3, fresh install of 1.1.4 an install that was 2 years old that had been upgraded from 1.0.5 to .0.7 to RC1, to RC2.. all the way to 1.1.4 and had over 50 mods installed, on forums with 10 to 30 mods installed and on forums still running RC1 or RC2.  To my personal hands on knowledge of the over 30 installs of this mod I have done, nothing has gone wrong.

The errors I have seen come from settings being wrong, permissions being wrong or an outdated SQL database (which is SMF doing, not the Mod).

There are only 5 files this mod deal with, MOST of which are ALWAYS handled by the default theme.  However, if your having problems this is the first thing I would check.  See if your theme uses it's own files instead of the default one.

[Rumbaar]

OK, I test locally to save time.  But I'll also repeat it on a live system.  1.1.4, fresh no other mods or installs.

The only error, other than install errors was this one when I tried to install a group and not specific a group order.

Code Select Expand

You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY groupOrder ASC' at line 4
File: /home/rumbaar/public_html/XXXX/Sources/ManageSmileys.php
Line: 1236

This is the first mod I've found that didn't function that same on my localhost test server and 'live' server.  Could be the versions of php (5) and apache (2) I'm running.

I was using the default theme and had enable custom smileys (or I wouldn't have been able to edit them).

[BiGBLiZZ]

Why wouldn't you give it an order number?  SQL doesn't work in repetitives, and using the hidden feature for this mod, the smileys are either hidden or they are not.  I have taken advantage of this hidden feature and the structure of SQL to make use of the hidden entries.

You can't have articles (in this instance pop up windows) occupy the same space in an SQL table.  So you must give them an order, the only thing I have done here is given you the chance to organize the groups yourself.  I could have simply given the pop ups a sequential order based on the order you put them in, but then you would have to start all over if you wanted group 5 in front of group 2, for example.  Now all you have to do is change the order number.  But because of this, you have to give them an order number to start with.

Perhaps I didn't cover that enough in the readme?

[Fallen Angel]

I tryed to installe this mod and added this in the ManageSmileys.danish-utf8.php:

Code Select Expand


//Masque's Smiley Pops Mod
$txt['smiley_groups'] = 'Manage Groups';
$txt['smiley_groups_explain'] = 'Create, Modify and Delete Smiley Groups';           
$txt['smiley_group_add'] = 'Add Group';


BUT when i try to add a NEW group i get this error;

Code Select Expand


You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'ORDER BY groupOrder ASC' at line 4
Fil: /home/XXXXX/XXXXX/gnot.info/Sources/ManageSmileys.php
Linie: 1236


Can any explain for me whats wrong???

[Sabre™]

Hi..

I installed this mod without any errors.
Then I added a few columns for different smilies and went to test it.

The first thing I noticed, was this in the post screen:

\n'); smileyPopupWindow.document.close(); } // ]]>

It was next to the bbcode boxes, and at the top of the postbox.
Then I clicked on the new columns, and they didnt work.

Upon deleting the mod, I recieved these errors:

1.     Execute Modification     ./Sources/ManageSmileys.php     Test failed
2.    Execute Modification    ./Sources/Subs-Post.php    Test failed
3.    Execute Modification    ./Themes/default/ManageSmileys.template.php    Test failed
4.    Execute Modification    ./Themes/default/Post.template.php    Test failed
5.    Execute Modification    ./Themes/default/languages/ManageSmileys.english.php    Test successful
6.    Execute Code    add_settings.php   

After finally deleting the Mod(manually), all of is options were still there.

Sorry I dont have any screen shots of these, I reverted to installing a previous backup.
But hopefully you may know what happened (conflict with another mod(s) etc..   and be able to fix the prob.

Its a good Mod buddy     Look forward to seeing your conflict free update.

Cheers mate...   And keep up the good work.

[BiGBLiZZ]

Can any explain for me whats wrong???

This syntax error stems from an SQL problem, I can't tell what it is exactly and have my SQL guy looking into it.  The best we can tell right now is that it is a variance somewhere in SMF that relies on php4 coding and actually using php5.

But hopefully you may know what happened (conflict with another mod(s) etc..   and be able to fix the prob.

I saw this once before, and it was from a double install.  Meaning either the installer clicked the install mod button twice, or refreshed the install page, or something.

In the case when I had this happen the install button was clicked twice.

[Sabre™]

Hi buddy 

Just did a fresh install, on a clean site.  No mods etc.
Still got this error when making a post:

\n'); smileyPopupWindow.document.close(); } // ]]>

I know nothing about codes etc so have no idea what this is.
But when I uninstalled it, the error was gone. 

I also clicked the install once       Just to make sure.. lol
Sorry I cant help you locate the source of this error..
But with your level of knowledge, Im sure you'll knock it out in no time

Good luck mate..  I'll check back regularly, cause I want this damn Mod!!!   LOL

Laterz

[jolly_roger]

Hi buddy 

Just did a fresh install, on a clean site.  No mods etc.
Still got this error when making a post:

\n'); smileyPopupWindow.document.close(); } // ]]>

Greetings.
This may happen if your hoster inserting code (like ads) before closing tag </body>
as you can see in Post.template.php:

Code Select Expand

smileyPopupWindow.document.write(\'</td></tr>\n\t\t\t<tr><td align="center" class="windowbg"><a href="javascript:window.close();\\">', $txt['more_smileys_close_window'], '</a></td></tr>\n\t\t</table>\n\t</body>\n</html>\');
so ads gonna be inserted in java script which making page a bit messed. try contact your hoster to disable ads

Sorry for my English :]

-- Edited:
i had same problem with clean smf 1.1.4. solved by removing </body> from code, which i quoted before.

[BiGBLiZZ]

Good catch.  Thanks for that update I will test and have a possible dual release towards the end of January

[Mother Goose]

   

[Sabre™]

Nice one jolly_roger

Thanks alot buddy

[SBurke930]

Here is my error

Code Select Expand

8: Undefined index: 14
File: /home/pogogeek/public_html/Sources/Subs-Post.php
Line: 1257

and here is the line of code

Code Select Expand

                                        'data' => $smiley_group_data[$row['groupNumber']]

I have 12 groups, all of which have smileys in them.  The smileys are working fine but the errors are a pain in the rear.

I am also using the following mods on the forum:

1. Attachments Positioning 1.0   
2. Profile User Action 1.1     
3. Custom Board Sort 1.0.1   
4. AutoSig 1.2   
5. Fix Message Empty Error For Embed Video Mods 1.0     
6. Users Online Today Mod 1.4.0     
7. Admin Notepad 1.0   
8. Add Domaintools to TrackIP 1.0   
9. Member Color Link 2.0.5   
10. Enhanced Quick Reply Box 2.0.2
11. User Control Panel By Alan S 1.3   
12. Integrated Chat 2.7 
13. Smiley Pops 1.1.0 
14. E-Arcade 2.4.2   
15. TinyPortal 0.983
16. Admin Lock Thread 1.2 
17. PhpInfo 1.1   
18. Global Headers Footers 1.3   
19. User Email System 1.2   
20. Admins Can Post As Alternative User 1.0     
21. Auto Embed Video Clips 1.9   

All other mods are working fine at this time.

Is there a fix for this error?

[BiGBLiZZ]

Is this a recurring error? Meaning does it come back if you empty the error log?

90% of the time this error happens as members make posts or send PMs after you create the category and before you add smileys to it.  Which happens a lot on a live board.

If you clear the error log, and do routine maintenance on the forum and it still appears, let me know.

[SBurke930]

It appears after I clear the log.

[Mellissa]

I'm using a custom theme (7dana) and after I installed the mod as well as made the theme edits according to this [nofollow].

In my error log, I get these errors:

http://pash-auctions.net/forum/index.php?action=smileys;sa=editsmileys [nofollow]
2: Invalid argument supplied for foreach()
File: /home/pashauct/public_html/forum/Themes/7dana/ManageSmileys.template.php (eval?)
Line: 303

http://pash-auctions.net/forum/index.php?action=smileys;sa=modifysmiley;smiley= [nofollow]
2: Invalid argument supplied for foreach()
File: /home/pashauct/public_html/forum/Themes/7dana/ManageSmileys.template.php (eval?)
Line: 404

http://pash-auctions.net/forum/index.php?action=smileys;sa=editsmileys [nofollow]
2: Invalid argument supplied for foreach()
File: /home/pashauct/public_html/forum/Themes/7dana/ManageSmileys.template.php (eval?)
Line: 303

http://pash-auctions.net/forum/index.php?action=post;topic=24.0;num_replies=0 [nofollow]
2: Invalid argument supplied for foreach()
File: /home/pashauct/public_html/forum/Themes/default/languages/Post.english-utf8.php (eval?)
Line: 755

But the mod works perfectly fine, just that these errors pop-up in the log o_O

[Stef001]

Hello,

I use the classic template.
In <file name="$themedir/Post.template.php">
i can`t find:
<a href="javascript:void(0);" onclick="replaceText(\' ', $smiley['code'], '\', document.forms.', $context['post_form'], '.', $context['post_box_name'], '); return false;"><img src="', $settings['smileys_url'], '/', $smiley['filename'], '" align="bottom" alt="', $smiley['description'], '" title="', $smiley['description'], '" /></a>';
]]></search>

i also can`t find:

// Finally the most important bit - the actual text box to write in!

and

something.style.backgroundImage = "url(" + smf_images_url + (mode ? "/bbc/bbc_hoverbg.gif)" : "/bbc/bbc_bg.gif)");

Do you have any solution.

Thanks Stef.

Anybody, please?