News:

Want to get involved in developing SMF? Why not lend a hand on our GitHub!

Main Menu

Moderator and Administrator Comment Tags

Started by Arantor, September 01, 2009, 06:26:49 AM

Previous topic - Next topic

kassit

Thanks all
everything is ok

But there are some problem :

1 : when administrator adds a tag, normal user can edit that post and remove the tag.
even the tag will be remove just when normal user edit the post.

2 : you can't understand which moderator has added this tag. simply i can write a wrong name in tag as description

3 : a moderator can delete a tag that has been inserted by administrator.

4 : it was better to add new tags by administrator and you were not forced to use just 3 tags

are you going to solve this problems ?

Kindred

yes yes and yes...   so what?   The mod never claims to be anything other than it is.

"fixing" item 1 would be difficult at best.
item 2 could be updated, but if you can't trust your mods and admins, why are they mods and admins?
item 3, see item 1 and 2.
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Arantor

Speaking as the original author of this mod:

These aren't problems, not really, and you don't need a technical solution to solve a user stupidity problem.

1. Don't edit their post, then. Make a new one where the user can't edit it. This has been said before, more than once, even in the last page or so.

2 & 3. As Kindred said. If they can't be trusted, demote them. The more complex you make something to make it more idiot proof, a better idiot comes along.
Holder of controversial views, all of which my own.


kassit

Dear Arantor

tagging is always used to preventing of making new post. by posting new one, you don't need a tagging system.
It's not so logical to say : Just don't do that

It's not the matter that moderators are trusted or not. A big website may have a lot of experts and moderators.
All moderators are tagging posts and Administrator couldn't ask all of them to know which one has tagged this post.
Also i couldn't say them to always write their name. It's like saying members to write their name where posting.

Dear Kindred

Item 1 is not so hard as you said. ;)
You can just trying to parse the content of a post before showing it. if there is a tag that the current user has not permission to access it, temporarily remove it from edit area and store it in the hidden field. then it will be post to server when saving and you can add it again.

That simple

Kindred

Lol...  That simple??

You are funny...  So, rewrite the entire post display function because you can not trust you mod staff?no offense, but if it is so simple, then go ahead and do it yourself?  The mod author has already indicated no....
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Arantor

Quotetagging is always used to preventing of making new post. by posting new one, you don't need a tagging system.
It's not so logical to say : Just don't do that

How is it not logical to say "Just don't do that." Again, if you don't trust your moderators, don't make them moderators!

QuoteAlso i couldn't say them to always write their name. It's like saying members to write their name where posting.

That's why you make them write a new post which will have their name against it. Like every member's post does! It's automatic.

QuoteYou can just trying to parse the content of a post before showing it. if there is a tag that the current user has not permission to access it, temporarily remove it from edit area and store it in the hidden field. then it will be post to server when saving and you can add it again.

Really, uh huh. So let me get this straight, you want to rewrite the single largest, single slowest, single most complex part of SMF, just because you can't manage your moderators effectively.
Holder of controversial views, all of which my own.


kassit

#386
Dear Arantor and Kindred

I don't understand why you are challenging me just for suggesting a solution.
Ok, i forbear, do what you like.

i had changed that myself in my local system so easily and will be upload so soon in our online forum.
i just thought you may want to develop your mod but seems i was wrong.

Good Luck

Arantor

I'm challenging you because I wrote this mod originally and am only too aware of how complex the suggestion you're proposing is, not to mention how much slower it will make the forum, assuming it's done properly (since there are so many ways to affect what you're talking about, that you probably aren't even aware of)
Holder of controversial views, all of which my own.


kassit

I had changed it myself and will publish it after some necessary changes.

I don't know how did you understand that i'm not aware of things that you mentioned but it's not so important.
I will send you changes although you behave so bad.
then you can see that things are so easier than what you think sometimes.

Don't attack others just because you think they don't know. Maybe you don't know.

End of my participation

Arantor

I didn't mean to come out so aggressively, and for that I'm sorry.

But parse_bbc is the single most complex function in SMF, making changes to it is not a trivial process because of all the different times, different ways, different routes to which it can be called, and any change to it will invariably have consequences that you won't be aware of. I'm not saying that I would necessarily be aware of all of them, but having worked with the SMF code virtually full time for the last 18 months or so, I'm well aware of how fragile it can be at times. This is one of those times.

It's not just called with posts, it's called for signatures, it's called for entries in the moderation centre, it's called for newsletters, the news function, and myriad other places, so for which there won't necessarily be an 'owner' of the content to check against, and checking against the current user's id (as many people seem to think will solve the problem) won't do it either, unless you check it at creation time, though that's not always possible either.
Holder of controversial views, all of which my own.


geoffers


I love this mod, have always found it really useful and like it just the way it is, so many thanks :)

Will it be updated for RC 5 ?

Kindred

works fine for me on RC5 already....   just use the emulate function down at the bottom of the package manager screen
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

geoffers

 
Quote from: Kindred on March 23, 2011, 04:29:18 PM
works fine for me on RC5 already....   just use the emulate function down at the bottom of the package manager screen

D'oh! - missed that - many thanks :)

Cal O'Shaw

Will this excellent MOD be updated formally to 2.0?

Grazie,

Cal

Cal O'Shaw

Hello,

I tried to use Kindred's suggestions to edit the (theme)/css/index.css to make the comments stand out a bit more.

Unfortunately, I've tried to edit the file manually and had no success.

Any suggestions would be most welcome!

Grazie,

Cal

Siirist

Quote from: Cal O'Shaw on June 24, 2011, 02:16:27 AM
Will this excellent MOD be updated formally to 2.0?

Grazie,

Cal

Hi,  :)

Same question.
Tried to parse, but not compatible.  :(
Update for ver 2.0 Final "soon"?  :P

Thanks,
Cloud  8)
Needed information:
- What's your SMF version?, What MODs are installed? What Theme(s) are you using? Have you backed up your database?

--> At least 50% of the questions asked are answered in the Online Manual <--
Mods for ver 1.x will NOT run on ver 2.x

Jessica.

this works perfectly in 2.0! thanks ^_^
Testing Zone - SMF 2.0.7, default Curve
School & Chat - phpBB3, over 170 mods installed, official live forum

I use the latest version of Chrome

phpBB: Forum = a section; Board = whole site
SMF: Forum = whole site; Board = a section

Siirist

Quote from: Jessica. on June 29, 2011, 01:22:18 PM
this works perfectly in 2.0! thanks ^_^

Wait What???!!! :o

It won't parse for SMF ver 2.0 Final,
I downloaded any way and tried install and got the attached screen shot.

Cloud 8)
Needed information:
- What's your SMF version?, What MODs are installed? What Theme(s) are you using? Have you backed up your database?

--> At least 50% of the questions asked are answered in the Online Manual <--
Mods for ver 1.x will NOT run on ver 2.x

Kindred

Use the "advanced" link at the bottom of the packages list....    set it to a version which this does work for (e.g. 2.0 RC3)
Слaва
Украинi

Please do not PM, IM or Email me with support questions.  You will get better and faster responses in the support boards.  Thank you.

"Loki is not evil, although he is certainly not a force for good. Loki is... complicated."

Siirist

#399
Quote from: Kindred on June 29, 2011, 02:03:40 PM
Use the "advanced" link at the bottom of the packages list....    set it to a version which this does work for (e.g. 2.0 RC3)

Hi Kindred,  :)

I went to the package manager,
went to bottom right of page,
clicked on advanced, 2.0 was default,
clicked on apply.
No "Install Mod" present.
Tried to Upload again.
Got message "File exists, Delete before uploading",
deleted file.
Uploaded file,
got
"The file is either corrupted or is incompatible with this version of SMF"
???
I attached screen shots

Thanks, ;)
Cloud


UPDATE: Forgot the screen shots here they are
Needed information:
- What's your SMF version?, What MODs are installed? What Theme(s) are you using? Have you backed up your database?

--> At least 50% of the questions asked are answered in the Online Manual <--
Mods for ver 1.x will NOT run on ver 2.x

Advertisement: