SimpleSEF 2.0 (SMF 1.1.x and SMF 2.0)

[SlammedDime]

Yea, fel, I thought of doing that, I hadn't had the time to test it out though.

[feline]

This I have changed in the extension for XML sitemap for our SEF engine ...

Code Select Expand


function BoardsXML()
{
global $modSettings, $scripturl, $boardurl;

// Get our information from the database
if (($boards = cache_get_data('xml_boards', $modSettings['sitemap_cache_ttl'])) == null)
{
$temp_boards = list_getBoards(0, 0, 'm.poster_time DESC');

// SEF engine loaded?
if(function_exists('getBoardName'))
{
$xmlurl = $boardurl;
$urlFunc = create_function('$id, $url', 'return $url ."/". getBoardName($id .".0");');
}
else
{
$xmlurl = $scripturl;
$urlFunc = create_function('$id, $url', 'return fix_possible_url($url ."?board=". $id ."0");');
}

// And assign it to an array
$boards = array();
foreach ($temp_boards as $row)
{
$boards[] = array(
'url' => $urlFunc($row['id_board'], $xmlurl),
'time' => date_iso8601($row['poster_time']),
'priority' => priority($row['poster_time']),
);
}
cache_put_data('xml_boards', $boards, $modSettings['sitemap_cache_ttl']);
}

return $boards;
}


Code Select Expand


function TopicsXML()
{
global $modSettings, $scripturl, $boardurl;

if (($topics = cache_get_data('xml_topics', $modSettings['sitemap_cache_ttl'])) == null)
{
$temp_topics = list_getTopics(0, $modSettings['sitemap_topic_count'], 'm.poster_time DESC');

// SEF engine loaded?
if(function_exists('getTopicName'))
{
$xmlurl = $boardurl;
$urlFunc = create_function('$id, $url', 'return $url ."/". getTopicName($id);');
}
else
{
$xmlurl = $scripturl;
$urlFunc = create_function('$id, $url', 'return fix_possible_url($url ."?topic=". $id ."0");');
}

// Assign it to the array
$topics = array();
foreach ($temp_topics as $row)
{
$topics[] = array(
'url' => $urlFunc($row['id_topic'], $xmlurl),
'time' => date_iso8601($row['poster_time']),
'priority' => priority($row['poster_time']),
'changefreq' => changefreq($row['first_time'], $row['num_replies']),
);
}
cache_put_data('xml_topics', $topics, $modSettings['sitemap_cache_ttl']);
}

return $topics;
}


Fel

[Am']

hi

it's compatible with 2.rc3 ?

thx

[SlammedDime]

Version 2.0 is not, only version 1.1.1.

[[Axel]]

Version 2.0 is not, only version 1.1.1.

Now I'm a bit confused O_o

I run SimpleSEF 2.0 on SMF2.rc.5 without any problems.
Do you mean it does not work together with the XML sitemap extension? or... ?

[SlammedDime]

Am' asked if the mod was compatible with 2.0 RC3, I replied that version SimpleSEF 2.0 is not, only version SimpleSEF 1.1.1 is.

[Arantor]

Just curious... how does the fact that the 2.0 version of this requiring PHP 5 mod square with the Cust team rules that mods must support all the versions that SMF does (like PHP 4.3)?

[SlammedDime]

There is a PHP 4 compatible version still available for download.

Also, the cust team has been allowing mods that don't specifically meet SMF's requirements (like mods that only support MySQL), so long as it's clearly stated on the mod's download page.

[Arantor]

Ahhhhh, I see. (Just that's not in the guidelines)

Was just curious as I was looking through SSEF this morning for some compatibility code with the stuff in the next version of SimpleDesk. (As it happens, that will have to require PHP 4.3.0 now)

[feline]

Was just curious as I was looking through SSEF this morning for some compatibility code with the stuff in the next version of SimpleDesk. (As it happens, that will have to require PHP 4.3.0 now)

Because PoraMx have his own SEF engine (SSEF fork) it's interesting to test that with SimpleDesk.
Is a beta/dev version available for this test?

[Arantor]

Is a beta/dev version available for this test?

There will be in a few hours when the midnight GMT build runs, as you're still a beta tester there IIRC?

If you use the same basic process as SSEF I suspect it'll work alright but I really don't plan to spend too much time on it, 3 hours perfecting the regular expression this morning was enough, thanks.

[feline]

There will be in a few hours when the midnight GMT build runs, as you're still a beta tester there IIRC?

Yes .. thanks, I will test this next days with PortaMx ...

[SlammedDime]

PortaMX's SEF engine was based on SimpleSEF 1.1, not 2.0, so it may not work depending on what you were doing with it Pete.

[pzyhô]

fel - the captcha image issue has been fixed in the new package for a while now... SimpleDesk's Team found and reported that a couple weeks ago.  I'm going through this topic to make sure I got all known bugs and hoping to make a release today.

doesnt seems to be fixed i got this problem with captcha if i turn SimpleSEF on
and if i turn off all work fine.

so how can i fix it ?

[NanoSector]

fel - the captcha image issue has been fixed in the new package for a while now... SimpleDesk's Team found and reported that a couple weeks ago.  I'm going through this topic to make sure I got all known bugs and hoping to make a release today.

doesnt seems to be fixed i got this problem with captcha if i turn SimpleSEF on
and if i turn off all work fine.

so how can i fix it ?

fel - the captcha image issue has been fixed in the new package for a while now... SimpleDesk's Team found and reported that a couple weeks ago.  I'm going through this topic to make sure I got all known bugs and hoping to make a release today.

As in, install the new package.

[Arantor]

Um, note the day - one year ago.

This is almost certainly a slightly different bug to the one we reported a year ago.

[NanoSector]

Um, note the day - one year ago.

This is almost certainly a slightly different bug to the one we reported a year ago.

So? Question was today. And the user said "this problem", pointing at what SD said.

[Arantor]

It's not the same problem, it is actually a different one.

[NanoSector]

It's not the same problem, it is actually a different one.

Um, note the day - one year ago.

This is almost certainly a slightly different bug to the one we reported a year ago.

the user said "this problem", pointing at what SD said.

[Arantor]

And, again I must repeat myself.

It is a DIFFERENT PROBLEM. They have similar symptoms but the cause is different because they're different things entirely. The code is different to that of a year ago!